From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22745C3DA7F for ; Wed, 7 Aug 2024 19:50:25 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YRhbpR9/; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YRhbpR9/; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4WfLPW5XZsz3d9s for ; Thu, 8 Aug 2024 05:50:23 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YRhbpR9/; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YRhbpR9/; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.129.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=peterx@redhat.com; receiver=lists.ozlabs.org) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4WfLMD550Rz3d96 for ; Thu, 8 Aug 2024 05:48:22 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723060099; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9Kq72BfB1Q9PD26Udwsuz2Gt7rCvKvwunl3vkpU7op8=; b=YRhbpR9/bEBQ8FUkOxax6RVR0ouj58Zp+y5gK9iyFahINpBqNP8GnN5ZpwUHd4OH997LhK /b6YVpDcM9UIEtnJB0OX1GAk/Z9bxN+vLq+sohBtKQA8Ez7UPrgh3UHuZDuDGkSOw3Ay1X UkdnqvIku3b/RUybWhHrb51jgftYABk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723060099; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9Kq72BfB1Q9PD26Udwsuz2Gt7rCvKvwunl3vkpU7op8=; b=YRhbpR9/bEBQ8FUkOxax6RVR0ouj58Zp+y5gK9iyFahINpBqNP8GnN5ZpwUHd4OH997LhK /b6YVpDcM9UIEtnJB0OX1GAk/Z9bxN+vLq+sohBtKQA8Ez7UPrgh3UHuZDuDGkSOw3Ay1X UkdnqvIku3b/RUybWhHrb51jgftYABk= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-447-nczqYeA1PGCtz_hvbNZ4Lw-1; Wed, 07 Aug 2024 15:48:18 -0400 X-MC-Unique: nczqYeA1PGCtz_hvbNZ4Lw-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-6b7a0e7b823so476426d6.0 for ; Wed, 07 Aug 2024 12:48:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723060097; x=1723664897; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9Kq72BfB1Q9PD26Udwsuz2Gt7rCvKvwunl3vkpU7op8=; b=Qa/ZTkEeaSWU0dT410edeOrWMnZB90pupl/3H/sI+THnLD1AfUV9iRk18SeHSi660w Hy7kHIffiWhNy5hffQXub0NLxANzTGdhg80PJUKJwAO02PLtkT2Oop4A7im9+X/gSCHq eP5Vu5g7XaBU4cyIPuN7g9RA3A+7yiFdS+XGn2lzGufOFBfzZoSSAGiEmWTjvR0bwpb6 81nChzP1/MqJw9B7TiVcM0PU3Ar5cHqXqX6MeEVOOZRMLvJECdT0zT7vDsz5xe/SxBZI +5f6db6ptAkaINaWSXaaN8T7bRnfqo+tbPhTLPKdHQ6jywNhc2FInf/SZpuckcSXUTqv yL0w== X-Forwarded-Encrypted: i=1; AJvYcCV03ILoiKUklJKs1X4cxFwsER71XarvIz4JZHsvKYC/MEwO4bfZncqX99bfnRLjzQwzUQ3hkG+MTufQAU8=@lists.ozlabs.org X-Gm-Message-State: AOJu0Yym5BKXX9nn95ukTYsIXG10OVgfuwFGPpLKrrczPIbLSXxJFKYd PaWuoIBrGHCrSCLKHWaFkUH2mFjXkNgIqeTe5ChDKpIOqlFaDXSNpHKIeC9ICKrpSjd9bFwaKZ9 KVUxckMhRS+rLu/xE7D0DZ28Q2kKbLcF3jN6RJoI/PTLdJuwBD5ysVQvPH1pGE7M= X-Received: by 2002:ad4:5f89:0:b0:6b2:b5b5:124e with SMTP id 6a1803df08f44-6bb98201fe5mr130641396d6.0.1723060097407; Wed, 07 Aug 2024 12:48:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE2kwiMDYWwjAOmnvJrXFpiL3DqhuBYXy1c4XYYU13it34Yz8NGLRxRmyIIbMBrd7nnJuhzgA== X-Received: by 2002:ad4:5f89:0:b0:6b2:b5b5:124e with SMTP id 6a1803df08f44-6bb98201fe5mr130641186d6.0.1723060096990; Wed, 07 Aug 2024 12:48:16 -0700 (PDT) Received: from x1n.redhat.com (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6bb9c78ae4asm59853256d6.33.2024.08.07.12.48.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Aug 2024 12:48:16 -0700 (PDT) From: Peter Xu To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH v4 1/7] mm/dax: Dump start address in fault handler Date: Wed, 7 Aug 2024 15:48:05 -0400 Message-ID: <20240807194812.819412-2-peterx@redhat.com> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20240807194812.819412-1-peterx@redhat.com> References: <20240807194812.819412-1-peterx@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: James Houghton , David Hildenbrand , Dave Hansen , peterx@redhat.com, Christophe Leroy , Dan Williams , Dave Jiang , "Aneesh Kumar K . V" , x86@kernel.org, Hugh Dickins , Matthew Wilcox , Ingo Molnar , Huang Ying , Rik van Riel , Nicholas Piggin , Borislav Petkov , "Kirill A . Shutemov" , Thomas Gleixner , Vlastimil Babka , Oscar Salvador , linuxppc-dev@lists.ozlabs.org, Andrew Morton , Rick P Edgecombe , Mel Gorman Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Currently the dax fault handler dumps the vma range when dynamic debugging enabled. That's mostly not useful. Dump the (aligned) address instead with the order info. Acked-by: David Hildenbrand Signed-off-by: Peter Xu --- drivers/dax/device.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/dax/device.c b/drivers/dax/device.c index 2051e4f73c8a..9c1a729cd77e 100644 --- a/drivers/dax/device.c +++ b/drivers/dax/device.c @@ -235,9 +235,9 @@ static vm_fault_t dev_dax_huge_fault(struct vm_fault *vmf, unsigned int order) int id; struct dev_dax *dev_dax = filp->private_data; - dev_dbg(&dev_dax->dev, "%s: %s (%#lx - %#lx) order:%d\n", current->comm, - (vmf->flags & FAULT_FLAG_WRITE) ? "write" : "read", - vmf->vma->vm_start, vmf->vma->vm_end, order); + dev_dbg(&dev_dax->dev, "%s: op=%s addr=%#lx order=%d\n", current->comm, + (vmf->flags & FAULT_FLAG_WRITE) ? "write" : "read", + vmf->address & ~((1UL << (order + PAGE_SHIFT)) - 1), order); id = dax_read_lock(); if (order == 0) -- 2.45.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDF941448FF for ; Wed, 7 Aug 2024 19:48:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723060102; cv=none; b=IeO69GHuZ/EiLxYaimMTmluzUCCmTiAREZkGcpw/3RErZGHUqX08AbQbg77d7a45a7lRkMmuAAxwCEzqxg304EFgIKKqdcx1bAg2f0EwEZziSI7AKLdqI6ceamnPyVVJtDuShF+P2vqr2WZVrCOhj63Pv5qLN5yXL/P9tiwckvI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723060102; c=relaxed/simple; bh=XL7oTSSTB/8YDtl+/bwPSSNlnKCeA31jQyxrFRfpnLw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gNeq5y0VrB86jOr9xG5MTa+a0IT53ew2PwaFyaiofmR/hQWZMOQ5nwXckQi87T0SKENzbVT6FypoFZ1HbZ/IuMc5WGXtQlEZmJ029KUNCmWFY/G65gfu0FNWLtbhhoAO7KoS1Xe9KBw5BsxHC9Abkif0uQYLq+ddacB00f1LWlM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=XVpcwFW1; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XVpcwFW1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723060099; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9Kq72BfB1Q9PD26Udwsuz2Gt7rCvKvwunl3vkpU7op8=; b=XVpcwFW1S7v+Z2qL7qm9Ot6NiZFICCdE9T1xZUptlXwv1bTZ7errLgfcHnn8FrVyolJs2s Z2vYP91jsLadMuJuJl34M4jWTWdDTpNLRQo1nb+DCvXGB5AHauTEIKxsdhLXCE1mIs2CX8 5kzTkIvc2pQyIJdDgg7jQyNQILmKgvE= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-562-rfhsveJVOXW7rEfvh9HXtg-1; Wed, 07 Aug 2024 15:48:18 -0400 X-MC-Unique: rfhsveJVOXW7rEfvh9HXtg-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6b95c005dbcso498486d6.1 for ; Wed, 07 Aug 2024 12:48:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723060098; x=1723664898; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9Kq72BfB1Q9PD26Udwsuz2Gt7rCvKvwunl3vkpU7op8=; b=lppUPqLS9cudKwKApeN1sCQMQ97n1GcW/NOe87Ju/a6oxjG18wHECUR4Us3iXI2L1W pKZa3LZNO4afibOcn6p/XUidknILK7XBJ1lr89sjvt+MZ91/90sELfRI59VVGVip8i40 Z1slDuHO0/GvFuYMhcVM7SCey2hXhHOV2B6cpNxyMJYVuMvsK2S13Ewct3miuDe3neP7 YYSaNeTcxFCIBg5lnI9ytrPh0shh2T1UUmRSyMZyYhTlLhgpi8CAFwwe8ZZfBAFxdt6Z I1mjhMW9ZWVJvWP2UmB/PFzldGJM02AZIIg7pQ4sH8TAGhSgwMXI74oOh35AokgdUzE0 AaKg== X-Gm-Message-State: AOJu0YwO7lSdAzb9GWLOlbpS+F03lVBSoXYyhEl2VSut1HSf/prc1Zf0 PqxZXf+thmYM9F5O3Fx0qsTxMUGW9Oj7aJzFeva8GHTtvjIUx6Cuoiflhs4C3suQgCCLYlqgi4H Yma7I/hd1UdNGkwPpJBfocRhS6Mw3D+L+heEjWNDWoleZgdDX+Iu2CDk7ygtvzR179xqc9LgpLR jriT4jogzmPGADqglIDmK2feipfCxUxTKxJ86T1cNlZPc= X-Received: by 2002:ad4:5f89:0:b0:6b2:b5b5:124e with SMTP id 6a1803df08f44-6bb98201fe5mr130641606d6.0.1723060097570; Wed, 07 Aug 2024 12:48:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE2kwiMDYWwjAOmnvJrXFpiL3DqhuBYXy1c4XYYU13it34Yz8NGLRxRmyIIbMBrd7nnJuhzgA== X-Received: by 2002:ad4:5f89:0:b0:6b2:b5b5:124e with SMTP id 6a1803df08f44-6bb98201fe5mr130641186d6.0.1723060096990; Wed, 07 Aug 2024 12:48:16 -0700 (PDT) Received: from x1n.redhat.com (pool-99-254-121-117.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6bb9c78ae4asm59853256d6.33.2024.08.07.12.48.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Aug 2024 12:48:16 -0700 (PDT) From: Peter Xu To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: "Aneesh Kumar K . V" , Michael Ellerman , Oscar Salvador , Dan Williams , James Houghton , Matthew Wilcox , Nicholas Piggin , Rik van Riel , Dave Jiang , Andrew Morton , x86@kernel.org, Ingo Molnar , Rick P Edgecombe , "Kirill A . Shutemov" , peterx@redhat.com, linuxppc-dev@lists.ozlabs.org, Mel Gorman , Hugh Dickins , Borislav Petkov , David Hildenbrand , Thomas Gleixner , Vlastimil Babka , Dave Hansen , Christophe Leroy , Huang Ying Subject: [PATCH v4 1/7] mm/dax: Dump start address in fault handler Date: Wed, 7 Aug 2024 15:48:05 -0400 Message-ID: <20240807194812.819412-2-peterx@redhat.com> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20240807194812.819412-1-peterx@redhat.com> References: <20240807194812.819412-1-peterx@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently the dax fault handler dumps the vma range when dynamic debugging enabled. That's mostly not useful. Dump the (aligned) address instead with the order info. Acked-by: David Hildenbrand Signed-off-by: Peter Xu --- drivers/dax/device.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/dax/device.c b/drivers/dax/device.c index 2051e4f73c8a..9c1a729cd77e 100644 --- a/drivers/dax/device.c +++ b/drivers/dax/device.c @@ -235,9 +235,9 @@ static vm_fault_t dev_dax_huge_fault(struct vm_fault *vmf, unsigned int order) int id; struct dev_dax *dev_dax = filp->private_data; - dev_dbg(&dev_dax->dev, "%s: %s (%#lx - %#lx) order:%d\n", current->comm, - (vmf->flags & FAULT_FLAG_WRITE) ? "write" : "read", - vmf->vma->vm_start, vmf->vma->vm_end, order); + dev_dbg(&dev_dax->dev, "%s: op=%s addr=%#lx order=%d\n", current->comm, + (vmf->flags & FAULT_FLAG_WRITE) ? "write" : "read", + vmf->address & ~((1UL << (order + PAGE_SHIFT)) - 1), order); id = dax_read_lock(); if (order == 0) -- 2.45.0