From: Jakub Kicinski <kuba@kernel.org>
To: Erni Sri Satya Vennela <ernis@linux.microsoft.com>
Cc: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
decui@microsoft.com, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, linux-hyperv@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
ernis@microsoft.com
Subject: Re: [PATCH] net: netvsc: Increase default VMBus channel from 8 to 16
Date: Wed, 7 Aug 2024 20:18:57 -0700 [thread overview]
Message-ID: <20240807201857.445f9f95@kernel.org> (raw)
In-Reply-To: <1722923751-27296-1-git-send-email-ernis@linux.microsoft.com>
On Mon, 5 Aug 2024 22:55:51 -0700 Erni Sri Satya Vennela wrote:
> Performance tests showed significant improvement in throughput:
> - 0.54% for 16 vCPUs
> - 1.51% for 32 vCPUs
> - 0.72% for 48 vCPUs
> - 5.57% for 64 vCPUs
> - 9.14% for 96 vCPUs
Could you please switch to netif_get_num_default_rss_queues() ?
It used to return hard coded 8, but now it returns #physical cores / 2.
That's based on broad experience with Meta's workloads. Some workloads
need more some needs fewer, but broadly half of physical cores is
a good guess for 90%+
Assuming you have thread siblings in those vCPUs above it should
match what you want, too.
--
pw-bot: cr
prev parent reply other threads:[~2024-08-08 3:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-06 5:55 [PATCH] net: netvsc: Increase default VMBus channel from 8 to 16 Erni Sri Satya Vennela
2024-08-08 3:18 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240807201857.445f9f95@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=edumazet@google.com \
--cc=ernis@linux.microsoft.com \
--cc=ernis@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.