All of lore.kernel.org
 help / color / mirror / Atom feed
From: Igor Gutorov <igootorov@gmail.com>
To: dev@dpdk.org
Cc: Igor Gutorov <igootorov@gmail.com>
Subject: [PATCH v3 0/2] net/mlx5: fix reported Rx/Tx desc limits
Date: Wed,  7 Aug 2024 23:44:04 +0300	[thread overview]
Message-ID: <20240807204406.700332-1-igootorov@gmail.com> (raw)
In-Reply-To: <IA1PR12MB807824F2008B2D750A4CCCC4DFCB2@IA1PR12MB8078.namprd12.prod.outlook.com>

Hi, Slava

> > Is an `int` appropriate for `log_max_wq_sz`? Seems like a `uint8_t`
> > is sufficient, but I've left it an `int` for consistency with the
> > other `log_max_*` values.
> 
> Right, uint8_t looks to be enough. No objection to optimize others to
> uint8_t.

Changed log_max_wq_sz to uint8_t in the main patch. The others are
changed in a separate patch. Let me know if it'd be preferrable to
squash the patches.

> > 
> > > 4. Please, format your patch according to the "fix" template.
> > 
> > I've reworded the commit message a little bit. But I don't see these
> > issues on Bugzilla, I've stumbled upon them independently. If you'd
> > like the bug reports to be created, let me know.
> 
> I meant this: https://doc.dpdk.org/guides/contributing/patches.html
> Please see chapter "8.7. Commit Messages: Body" about "Fixes" and "Cc:
> stable@dpdk.org".

It is a bit difficult for me to reference a commit for the "Fixes",
since it's a bit hard to call this a regression specifically. I set this
tag to the commit that first introduced configuring the device. Is that
appropriate?

> 
> Also, please run checking script: /devtools/check-git-log.sh' -1 to
> verify commit message compliance.

Thanks! No warnings now, except for "Wrong headline prefix" for the
first patch because it modifies both common/mlx5 and net/mlx5. I can
split the patch into two if needed.


v3:
* Added uint8_t optimization
* Fixed commit messages

v2:
* Patch reworked to query HCA attributes

Igor Gutorov (2):
  net/mlx5: fix reported Rx/Tx desc limits
  common/mlx5: reduce HCA attribute type sizes

 drivers/common/mlx5/mlx5_devx_cmds.c | 1 +
 drivers/common/mlx5/mlx5_devx_cmds.h | 9 +++++----
 drivers/net/mlx5/mlx5_ethdev.c       | 4 ++++
 drivers/net/mlx5/mlx5_rxq.c          | 8 ++++++++
 drivers/net/mlx5/mlx5_txq.c          | 8 ++++++++
 5 files changed, 26 insertions(+), 4 deletions(-)

-- 
2.45.2


  reply	other threads:[~2024-08-07 20:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-16 17:38 [PATCH 0/1] net/mlx5: show rx/tx descriptor ring limitations in rte_eth_dev_info Igor Gutorov
2024-06-16 17:38 ` [PATCH 1/1] " Igor Gutorov
2024-06-17  7:18   ` Slava Ovsiienko
2024-06-18 22:56     ` [PATCH v2 0/1] net/mlx5: fix incorrect rx/tx descriptor " Igor Gutorov
2024-06-18 22:56       ` [PATCH v2] " Igor Gutorov
2024-10-07 20:37         ` Stephen Hemminger
2024-06-23 11:34       ` [PATCH v2 0/1] " Slava Ovsiienko
2024-08-07 20:44         ` Igor Gutorov [this message]
2024-08-07 20:44           ` [PATCH v3 1/2] net/mlx5: fix reported Rx/Tx desc limits Igor Gutorov
2024-10-28 15:47             ` Slava Ovsiienko
2024-08-07 20:44           ` [PATCH v3 2/2] common/mlx5: reduce HCA attribute type sizes Igor Gutorov
2024-10-28 15:48             ` Slava Ovsiienko
2024-08-07 20:58           ` [PATCH v3 0/2] net/mlx5: fix reported Rx/Tx desc limits Igor Gutorov
2024-09-19 19:42             ` Igor Gutorov
2024-10-30 14:19           ` Raslan Darawsheh
2024-10-10  0:18     ` [PATCH 1/1] net/mlx5: show rx/tx descriptor ring limitations in rte_eth_dev_info Stephen Hemminger
2024-10-10  9:06       ` Igor Gutorov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240807204406.700332-1-igootorov@gmail.com \
    --to=igootorov@gmail.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.