From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Esther Shimanovich <eshimanovich@chromium.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Rajat Jain <rajatja@google.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Lukas Wunner <lukas@wunner.de>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
iommu@lists.linux.dev,
Mario Limonciello <mario.limonciello@amd.com>
Subject: Re: [PATCH] PCI: Detect and trust built-in TBT chips
Date: Thu, 8 Aug 2024 08:01:29 +0300 [thread overview]
Message-ID: <20240808050129.GH1532424@black.fi.intel.com> (raw)
In-Reply-To: <CA+Y6NJE0QB-W7hBOD_S1XwoSosg3Hh1FH0a8Um16g3Ex_1V9=w@mail.gmail.com>
On Wed, Aug 07, 2024 at 05:15:36PM -0400, Esther Shimanovich wrote:
> On Wed, Aug 7, 2024 at 3:17 AM Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> >
> > I suggest opening the heuristic here a bit more.
>
> Could you clarify what you mean by "opening the heuristic"?
> What details should I remove?
I mean not to remove anything but open up how we "detect" the built-in
controlllers.
> And add the links to
> > the Microsoft firmware document somewhere. These:
> >
> > https://learn.microsoft.com/en-us/windows-hardware/drivers/pci/dsd-for-pcie-root-ports#mapping-native-protocols-pcie-displayport-tunneled-through-usb4-to-usb4-host-routers
> > https://learn.microsoft.com/en-us/windows-hardware/drivers/pci/dsd-for-pcie-root-ports#identifying-externally-exposed-pcie-root-ports
>
> Is it good enough to have them in the commit message? Or should they
> be linked in probe.c?
IMHO they can be in the commit message.
prev parent reply other threads:[~2024-08-08 5:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-06 21:39 [PATCH] PCI: Detect and trust built-in TBT chips Esther Shimanovich
2024-08-06 22:04 ` Bjorn Helgaas
2024-08-07 6:54 ` Mika Westerberg
2024-08-07 21:17 ` Esther Shimanovich
2024-08-08 5:22 ` Mika Westerberg
2024-08-25 14:57 ` Lukas Wunner
2024-08-07 7:17 ` Mika Westerberg
2024-08-07 21:15 ` Esther Shimanovich
2024-08-08 5:01 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240808050129.GH1532424@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=eshimanovich@chromium.org \
--cc=iommu@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mario.limonciello@amd.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rajatja@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.