From: Jakub Kicinski <kuba@kernel.org>
To: Rosen Penev <rosenp@gmail.com>
Cc: netdev@vger.kernel.org, u.kleine-koenig@pengutronix.de,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: moxart_ether: use devm in probe
Date: Thu, 8 Aug 2024 07:58:55 -0700 [thread overview]
Message-ID: <20240808075855.33efccbe@kernel.org> (raw)
In-Reply-To: <20240808040425.5833-1-rosenp@gmail.com>
On Wed, 7 Aug 2024 21:03:54 -0700 Rosen Penev wrote:
> alloc_etherdev and kmalloc_array are called first and destroyed last.
> Safe to use devm to remove frees.
But why? Refactoring old drivers is often more risk than reward.
How did you test this change?
--
pw-bot: cr
prev parent reply other threads:[~2024-08-08 14:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 4:03 [PATCH net-next] net: moxart_ether: use devm in probe Rosen Penev
2024-08-08 8:18 ` Christophe JAILLET
2024-08-08 20:21 ` Rosen Penev
2024-08-08 14:58 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240808075855.33efccbe@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rosenp@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.