From: Stephen Hemminger <stephen@networkplumber.org>
To: Hanxiao Li <li.hanxiao@zte.com.cn>
Cc: dev@dpdk.org
Subject: Re: [PATCH 3/4] [v1,3/4] zsda: add support for queue operation
Date: Thu, 8 Aug 2024 08:19:12 -0700 [thread overview]
Message-ID: <20240808081912.31f633d7@hermes.local> (raw)
In-Reply-To: <20240808085030.1685755-3-li.hanxiao@zte.com.cn>
On Thu, 8 Aug 2024 16:50:13 +0800
Hanxiao Li <li.hanxiao@zte.com.cn> wrote:
> +int
> +zsda_get_queue_cfg(struct zsda_pci_device *zsda_pci_dev)
> +{
> + uint8_t i = 0;
Useless initialization, you are setting it the first loop.
> + uint32_t index = 0;
> + enum zsda_service_type type = ZSDA_SERVICE_INVALID;
> + struct zsda_qp_hw *zsda_hw_qps = zsda_pci_dev->zsda_hw_qps;
> + struct qinfo qcfg;
> + int ret = 0;
Another useless initialization.
> +
> + for (i = 0; i < zsda_num_used_qps; i++) {
next prev parent reply other threads:[~2024-08-08 15:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 8:50 [PATCH 1/4] [v1,1/4] zsda: Introduce zsda device drivers Hanxiao Li
2024-08-08 8:50 ` [PATCH 2/4] [v1,2/4] zsda: add support for zsdadev operations Hanxiao Li
2024-08-08 8:50 ` [PATCH 3/4] [v1,3/4] zsda: add support for queue operation Hanxiao Li
2024-08-08 15:18 ` Stephen Hemminger
2024-08-08 15:19 ` Stephen Hemminger [this message]
2024-08-08 8:50 ` [PATCH 4/4] [v1,4/4] zsda: add compressdev driver and interface Hanxiao Li
2024-08-08 15:22 ` [PATCH 1/4] [v1,1/4] zsda: Introduce zsda device drivers Stephen Hemminger
2024-08-15 1:50 ` li.hanxiao
2024-08-08 15:23 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240808081912.31f633d7@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=li.hanxiao@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.