From: Jakub Kicinski <kuba@kernel.org>
To: Gal Pressman <gal@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Dragos Tatulea <dtatulea@nvidia.com>,
Jianbo Liu <jianbol@nvidia.com>
Subject: Re: [PATCH net v2] ethtool: Fix context creation with no parameters
Date: Thu, 8 Aug 2024 08:59:51 -0700 [thread overview]
Message-ID: <20240808085951.15a522f2@kernel.org> (raw)
In-Reply-To: <20240807173352.3501746-1-gal@nvidia.com>
I'll make some minor modifications when applying..
On Wed, 7 Aug 2024 20:33:52 +0300 Gal Pressman wrote:
> if ((rxfh.indir_size &&
> rxfh.indir_size != ETH_RXFH_INDIR_NO_CHANGE &&
> rxfh.indir_size != dev_indir_size) ||
> - (rxfh.key_size && (rxfh.key_size != dev_key_size)) ||
> - (rxfh.indir_size == ETH_RXFH_INDIR_NO_CHANGE &&
> + (rxfh.key_size && (rxfh.key_size != dev_key_size)))
We should take this opportunity to remove the pointless brackets
around key size comparison. Same clause for indir is not bracketed.
> + return -EINVAL;
> +
> + /* Must request at least one change: indir size, hash key, function
> + * or input transformation.
> + * There's no need for any of it in case of context creation.
> + */
> + if (!create && (rxfh.indir_size == ETH_RXFH_INDIR_NO_CHANGE &&
> rxfh.key_size == 0 && rxfh.hfunc == ETH_RSS_HASH_NO_CHANGE &&
And here if (!create should probably be on a line of its own.
Otherwise continuation lines don't align with the opening bracket.
prev parent reply other threads:[~2024-08-08 15:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 17:33 [PATCH net v2] ethtool: Fix context creation with no parameters Gal Pressman
2024-08-08 9:47 ` Edward Cree
2024-08-08 15:59 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240808085951.15a522f2@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=jianbol@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.