From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: "Mickaël Salaün" <mic@digikod.net>,
"Günther Noack" <gnoack@google.com>,
ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v5 3/6] Disable kernel version check in landlock tests
Date: Thu, 8 Aug 2024 11:58:24 +0200 [thread overview]
Message-ID: <20240808095824.GC327665@pevik> (raw)
In-Reply-To: <20240801-landlock-v5-3-663d7383b335@suse.com>
Hi Andrea,
> The reason why we remove kernel version check is that we use
> verify_landlock_is_enabled() function in order to check if landlock is
> present in the system. This is really helpful when landlock support has
> been backported into old kernels.
Great, I'm glad you removed it from all landlock tests. It really did not make
sense to guard correct version with 3 guards (kernel version, kernel config and
ABI). Could you please remove also CONFIG_SECURITY_LANDLOCK=y, because you
check EOPNOTSUPP in verify_landlock_is_enabled().
Anyway, feel free to merge these first 3 patches (ideally remove also
CONFIG_SECURITY_LANDLOCK=y before merge).
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-08-08 9:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 12:08 [LTP] [PATCH v5 0/6] landlock testing suite Andrea Cervesato
2024-08-01 12:08 ` [LTP] [PATCH v5 1/6] Get ABI version from landlock common library Andrea Cervesato
2024-08-08 9:37 ` Petr Vorel
2024-08-01 12:08 ` [LTP] [PATCH v5 2/6] Add CAP_MKNOD fallback in lapi/capability.h Andrea Cervesato
2024-08-08 9:39 ` Petr Vorel
2024-08-01 12:08 ` [LTP] [PATCH v5 3/6] Disable kernel version check in landlock tests Andrea Cervesato
2024-08-08 9:58 ` Petr Vorel [this message]
2024-08-08 12:04 ` Andrea Cervesato via ltp
2024-08-09 14:36 ` Mickaël Salaün
2024-08-10 8:58 ` Andrea Cervesato via ltp
2024-08-12 19:15 ` Petr Vorel
2024-08-13 17:32 ` Petr Vorel
2024-08-01 12:08 ` [LTP] [PATCH v5 4/6] Add landlock04 test Andrea Cervesato
2024-08-01 12:08 ` [LTP] [PATCH v5 5/6] Add landlock05 test Andrea Cervesato
2024-08-01 12:08 ` [LTP] [PATCH v5 6/6] Add landlock06 test Andrea Cervesato
2024-08-08 12:25 ` [LTP] [PATCH v5 0/6] landlock testing suite Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240808095824.GC327665@pevik \
--to=pvorel@suse.cz \
--cc=andrea.cervesato@suse.de \
--cc=gnoack@google.com \
--cc=ltp@lists.linux.it \
--cc=mic@digikod.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.