All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Elliot Berman <quic_eberman@quicinc.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH RFC 4/4] mm: guest_memfd: Add ability for mmap'ing pages
Date: Thu, 8 Aug 2024 10:44:35 +0800	[thread overview]
Message-ID: <202408081018.maLT93SE-lkp@intel.com> (raw)
In-Reply-To: <20240805-guest-memfd-lib-v1-4-e5a29a4ff5d7@quicinc.com>

Hi Elliot,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on 8400291e289ee6b2bf9779ff1c83a291501f017b]

url:    https://github.com/intel-lab-lkp/linux/commits/Elliot-Berman/mm-Introduce-guest_memfd/20240806-024238
base:   8400291e289ee6b2bf9779ff1c83a291501f017b
patch link:    https://lore.kernel.org/r/20240805-guest-memfd-lib-v1-4-e5a29a4ff5d7%40quicinc.com
patch subject: [PATCH RFC 4/4] mm: guest_memfd: Add ability for mmap'ing pages
config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20240808/202408081018.maLT93SE-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240808/202408081018.maLT93SE-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408081018.maLT93SE-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> mm/guest_memfd.c:115:16: warning: unused variable 'i' [-Wunused-variable]
     115 |         unsigned long i;
         |                       ^
   1 warning generated.


vim +/i +115 mm/guest_memfd.c

   111	
   112	int guest_memfd_make_inaccessible(struct file *file, struct folio *folio)
   113	{
   114		unsigned long gmem_flags = (unsigned long)file->private_data;
 > 115		unsigned long i;
   116		int r;
   117	
   118		unmap_mapping_folio(folio);
   119	
   120		/**
   121		 * We can't use the refcount. It might be elevated due to
   122		 * guest/vcpu trying to access same folio as another vcpu
   123		 * or because userspace is trying to access folio for same reason
   124		 *
   125		 * folio_lock serializes the transitions between (in)accessible
   126		 */
   127		if (folio_maybe_dma_pinned(folio))
   128			return -EBUSY;
   129	
   130		if (gmem_flags & GUEST_MEMFD_FLAG_NO_DIRECT_MAP) {
   131			r = guest_memfd_folio_private(folio);
   132			if (r)
   133				return r;
   134		}
   135	
   136		return 0;
   137	}
   138	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  parent reply	other threads:[~2024-08-08  2:45 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-05 18:34 [PATCH RFC 0/4] mm: Introduce guest_memfd library Elliot Berman
2024-08-05 18:34 ` [PATCH RFC 1/4] mm: Introduce guest_memfd Elliot Berman
2024-08-06 13:48   ` David Hildenbrand
2024-08-08 18:39   ` Ackerley Tng
2024-08-05 18:34 ` [PATCH RFC 2/4] kvm: Convert to use mm/guest_memfd Elliot Berman
2024-08-08  4:37   ` kernel test robot
2024-08-05 18:34 ` [PATCH RFC 3/4] mm: guest_memfd: Add option to remove guest private memory from direct map Elliot Berman
2024-08-06 14:08   ` David Hildenbrand
2024-08-08  0:14     ` Manwaring, Derek
2024-08-15 19:08       ` Manwaring, Derek
2024-08-06 15:39   ` Patrick Roy
2024-08-06 20:13     ` Elliot Berman
2024-08-07  6:48       ` Patrick Roy
2024-08-07 10:57         ` Patrick Roy
2024-08-07 19:06           ` Elliot Berman
2024-08-08 13:05             ` Patrick Roy
2024-08-08 22:16               ` Elliot Berman
2024-08-09 15:02                 ` Patrick Roy
2024-08-19 10:09   ` Mike Rapoport
2024-08-20 16:56     ` Elliot Berman
2024-08-21 14:26       ` Mike Rapoport
2024-08-05 18:34 ` [PATCH RFC 4/4] mm: guest_memfd: Add ability for mmap'ing pages Elliot Berman
2024-08-06 13:51   ` David Hildenbrand
2024-08-06 17:14     ` Elliot Berman
2024-08-07 16:12       ` David Hildenbrand
2024-08-08 21:41         ` Elliot Berman
2024-08-08 21:55           ` David Hildenbrand
2024-08-08 22:26             ` Elliot Berman
2024-08-09  7:16               ` David Hildenbrand
2024-08-15  7:24     ` Fuad Tabba
2024-08-16  9:48       ` David Hildenbrand
2024-08-16 11:19         ` Fuad Tabba
2024-08-16 17:45         ` Ackerley Tng
2024-08-16 18:08           ` David Hildenbrand
2024-08-16 21:52             ` Ackerley Tng
2024-08-16 22:03               ` David Hildenbrand
2024-08-16 23:52                 ` Elliot Berman
2024-08-06 15:48   ` Patrick Roy
2024-08-06 20:22     ` Elliot Berman
2024-08-06 21:16   ` Elliot Berman
2024-08-08  2:44   ` kernel test robot [this message]
2024-08-08 18:51   ` Ackerley Tng
2024-08-08 21:42     ` Elliot Berman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202408081018.maLT93SE-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=llvm@lists.linux.dev \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=quic_eberman@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.