From: Oleg Nesterov <oleg@redhat.com>
To: "Liao, Chang" <liaochang1@huawei.com>
Cc: mhiramat@kernel.org, peterz@infradead.org, mingo@redhat.com,
acme@kernel.org, namhyung@kernel.org, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
irogers@google.com, adrian.hunter@intel.com,
kan.liang@linux.intel.com, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org, bpf@vger.kernel.org,
Andrii Nakryiko <andrii@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
paulmck@kernel.org
Subject: Re: [PATCH] uprobes: Improve scalability by reducing the contention on siglock
Date: Thu, 8 Aug 2024 15:17:22 +0200 [thread overview]
Message-ID: <20240808131722.GD8020@redhat.com> (raw)
In-Reply-To: <ef7b6889-7e15-1ff3-c7a5-b3c6dabb13d4@huawei.com>
On 08/08, Liao, Chang wrote:
>
>
> 在 2024/8/8 18:28, Oleg Nesterov 写道:
> > --- x/kernel/events/uprobes.c
> > +++ x/kernel/events/uprobes.c
> > @@ -2308,9 +2308,10 @@ static void handle_singlestep(struct upr
> > utask->state = UTASK_RUNNING;
> > xol_free_insn_slot(current);
> >
> > - spin_lock_irq(¤t->sighand->siglock);
> > - recalc_sigpending(); /* see uprobe_deny_signal() */
> > - spin_unlock_irq(¤t->sighand->siglock);
> > + if (utask->xxx) {
> > + set_thread_flag(TIF_SIGPENDING);
> > + utask->xxx = 0;
> > + }
>
> Agree, if no more discussion about this flag, I will just send v2 today.
Please also resend the previous patch a 1/2, this one as 2/2.
Oleg.
prev parent reply other threads:[~2024-08-08 13:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 8:24 [PATCH] uprobes: Improve scalability by reducing the contention on siglock Liao Chang
2024-08-01 14:06 ` Oleg Nesterov
2024-08-02 1:38 ` Liao, Chang
2024-08-02 9:24 ` Oleg Nesterov
2024-08-06 3:06 ` Liao, Chang
2024-08-06 17:25 ` Oleg Nesterov
2024-08-07 10:17 ` Oleg Nesterov
2024-08-08 7:30 ` Liao, Chang
2024-08-08 10:28 ` Oleg Nesterov
2024-08-08 12:31 ` Liao, Chang
2024-08-08 13:17 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240808131722.GD8020@redhat.com \
--to=oleg@redhat.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=liaochang1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.