All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: "Xinjian Ma (Fujitsu)" <maxj.fnst@fujitsu.com>
Cc: "ltp@lists.linux.it" <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v2] cgroup_fj_common.sh: Do not disable systemd related cgroup subsystems
Date: Fri, 9 Aug 2024 12:31:55 +0200	[thread overview]
Message-ID: <20240809103155.GA352642@pevik> (raw)
In-Reply-To: <TY3PR01MB120713856F5B63EA95B6376C8E8BA2@TY3PR01MB12071.jpnprd01.prod.outlook.com>

> > Hi Ma,

> > > The cpu, io, memory, and pids subsystems under the root cgroup cannot
> > > be disabled because they are used for systemd. Currently, the test of
> > > cpu and memory subsystems in cgroup_fj_function.sh and
> > > cgroup_fj_stress.sh will report the error
> > > "echo: write error: device or resource busy".

> > Could you please share a bit of info on which system it fails. Do you use cgroup
> > v1?

> Hi Petr

> It fails on Fedora 37 which uses cgroupv2.
> cgroupv1 won't trigger this failure.

OK, thx for info, merged!

I managed to reproduce the same issue also on Debian trixie or some Alpine
(which don't use systemd).  I still wonder what could be the root cause, because
many other systemd based systems have no problem (various SLES versions and
openSUSE Tumbleweed).

Kind regards,
Petr

> > Kind regards,
> > Petr

> > > Reviewed-by: Petr Vorel <pvorel@suse.cz>
> > > Signed-off-by: Ma Xinjian <maxj.fnst@fujitsu.com>
> > > ---
> > >  .../kernel/controllers/cgroup_fj/cgroup_fj_common.sh      | 8 +++++++-
> > >  1 file changed, 7 insertions(+), 1 deletion(-)

> > > diff --git
> > > a/testcases/kernel/controllers/cgroup_fj/cgroup_fj_common.sh
> > > b/testcases/kernel/controllers/cgroup_fj/cgroup_fj_common.sh
> > > index e866641ba..153d351d7 100755
> > > --- a/testcases/kernel/controllers/cgroup_fj/cgroup_fj_common.sh
> > > +++ b/testcases/kernel/controllers/cgroup_fj/cgroup_fj_common.sh
> > > @@ -77,7 +77,13 @@ common_cleanup()

> > >      cgroup_cleanup

> > > -    [ "$cgroup_version" = "2" ] && ROD echo "-$subsystem" \>
> > "/sys/fs/cgroup/cgroup.subtree_control"
> > > +    if [ "$cgroup_version" = "2" ]; then
> > > +        case "$subsystem" in
> > > +        cpu|io|memory|pids)
> > > +            :;;
> > > +        *) ROD echo "-$subsystem" \>
> > "/sys/fs/cgroup/cgroup.subtree_control";;
> > > +        esac
> > > +    fi
> > >  }

> > >  . cgroup_lib.sh

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2024-08-09 10:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-09  7:30 [LTP] [PATCH v2] cgroup_fj_common.sh: Do not disable systemd related cgroup subsystems Ma Xinjian via ltp
2024-08-09  8:45 ` Petr Vorel
2024-08-09  8:52   ` Xinjian Ma (Fujitsu) via ltp
2024-08-09 10:31     ` Petr Vorel [this message]
2024-08-21 19:58       ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240809103155.GA352642@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=maxj.fnst@fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.