All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Peter Hutterer <peter.hutterer@who-t.net>,
	Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] HID: hidraw - add HIDIOCREVOKE ioctl
Date: Sat, 10 Aug 2024 11:14:53 +0800	[thread overview]
Message-ID: <202408101044.nmAzxQqQ-lkp@intel.com> (raw)
In-Reply-To: <20240809100342.GA52163@quokka>

Hi Peter,

kernel test robot noticed the following build warnings:

[auto build test WARNING on hid/for-next]
[also build test WARNING on linus/master v6.11-rc2 next-20240809]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Peter-Hutterer/HID-hidraw-add-HIDIOCREVOKE-ioctl/20240809-202833
base:   https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-next
patch link:    https://lore.kernel.org/r/20240809100342.GA52163%40quokka
patch subject: [PATCH v2] HID: hidraw - add HIDIOCREVOKE ioctl
config: x86_64-randconfig-102-20240809 (https://download.01.org/0day-ci/archive/20240810/202408101044.nmAzxQqQ-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240810/202408101044.nmAzxQqQ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408101044.nmAzxQqQ-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/hid/hidraw.c:41:22: warning: no previous prototype for function 'hidraw_is_revoked' [-Wmissing-prototypes]
      41 | __weak noinline bool hidraw_is_revoked(struct hidraw_list *list)
         |                      ^
   drivers/hid/hidraw.c:41:17: note: declare 'static' if the function is not intended to be used outside of this translation unit
      41 | __weak noinline bool hidraw_is_revoked(struct hidraw_list *list)
         |                 ^
         |                 static 
>> drivers/hid/hidraw.c:47:21: warning: no previous prototype for function 'hidraw_open_errno' [-Wmissing-prototypes]
      47 | __weak noinline int hidraw_open_errno(__u32 major, __u32 minor)
         |                     ^
   drivers/hid/hidraw.c:47:17: note: declare 'static' if the function is not intended to be used outside of this translation unit
      47 | __weak noinline int hidraw_open_errno(__u32 major, __u32 minor)
         |                 ^
         |                 static 
   2 warnings generated.


vim +/hidraw_is_revoked +41 drivers/hid/hidraw.c

    40	
  > 41	__weak noinline bool hidraw_is_revoked(struct hidraw_list *list)
    42	{
    43		return list->revoked;
    44	}
    45	ALLOW_ERROR_INJECTION(hidraw_is_revoked, TRUE);
    46	
  > 47	__weak noinline int hidraw_open_errno(__u32 major, __u32 minor)
    48	{
    49		return 0;
    50	}
    51	ALLOW_ERROR_INJECTION(hidraw_open_errno, ERRNO);
    52	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  parent reply	other threads:[~2024-08-10  3:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-09 10:03 [PATCH v2] HID: hidraw - add HIDIOCREVOKE ioctl Peter Hutterer
2024-08-09 16:43 ` kernel test robot
2024-08-10  3:14 ` kernel test robot [this message]
2024-08-12  5:27 ` [PATCH v3] " Peter Hutterer
2024-08-21  0:31   ` Jiri Kosina
2024-08-21  6:59     ` Peter Hutterer
2024-08-21 12:58       ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202408101044.nmAzxQqQ-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=peter.hutterer@who-t.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.