From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD571C3DA7F for ; Mon, 12 Aug 2024 04:11:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jgnrTGYdEtHcHJhHmM94kFhA9Yt8PSWkfVyKOeKpQN8=; b=kwTWVDyh3z2wfD 0zCEDiC6uuWa6EUN5m9F6AVcH+ruIyxD2B/NcTA9H/S/qO0BA4XTD3EU7J+/pO892MHZxaZFnCY72 FycShz2FxILAa67zdXV76mAyhru3b1DiwbwhSIeEQXnr8gMtXVBHDwKzWOl8VWVi9WHPBNwSnmiH6 GSS4lPpk/pur25l2ol0oGint8x1kLRjAyh/bNZ3mNzM6xYuDjc0+s5GWcaG/lptTvM01dZAwwDqom FXJmbJt5WUU39X1mRy8Epuh8DMDXovL6/KTFOHkLk9OU6v1V7979wRj6mIlU5rLYh8hw/nGVqhvj3 yy4Fk8X5eCYqYpkkiWNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdMOf-0000000GpbL-026N; Mon, 12 Aug 2024 04:11:05 +0000 Received: from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdMOa-0000000Gpa1-2skG for linux-rockchip@lists.infradead.org; Mon, 12 Aug 2024 04:11:03 +0000 Received: by mail-pj1-x1033.google.com with SMTP id 98e67ed59e1d1-2cb566d528aso3085334a91.1 for ; Sun, 11 Aug 2024 21:10:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723435859; x=1724040659; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=KLJJ6so+orZFZFeMUnbOliXPJiE9AqEdrrJRM5sonro=; b=RM6OBemKmq1o/wizXGLFK5tVZIOPa7pvy7mt1rsznNjLgi/aZlH+QlyylXXV2ATYUh 09AlsgwGlKX0NHNRwo/YHyhIm9A5DSRyymlcQD2r3wvp1XGhaHFl5GvEvO3LyDQAs1g9 CbqyB/ItYaENQCrKT7P1+zLENRSCeA9Cf7tpd+OIy0zbCOQ0L96+vrJXx0YDl7kbjv+b 0IaCfPR9RbYmtjJ3Mc7OnbwZR773wF60WgmOvP0Av50gzxf4GRaAHltfH3s+wMNjmqQr sxfDbq+vejVo6ZKEbZjlIwgx7VPXY0E8Ue89g7i4KTbpT9KAmcAuEY61fZen+QIT7heX Ntog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723435859; x=1724040659; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KLJJ6so+orZFZFeMUnbOliXPJiE9AqEdrrJRM5sonro=; b=UWfWBwPtmSCOCo/LW9EDgJKwBa/30AcI0Sd6CRca5Z6h5sQeyXbSaK/uuiQvCh0h3F Qazydh9Ad6QurDcVtxK7N4a9CsadiV5YSD7r83BdQUgIqzsAN0cYOPXQqaw7dFQosYBS g08zQohhxNzG3uA4xIBzZBjRXgkoHSUd0K5duhAXbLii1akWHAvQKJHjDY1VbzQWq5Bc YXnWMgaPWprcG3RtBTTIxzEcOG0Pb5xbvlpm/0hXsSVCJGatypnxsCbArwjxx7dNjK9x Qn6JDwL7sUdiydk13CiXph5DcvAtdu/n/8Dgw6gxgdrs8Mj+J9dlpXf1N6har+yOPyEU nLyw== X-Forwarded-Encrypted: i=1; AJvYcCVH3FlQmnK8tQQWJii/8ynvp5+yHD0JGqxbCT0N3l06ea4VdXdHAcYtCBJCDLD1vFSu1wjqa3ScnST65rIN0EAyyfSQEbM7OimHjLnkrvsNfGfv X-Gm-Message-State: AOJu0Yy27nm7jtoKJ4HZYVxdQzFSI6iKx4adbpUJtNGahIFS2FPVi8xl 3NLlSdSyBmj5Wiuy9fr5/e5iYEzh/QJWiqbbLzTeGnXV48vbFuhm/qd/KxffzQ== X-Google-Smtp-Source: AGHT+IEPC81vW4x96+SZLSLCOeIPTkSbgIYh0EjJcUYkF2idbeM+Vokc34tM9BlI6w/m1L1UpjIOOA== X-Received: by 2002:a17:90b:4a81:b0:2c2:f2d6:60d4 with SMTP id 98e67ed59e1d1-2d1e7f96d11mr9474880a91.8.1723435859038; Sun, 11 Aug 2024 21:10:59 -0700 (PDT) Received: from thinkpad ([103.244.168.26]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2d1c9c82b6asm7130528a91.16.2024.08.11.21.10.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Aug 2024 21:10:58 -0700 (PDT) Date: Mon, 12 Aug 2024 09:40:51 +0530 From: Manivannan Sadhasivam To: Shawn Lin Cc: Rob Herring , "James E . J . Bottomley" , "Martin K . Petersen" , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Alim Akhtar , Avri Altman , Bart Van Assche , YiFeng Zhao , Liang Chen , linux-scsi@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 3/3] scsi: ufs: rockchip: init support for UFS Message-ID: <20240812041051.GA2861@thinkpad> References: <1723089163-28983-1-git-send-email-shawn.lin@rock-chips.com> <1723089163-28983-4-git-send-email-shawn.lin@rock-chips.com> <20240809062813.GC2826@thinkpad> <421d48b7-4aa7-4202-8b5f-9c60916f6ef6@rock-chips.com> <20240810092817.GA147655@thinkpad> <3b2617f5-acb1-45c6-993c-33249fd19888@rock-chips.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3b2617f5-acb1-45c6-993c-33249fd19888@rock-chips.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240811_211100_924598_54187CFE X-CRM114-Status: GOOD ( 47.73 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gTW9uLCBBdWcgMTIsIDIwMjQgYXQgMDk6Mjg6MjZBTSArMDgwMCwgU2hhd24gTGluIHdyb3Rl Ogo+IEpIaSBNYW5pLAo+IAo+IOWcqCAyMDI0LzgvMTAgMTc6MjgsIE1hbml2YW5uYW4gU2FkaGFz aXZhbSDlhpnpgZM6Cj4gPiBPbiBGcmksIEF1ZyAwOSwgMjAyNCBhdCAwNDoxNjo0MVBNICswODAw LCBTaGF3biBMaW4gd3JvdGU6Cj4gPiAKPiA+IFsuLi5dCj4gPiAKPiA+ID4gPiA+ICtzdGF0aWMg aW50IHVmc19yb2NrY2hpcF9oY2VfZW5hYmxlX25vdGlmeShzdHJ1Y3QgdWZzX2hiYSAqaGJhLAo+ ID4gPiA+ID4gKwkJCQkJIGVudW0gdWZzX25vdGlmeV9jaGFuZ2Vfc3RhdHVzIHN0YXR1cykKPiA+ ID4gPiA+ICt7Cj4gPiA+ID4gPiArCWludCBlcnIgPSAwOwo+ID4gPiA+ID4gKwo+ID4gPiA+ID4g KwlpZiAoc3RhdHVzID09IFBSRV9DSEFOR0UpIHsKPiA+ID4gPiA+ICsJCWludCByZXRyeV9vdXRl ciA9IDM7Cj4gPiA+ID4gPiArCQlpbnQgcmV0cnlfaW5uZXI7Cj4gPiA+ID4gPiArc3RhcnQ6Cj4g PiA+ID4gPiArCQlpZiAodWZzaGNkX2lzX2hiYV9hY3RpdmUoaGJhKSkKPiA+ID4gPiA+ICsJCQkv KiBjaGFuZ2UgY29udHJvbGxlciBzdGF0ZSB0byAicmVzZXQgc3RhdGUiICovCj4gPiA+ID4gPiAr CQkJdWZzaGNkX2hiYV9zdG9wKGhiYSk7Cj4gPiA+ID4gPiArCj4gPiA+ID4gPiArCQkvKiBVbmlQ cm8gbGluayBpcyBkaXNhYmxlZCBhdCB0aGlzIHBvaW50ICovCj4gPiA+ID4gPiArCQl1ZnNoY2Rf c2V0X2xpbmtfb2ZmKGhiYSk7Cj4gPiA+ID4gPiArCj4gPiA+ID4gPiArCQkvKiBzdGFydCBjb250 cm9sbGVyIGluaXRpYWxpemF0aW9uIHNlcXVlbmNlICovCj4gPiA+ID4gPiArCQl1ZnNoY2Rfd3Jp dGVsKGhiYSwgQ09OVFJPTExFUl9FTkFCTEUsIFJFR19DT05UUk9MTEVSX0VOQUJMRSk7Cj4gPiA+ ID4gPiArCj4gPiA+ID4gPiArCQl1c2xlZXBfcmFuZ2UoMTAwLCAyMDApOwo+ID4gPiA+ID4gKwo+ ID4gPiA+ID4gKwkJLyogd2FpdCBmb3IgdGhlIGhvc3QgY29udHJvbGxlciB0byBjb21wbGV0ZSBp bml0aWFsaXphdGlvbiAqLwo+ID4gPiA+ID4gKwkJcmV0cnlfaW5uZXIgPSA1MDsKPiA+ID4gPiA+ ICsJCXdoaWxlICghdWZzaGNkX2lzX2hiYV9hY3RpdmUoaGJhKSkgewo+ID4gPiA+ID4gKwkJCWlm IChyZXRyeV9pbm5lcikgewo+ID4gPiA+ID4gKwkJCQlyZXRyeV9pbm5lci0tOwo+ID4gPiA+ID4g KwkJCX0gZWxzZSB7Cj4gPiA+ID4gPiArCQkJCWRldl9lcnIoaGJhLT5kZXYsCj4gPiA+ID4gPiAr CQkJCQkiQ29udHJvbGxlciBlbmFibGUgZmFpbGVkXG4iKTsKPiA+ID4gPiA+ICsJCQkJaWYgKHJl dHJ5X291dGVyKSB7Cj4gPiA+ID4gPiArCQkJCQlyZXRyeV9vdXRlci0tOwo+ID4gPiA+ID4gKwkJ CQkJZ290byBzdGFydDsKPiA+ID4gPiA+ICsJCQkJfQo+ID4gPiA+ID4gKwkJCQlyZXR1cm4gLUVJ TzsKPiA+ID4gPiA+ICsJCQl9Cj4gPiA+ID4gPiArCQkJdXNsZWVwX3JhbmdlKDEwMDAsIDExMDAp Owo+ID4gPiA+ID4gKwkJfQo+ID4gPiA+IAo+ID4gPiA+IFlvdSBqdXN0IGR1cGxpY2F0ZWQgdWZz aGNkX2hiYV9leGVjdXRlX2hjZSgpIGhlcmUuIFdoeT8gVGhpcyBkb2Vzbid0IG1ha2Ugc2Vuc2Uu Cj4gPiA+IAo+ID4gPiBTaW5jZSB3ZSBzZXQgVUZTSENJX1FVSVJLX0JST0tFTl9IQ0UsIGFuZCB3 ZSBhbHNvIG5lZWQgdG8gZG8gc29tZXRpbmcKPiA+ID4gd2hpY2ggaXMgdmVyeSBzaW1pbGFyIHRv IHVmc2hjZF9oYmFfZXhlY3V0ZV9oY2UoKSwgYmVmb3JlIGNhbGxpbmcKPiA+ID4gdWZzaGNkX2Rt ZV9yZXNldCgpLiBTaW1pbGFyIGJ1dCBub3QgdG90YWxseSB0aGUgc2FtZS4gSSdsbCB0cnkgdG8g c2VlIGlmCj4gPiA+IHdlIGNhbiBleHBvcnQgdWZzaGNkX2hiYV9leGVjdXRlX2hjZSgpIHRvIG1h a2UgZnVsbCB1c2Ugb2YgaXQuCj4gPiA+IAo+ID4gCj4gPiBCdXQgeW91IGFyZSBzdGFydGluZyB0 aGUgY29udHJvbGxlciB1c2luZyBSRUdfQ09OVFJPTExFUl9FTkFCTEUuIElzbid0IHRoYXQKPiA+ IHN1cHBvc2VkIHRvIGJlIGJyb2tlbiBpZiB5b3Ugc2V0IFVGU0hDSV9RVUlSS19CUk9LRU5fSENF PyBPciBJIGFtCj4gPiBtaXN1bmRlcnN0YW5kaW5nIHRoZSBxdWlyaz8KPiA+IAo+IAo+IE91ciBj b250cm9sbGVyIGRvZXNuJ3Qgd29yayB3aXRoIGV4aXRpbmcgY29kZSwgd2hldGhlciBzZXR0aW5n Cj4gVUZTSENJX1FVSVJLX0JST0tFTl9IQ0Ugb3Igbm90Lgo+IAoKT2theS4gVGhlbiB0aGlzIG1l YW5zIHlvdSBkbyBub3QgbmVlZCB0aGlzIHF1aXJrIGF0IGFsbC4KCj4gCj4gRm9yIFVGU0hDSV9R VUlSS19CUk9LRU5fSENFIGNhc2UsIGl0IGNhbGxzIHVmc2hjZF9kbWVfcmVzZXTvvIjvvIlmaXJz dCwKPiBidXQgd2UgbmVlZCB0byBzZXQgUkVHX0NPTlRST0xMRVJfRU5BQkxFIGZpcnN0Lgo+IAo+ IEZvciAhVUZTSENJX1FVSVJLX0JST0tFTl9IQ0UgY2FzZSwgbmFtbHkgdWZzaGNkX2hiYV9leGVj dXRlX2hjZSwgaXQKPiBzZXRzIFJFR19DT05UUk9MTEVSX0VOQUJMRSAgZmlyc3QgYnV0IG5ldmVy IHNlbmQgRE1BX1JFU0VUIGFuZCBjYWxscwo+IHVmc2hjZF9kbWVfZW5hYmxlLgo+IAoKSSBkb24n dCBzZWUgd2hlcmUgdWZzaGNkX2RtZV9lbmFibGUoKSBpcyBnZXR0aW5nIGNhbGxlZCBmb3IKIVVG U0hDSV9RVUlSS19CUk9LRU5fSENFIGNhc2UuCgo+IFNvIHRoZSBjbG9zZXQgY29kZSBwYXRoIGlz IHRvIGdvIHRocm91Z2ggVUZTSENJX1FVSVJLX0JST0tFTl9IQ0UgY2FzZSwKPiBhbmQgc2V0IFJF R19DT05UUk9MTEVSX0VOQUJMRSBieSBhZGRpbmcgaGNlX2VuYWJsZV9ub3RpZnkgaG9vay4KPiAK Ck5vLCB0aGF0IGlzIGFidXNpbmcgdGhlIHF1aXJrLiBCdXQgSSdtIGNvbmZ1c2VkIGFib3V0IHdo eSB5b3VyIGNvbnRyb2xsZXIgd2FudHMKcmVzZXR0aW5nIHRoZSB1bmlwcm8gc3RhY2sgX2FmdGVy XyBlbmFibGluZyB0aGUgY29udHJvbGxlcj8gV2h5IGNhbid0IGl0IGJlCnJlc2V0IGJlZm9yZT8K Cj4gPiA+ID4gCj4gPiA+ID4gPiArCX0gZWxzZSB7IC8qIFBPU1RfQ0hBTkdFICovCj4gPiA+ID4g PiArCQllcnIgPSB1ZnNoY2Rfdm9wc19waHlfaW5pdGlhbGl6YXRpb24oaGJhKTsKPiA+ID4gPiA+ ICsJfQo+ID4gPiA+ID4gKwo+ID4gPiA+ID4gKwlyZXR1cm4gZXJyOwo+ID4gPiA+ID4gK30KPiA+ ID4gPiA+ICsKClsuLi5dCgo+ID4gPiA+ID4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgZGV2X3BtX29w cyB1ZnNfcm9ja2NoaXBfcG1fb3BzID0gewo+ID4gPiA+ID4gKwlTRVRfU1lTVEVNX1NMRUVQX1BN X09QUyh1ZnNfcm9ja2NoaXBfc3VzcGVuZCwgdWZzX3JvY2tjaGlwX3Jlc3VtZSkKPiA+ID4gPiA+ ICsJU0VUX1JVTlRJTUVfUE1fT1BTKHVmc19yb2NrY2hpcF9ydW50aW1lX3N1c3BlbmQsIHVmc19y b2NrY2hpcF9ydW50aW1lX3Jlc3VtZSwgTlVMTCkKPiA+ID4gPiAKPiA+ID4gPiBXaHkgY2FuJ3Qg eW91IHVzZSB1ZnNoY2QgUE0gb3BzIGFzIGxpa2Ugb3RoZXIgdmVuZG9yIGRyaXZlcnM/Cj4gPiA+ IAo+ID4gPiBJdCBkb2Vzbid0IHdvcmsgZnJvbSB0aGUgdGVzdC4gV2UgaGF2ZSBtYW55IHVzZSBj YXNlIHRvIHBvd2VyIGRvd24gdGhlCj4gPiA+IGNvbnRyb2xsZXIgYW5kIGRldmljZSwgc28gdGhl cmUgaXMgbm8gZmxvdyB0byByZWNvdmVyeSB0aGUgbGluay4gT25seQo+ID4gPiB3aGVuIHRoZSBm aXJzdCBhY2Nlc3NpbmcgdG8gVUZTIGZhaWxzLCB0aGUgdWZzaGNkIGVycm9yIGhhbmRsZSByZWNv dmVyeSB0aGUKPiA+ID4gbGluay4gVGhpcyBpcyBub3Qgd2hhdCB3ZSBleHBlY3QuCj4gPiA+IAo+ ID4gCj4gPiBXaGF0IHRlc3RzPyBUaGUgZXhpc3RpbmcgVUZTIGNvbnRyb2xsZXIgZHJpdmVycyBh cmUgdXNlZCBpbiBwcm9kdWN0aW9uIGRldmljZXMKPiA+IGFuZCB0aGV5IG5ldmVyIGhhZCBhIHVz ZWNhc2UgdG8gaW52ZW50IHRoZWlyIG93biBQTSBjYWxsYmFja3MuIFNvIGlmIHlvdXIKPiA+IGNv bnRyb2xsZXIgaXMgc3BlY2lhbCwgdGhlbiB5b3UgbmVlZCB0byBqdXN0aWZ5IGl0IG1vcmUgZWxh Ym9yYXRlbHkuIElmCj4gPiBzb21ldGhpbmcgaXMgbWlzc2luZyBpbiB1ZnNoY2QgY2FsbGJhY2tz LCB0aGVuIHdlIGNhbiBhZGQgdGhlbS4KPiA+IAo+IAo+IEFsbCB0aGUgcmVnaXN0ZXIgZ290IGxv c3QgZWFjaCB0aW1lIGFzIHdlIHBvd2VyIGRvd24gYm90aCBjb250cm9sbGVyICYgUEhZCj4gYW5k IGRldmljZXMgaW4gc3VzcGVuZC4KCldoaWNoIHN1c3BlbmQ/IHJ1bnRpbWUgb3Igc3lzdGVtIHN1 c3BlbmQ/IEkgYmVsaWV2ZSBzeXN0ZW0gc3VzcGVuZC4KCj4gU28gd2UgaGF2ZSB0byByZXN0b3Jl IHRoZSBuZWNlc3NhcnkKPiByZWdpc3RlcnMgYW5kIGxpbmsuIEkgZGlkbid0IHNlZSB3aGVyZSB0 aGUgY29kZSByZWNvdmVyeSB0aGUgY29udHJvbGxlcgo+IHNldHRpbmdzIGluIHVmc2hjZF9yZXN1 bWUsIGV4Y2VwdCB1ZnNoY2RfZXJyX2hhbmRsZXLvvIjvvIl0cmlnZ2VycyB0aGF0Lgo+IEFtIEkg bWlzc2luZyBhbnkgdGhpbmc/IAoKQ2FuIHlvdSBleHBsYWluIHdoYXQgaXMgY2F1c2luZyB0aGUg cG93ZXJkb3duIG9mIHRoZSBjb250cm9sbGVyIGFuZCBQSFk/CkJlY2F1c2UsIHVmc2hjZF9zdXNw ZW5kKCkganVzdCB0dXJucyBvZmYgdGhlIGNsb2NrcyBhbmQgcmVndWxhdG9ycyAoaWYKVUZTSENE X0NBUF9BR0dSX1BPV0VSX0NPTExBUFNFIGlzIHNldCkgYW5kIHNwbV9sdmwgMyBzZXQgYnkgdGhp cyBkcml2ZXIgb25seQpwdXRzIHRoZSBkZXZpY2UgaW4gc2xlZXAgbW9kZSBhbmQgbGluayBpbiBo aWJlcm44IHN0YXRlLgoKLSBNYW5pCgo+IEJlbG93IGlzIHRoZSBkdW1wIHdlIGdldCBpZiB1c2lu Zwo+IFNFVF9TWVNURU1fU0xFRVBfUE1fT1BTKHVmc2hjZF9zeXN0ZW1fc3VzcGVuZCwgdWZzaGNk X3N5c3RlbV9yZXN1bWUpLgo+IEl0IGNhbiB3b3JrIGFzIHVmc2hjZF9lcnJfaGFuZGxlciAoKSB3 aWxsIGZpeCB0aGUgbGluaywgYnV0IHdlIGhhdmUgdG8KPiBzdWZmZXIgZnJvbSBnZXR0aW5nIHRo ZSBlcnJvciBsb2cgZWFjaCB0aW1lLiBNb3Jlb3Zlciwgd2UgbmVlZCB0byBnYXRlCj4gMjZNSHog cmVmY2xrIGZvciBkZXZpY2Ugd2hlbiBSUE0gaXMgY2FsbGVkLiBTbyBvdXIgb3duIHJwbSBjYWxs YmFjayBpcwo+IG5lZWRlZC4KPiAKPiBbICAgMTQuMzE4NDQ0XSA8PEdUUC1JTkY+PltndDF4X3dh a2V1cF9zbGVlcDo5NjRdIFdha2V1cCBieSBwb3dlcm9uCj4gWyAgIDE0LjQzOTcyM10gdWZzaGNk LXJvY2tjaGlwIDJhMmQwMDAwLnVmczogQ29udHJvbGxlciBub3QgcmVhZHkgdG8gYWNjZXB0Cj4g VUlDIGNvbW1hbmRzCj4gWyAgIDE0LjQzOTczMF0gdWZzaGNkLXJvY2tjaGlwIDJhMmQwMDAwLnVm czogcHdyIGN0cmwgY21kIDB4MTggd2l0aCBtb2RlIDB4MAo+IHVpYyBlcnJvciAtNQo+IFsgICAx NC40Mzk3MzZdIHVmc2hjZC1yb2NrY2hpcCAyYTJkMDAwMC51ZnM6IFVGUyBIb3N0IHN0YXRlPTEK PiBbICAgMTQuNDM5NzQwXSB1ZnNoY2Qtcm9ja2NoaXAgMmEyZDAwMDAudWZzOiBvdXRzdGFuZGlu ZyByZXFzPTB4MCB0YXNrcz0weDAKPiBbICAgMTQuNDM5NzQ0XSB1ZnNoY2Qtcm9ja2NoaXAgMmEy ZDAwMDAudWZzOiBzYXZlZF9lcnI9MHgwLAo+IHNhdmVkX3VpY19lcnI9MHgwCj4gWyAgIDE0LjQz OTc0OF0gdWZzaGNkLXJvY2tjaGlwIDJhMmQwMDAwLnVmczogRGV2aWNlIHBvd2VyIG1vZGU9Miwg VUlDIGxpbmsKPiBzdGF0ZT0yCj4gWyAgIDE0LjQzOTc1M10gdWZzaGNkLXJvY2tjaGlwIDJhMmQw MDAwLnVmczogUE0gaW4gcHJvZ3Jlc3M9MSwgc3lzLgo+IHN1c3BlbmRlZD0xCj4gWyAgIDE0LjQz OTc1OF0gdWZzaGNkLXJvY2tjaGlwIDJhMmQwMDAwLnVmczogQXV0byBCS09QUz0wLCBIb3N0IHNl bGYtYmxvY2s9MAo+IFsgICAxNC40Mzk3NjJdIHVmc2hjZC1yb2NrY2hpcCAyYTJkMDAwMC51ZnM6 IENsayBnYXRlPTEKPiBbICAgMTQuNDM5NzY2XSB1ZnNoY2Qtcm9ja2NoaXAgMmEyZDAwMDAudWZz OiBsYXN0X2hpYmVybjhfZXhpdF90c3RhbXAgYXQgMAo+IHVzLCBoaWJlcm44X2V4aXRfY250PTAK PiBbICAgMTQuNDM5NzcwXSB1ZnNoY2Qtcm9ja2NoaXAgMmEyZDAwMDAudWZzOiBsYXN0IGludHIg YXQgMTA4MDc2MjUgdXMsIGxhc3QKPiBpbnRyIHN0YXR1cz0weDQ0MAo+IFsgICAxNC40Mzk3NzVd IHVmc2hjZC1yb2NrY2hpcCAyYTJkMDAwMC51ZnM6IGVycm9yIGhhbmRsaW5nIGZsYWdzPTB4MCwg cmVxLgo+IGFib3J0IGNvdW50PTAKPiBbICAgMTQuNDM5Nzc5XSB1ZnNoY2Qtcm9ja2NoaXAgMmEy ZDAwMDAudWZzOiBoYmEtPnVmc192ZXJzaW9uPTB4MjAwLCBIb3N0Cj4gY2FwYWJpbGl0aWVzPTB4 MTg3MDExZiwgY2Fwcz0weDQ4Ywo+IFsgICAxNC40Mzk3ODVdIHVmc2hjZC1yb2NrY2hpcCAyYTJk MDAwMC51ZnM6IHF1aXJrcz0weDIxMDAsIGRldi4gcXVpcmtzPTB4YzQKPiBbICAgMTQuNDM5Nzkw XSB1ZnNoY2Qtcm9ja2NoaXAgMmEyZDAwMDAudWZzOiBVRlMgZGV2IGluZm86IFNBTVNVTkcKPiBL TFVERzJSMURFLUIwRjEgIHJldiAwMTAwCj4gWyAgIDE0LjQzOTc5Nl0gdWZzaGNkLXJvY2tjaGlw IDJhMmQwMDAwLnVmczogY2xrOiBjb3JlLCByYXRlOiA1MDAwMDAwMAo+IFsgICAxNC40Mzk4MjJd IGhvc3RfcmVnczogMDAwMDAwMDA6IDAxODcwMTFmIDAwMDAwMDAwIDAwMDAwMjAwIDAwMDAwMDAw Cj4gWyAgIDE0LjQzOTgyN10gaG9zdF9yZWdzOiAwMDAwMDAxMDogMDAwMDAwMDAgMDAwMDA1ZTYg MDAwMDAwMDAgMDAwMDAwMDAKPiBbICAgMTQuNDM5ODMxXSBob3N0X3JlZ3M6IDAwMDAwMDIwOiAw MDAwMDAwMCAwMDAwMDAwMCAwMDAwMDAwMCAwMDAwMDAwMAo+IFsgICAxNC40Mzk4MzVdIGhvc3Rf cmVnczogMDAwMDAwMzA6IDAwMDAwMDAwIDAwMDAwMDAwIDAwMDAwMDAwIDAwMDAwMDAwCj4gWyAg IDE0LjQzOTgzOV0gaG9zdF9yZWdzOiAwMDAwMDA0MDogMDAwMDAwMDAgMDAwMDAwMDAgMDAwMDAw MDAgMDAwMDAwMDAKPiBbICAgMTQuNDM5ODQzXSBob3N0X3JlZ3M6IDAwMDAwMDUwOiAwMDAwMDAw MCAwMDAwMDAwMCAwMDAwMDAwMCAwMDAwMDAwMAo+IFsgICAxNC40Mzk4NDddIGhvc3RfcmVnczog MDAwMDAwNjA6IDAwMDAwMDAwIDAwMDAwMDAwIDAwMDAwMDAwIDAwMDAwMDAwCj4gWyAgIDE0LjQz OTg1MV0gaG9zdF9yZWdzOiAwMDAwMDA3MDogMDAwMDAwMDAgMDAwMDAwMDAgMDAwMDAwMDAgMDAw MDAwMDAKPiBbICAgMTQuNDM5ODU1XSBob3N0X3JlZ3M6IDAwMDAwMDgwOiAwMDAwMDAwMCAwMDAw MDAwMCAwMDAwMDAwMCAwMDAwMDAwMAo+IFsgICAxNC40Mzk4NTldIGhvc3RfcmVnczogMDAwMDAw OTA6IDAwMDAwMDAwIDAwMDAwMDAwIDAwMDAwMDAwIDAwMDAwMDAwCj4gWyAgIDE0LjQzOTg2M10g dWZzaGNkLXJvY2tjaGlwIDJhMmQwMDAwLnVmczogTm8gcmVjb3JkIG9mIHBhX2Vycgo+IFsgICAx NC40Mzk4NjddIHVmc2hjZC1yb2NrY2hpcCAyYTJkMDAwMC51ZnM6IE5vIHJlY29yZCBvZiBkbF9l cnIKPiBbICAgMTQuNDM5ODcxXSB1ZnNoY2Qtcm9ja2NoaXAgMmEyZDAwMDAudWZzOiBObyByZWNv cmQgb2YgbmxfZXJyCj4gWyAgIDE0LjQzOTg3Nl0gdWZzaGNkLXJvY2tjaGlwIDJhMmQwMDAwLnVm czogTm8gcmVjb3JkIG9mIHRsX2Vycgo+IFsgICAxNC40Mzk4ODBdIHVmc2hjZC1yb2NrY2hpcCAy YTJkMDAwMC51ZnM6IE5vIHJlY29yZCBvZiBkbWVfZXJyCj4gWyAgIDE0LjQzOTg4NF0gdWZzaGNk LXJvY2tjaGlwIDJhMmQwMDAwLnVmczogTm8gcmVjb3JkIG9mIGF1dG9faGliZXJuOF9lcnIKPiBb ICAgMTQuNDM5ODg4XSB1ZnNoY2Qtcm9ja2NoaXAgMmEyZDAwMDAudWZzOiBObyByZWNvcmQgb2Yg ZmF0YWxfZXJyCj4gWyAgIDE0LjQzOTg5Ml0gdWZzaGNkLXJvY2tjaGlwIDJhMmQwMDAwLnVmczog Tm8gcmVjb3JkIG9mIGxpbmtfc3RhcnR1cF9mYWlsCj4gWyAgIDE0LjQzOTg5Nl0gdWZzaGNkLXJv Y2tjaGlwIDJhMmQwMDAwLnVmczogTm8gcmVjb3JkIG9mIHJlc3VtZV9mYWlsCj4gWyAgIDE0LjQz OTkwMF0gdWZzaGNkLXJvY2tjaGlwIDJhMmQwMDAwLnVmczogTm8gcmVjb3JkIG9mIHN1c3BlbmRf ZmFpbAo+IFsgICAxNC40Mzk5MDVdIHVmc2hjZC1yb2NrY2hpcCAyYTJkMDAwMC51ZnM6IGRldl9y ZXNldFswXSA9IDB4MCBhdCAxNDE4NzYzCj4gdXMKPiBbICAgMTQuNDM5OTEwXSB1ZnNoY2Qtcm9j a2NoaXAgMmEyZDAwMDAudWZzOiBkZXZfcmVzZXQ6IHRvdGFsIGNudD0xCj4gWyAgIDE0LjQzOTkx NF0gdWZzaGNkLXJvY2tjaGlwIDJhMmQwMDAwLnVmczogTm8gcmVjb3JkIG9mIGhvc3RfcmVzZXQK PiBbICAgMTQuNDM5OTE4XSB1ZnNoY2Qtcm9ja2NoaXAgMmEyZDAwMDAudWZzOiBObyByZWNvcmQg b2YgdGFza19hYm9ydAo+IFsgICAxNC40Mzk5MzBdIHVmc2hjZC1yb2NrY2hpcCAyYTJkMDAwMC51 ZnM6IHVmc2hjZF91aWNfaGliZXJuOF9leGl0Ogo+IGhpYmVybjggZXhpdCBmYWlsZWQuIHJldCA9 IC01Cj4gWyAgIDE0LjQzOTkzNV0gdWZzaGNkLXJvY2tjaGlwIDJhMmQwMDAwLnVmczogX191ZnNo Y2Rfd2xfcmVzdW1lOiBoaWJlcm44Cj4gZXhpdCBmYWlsZWQgLTUKPiBbICAgMTQuNDM5OTQ0XSB1 ZnNfZGV2aWNlX3dsdW4gMDowOjA6NDk0ODg6IHVmc2hjZF93bF9yZXN1bWUgZmFpbGVkOiAtNQo+ IFsgICAxNC40Mzk5NTBdIHVmc19kZXZpY2Vfd2x1biAwOjA6MDo0OTQ4ODogUE06IGRwbV9ydW5f Y2FsbGJhY2soKToKPiBzY3NpX2J1c19yZXN1bWUrMHgwLzB4YTggcmV0dXJucyAtNQo+IFsgICAx NC40NDAwMDNdIHVmc2hjZC1yb2NrY2hpcCAyYTJkMDAwMC51ZnM6IHVmc2hjZF9lcnJfaGFuZGxl ciBzdGFydGVkOyBIQkEKPiBzdGF0ZSBlaF9mYXRhbDsgcG93ZXJlZCAxOyBzaHV0dGluZyBkb3du IDA7IHNhdmVkX2VyciA9IDA7IHNhdmVkX3VpY19lcnIgPQo+IDA7IGZvcmNlX3Jlc2V0ID0gMDsg bGluayBpcyBicm9rZW4KPiBbICAgMTQuNDQwMDE3XSB1ZnNfZGV2aWNlX3dsdW4gMDowOjA6NDk0 ODg6IFBNOiBmYWlsZWQgdG8gcmVzdW1lIGFzeW5jOgo+IGVycm9yIC01Cj4gCj4gPiAtIE1hbmkK PiA+IAoKLS0gCuCuruCuo+Cuv+CuteCuo+CvjeCuo+CuqeCvjSDgrprgrqTgrr7grprgrr/grrXg rq7gr40KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxp bnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQu b3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9j a2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E484D80C for ; Mon, 12 Aug 2024 04:10:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723435861; cv=none; b=kEj/ocdY49lvtYiXG/R9OJlKpdya7vBFnMS1YjUggC+EFW+wMRIGYItMJBxNTD+WWJLxCJVgJOmUGK06sWFnomP65cMIZyHKfKWVBjTZxzpSZokq79e0qinRJCctQ19IWbJPSptAKedERNNmf7Tsblprk2sUoogY4cQjRNF4Vm0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723435861; c=relaxed/simple; bh=qI0bs6rd2DWmdF9ALWTxV+cS9DABMRZx8vBKeOZ3TXY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CxejAsoEPU2Be5TBvGzw92bSJssOUC4Pdqzbivhp2AjKfBqtDcQn6COv5+AJLXLWF3ENxojg2hERMCTAEwKlc+h4P31tiohZjGLfnsDhrlkDAQEaa/qIGrExXsEFSUZ/kPBmI+u2SPh6G0UJsEAs65zht15CBezgYH9E5lE8sro= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=kIYaV8iV; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kIYaV8iV" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-2cd48ad7f0dso3096457a91.0 for ; Sun, 11 Aug 2024 21:10:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723435859; x=1724040659; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=KLJJ6so+orZFZFeMUnbOliXPJiE9AqEdrrJRM5sonro=; b=kIYaV8iVnycVfKVHutt7KSA9HByAdFSNz61yjx17YsTPOtXe9MP9VTgOBE28sudda7 g7ROzEFymlj64A4WKR4ODapcn1NaY/4EEcYOCP5Mb9mncgh0agMFK+j4c8qJ2h+5P+mU e25ho+JnJmhjoWcvtB7aGugGvedifgjUihTHyiCLqpaQbEeictqFBbiywVCwT80vQMvl qg/SwKy4PiphBXMezDQ3nnSSonP7DrCKBNps+LkGmrISGaIMfeTVmvSDVaOQvcDMjK2G Kc8+sOgIGNacm8IAKzTpXkPjTI3y57Qzbxau0KUq5ClT7VzPc9LkKG0ZWJFWKxNKXe6n lD0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723435859; x=1724040659; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KLJJ6so+orZFZFeMUnbOliXPJiE9AqEdrrJRM5sonro=; b=jiVXZN5/m71ApwlzOzH98b1oJjJPdWgQH+ZoUVpw023cLjRNFPsEM2qz/DIkDLPCmy ixE8EapRs4UKgzziW63nbNDMO63CQRg75hn/X0H7zFwOsmWzuTbz6ez9zZxlNpCOZXM4 YCh0W7i9En1Gs5DcTNx6gnwiW4PNmme3OI9Vl9s2No1IFgQN8wqzMPxOLa6dQ1W9UdJL swCLVdWa68RzM6eb99/mgxL1HyAjHnXAWCl7cWsTRK2faOnGMDdG/KyTFY6xFifMk4Mn MV9klf8hXgD19H6fHC6LRa8118zWyU0IWO8JUWqvwSbTtOPqeYqLGzinWRU/k86U37aY pslg== X-Forwarded-Encrypted: i=1; AJvYcCWCElZu6Ja1Fhs+AtwP+oelVFJL8ZH+tNmdQyO0dQCc5bs6ajit2vjfV/Nh0zX6N870FLdCOwKpNzYG3/3jWDz3uwS4y/76QqshgQ== X-Gm-Message-State: AOJu0YwtSb179n72R8IasYxxCXkDr9YzsLD1yGfLoOFZyHWVuVzMSN/3 V3T309mBUbjL6GqY2OnR+k3uRWXcy9wVq/GzgB2o17Mp7lvTNq6q/9vqrpSZEw== X-Google-Smtp-Source: AGHT+IEPC81vW4x96+SZLSLCOeIPTkSbgIYh0EjJcUYkF2idbeM+Vokc34tM9BlI6w/m1L1UpjIOOA== X-Received: by 2002:a17:90b:4a81:b0:2c2:f2d6:60d4 with SMTP id 98e67ed59e1d1-2d1e7f96d11mr9474880a91.8.1723435859038; Sun, 11 Aug 2024 21:10:59 -0700 (PDT) Received: from thinkpad ([103.244.168.26]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2d1c9c82b6asm7130528a91.16.2024.08.11.21.10.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Aug 2024 21:10:58 -0700 (PDT) Date: Mon, 12 Aug 2024 09:40:51 +0530 From: Manivannan Sadhasivam To: Shawn Lin Cc: Rob Herring , "James E . J . Bottomley" , "Martin K . Petersen" , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Alim Akhtar , Avri Altman , Bart Van Assche , YiFeng Zhao , Liang Chen , linux-scsi@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 3/3] scsi: ufs: rockchip: init support for UFS Message-ID: <20240812041051.GA2861@thinkpad> References: <1723089163-28983-1-git-send-email-shawn.lin@rock-chips.com> <1723089163-28983-4-git-send-email-shawn.lin@rock-chips.com> <20240809062813.GC2826@thinkpad> <421d48b7-4aa7-4202-8b5f-9c60916f6ef6@rock-chips.com> <20240810092817.GA147655@thinkpad> <3b2617f5-acb1-45c6-993c-33249fd19888@rock-chips.com> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3b2617f5-acb1-45c6-993c-33249fd19888@rock-chips.com> On Mon, Aug 12, 2024 at 09:28:26AM +0800, Shawn Lin wrote: > JHi Mani, > > 在 2024/8/10 17:28, Manivannan Sadhasivam 写道: > > On Fri, Aug 09, 2024 at 04:16:41PM +0800, Shawn Lin wrote: > > > > [...] > > > > > > > +static int ufs_rockchip_hce_enable_notify(struct ufs_hba *hba, > > > > > + enum ufs_notify_change_status status) > > > > > +{ > > > > > + int err = 0; > > > > > + > > > > > + if (status == PRE_CHANGE) { > > > > > + int retry_outer = 3; > > > > > + int retry_inner; > > > > > +start: > > > > > + if (ufshcd_is_hba_active(hba)) > > > > > + /* change controller state to "reset state" */ > > > > > + ufshcd_hba_stop(hba); > > > > > + > > > > > + /* UniPro link is disabled at this point */ > > > > > + ufshcd_set_link_off(hba); > > > > > + > > > > > + /* start controller initialization sequence */ > > > > > + ufshcd_writel(hba, CONTROLLER_ENABLE, REG_CONTROLLER_ENABLE); > > > > > + > > > > > + usleep_range(100, 200); > > > > > + > > > > > + /* wait for the host controller to complete initialization */ > > > > > + retry_inner = 50; > > > > > + while (!ufshcd_is_hba_active(hba)) { > > > > > + if (retry_inner) { > > > > > + retry_inner--; > > > > > + } else { > > > > > + dev_err(hba->dev, > > > > > + "Controller enable failed\n"); > > > > > + if (retry_outer) { > > > > > + retry_outer--; > > > > > + goto start; > > > > > + } > > > > > + return -EIO; > > > > > + } > > > > > + usleep_range(1000, 1100); > > > > > + } > > > > > > > > You just duplicated ufshcd_hba_execute_hce() here. Why? This doesn't make sense. > > > > > > Since we set UFSHCI_QUIRK_BROKEN_HCE, and we also need to do someting > > > which is very similar to ufshcd_hba_execute_hce(), before calling > > > ufshcd_dme_reset(). Similar but not totally the same. I'll try to see if > > > we can export ufshcd_hba_execute_hce() to make full use of it. > > > > > > > But you are starting the controller using REG_CONTROLLER_ENABLE. Isn't that > > supposed to be broken if you set UFSHCI_QUIRK_BROKEN_HCE? Or I am > > misunderstanding the quirk? > > > > Our controller doesn't work with exiting code, whether setting > UFSHCI_QUIRK_BROKEN_HCE or not. > Okay. Then this means you do not need this quirk at all. > > For UFSHCI_QUIRK_BROKEN_HCE case, it calls ufshcd_dme_reset（）first, > but we need to set REG_CONTROLLER_ENABLE first. > > For !UFSHCI_QUIRK_BROKEN_HCE case, namly ufshcd_hba_execute_hce, it > sets REG_CONTROLLER_ENABLE first but never send DMA_RESET and calls > ufshcd_dme_enable. > I don't see where ufshcd_dme_enable() is getting called for !UFSHCI_QUIRK_BROKEN_HCE case. > So the closet code path is to go through UFSHCI_QUIRK_BROKEN_HCE case, > and set REG_CONTROLLER_ENABLE by adding hce_enable_notify hook. > No, that is abusing the quirk. But I'm confused about why your controller wants resetting the unipro stack _after_ enabling the controller? Why can't it be reset before? > > > > > > > > > + } else { /* POST_CHANGE */ > > > > > + err = ufshcd_vops_phy_initialization(hba); > > > > > + } > > > > > + > > > > > + return err; > > > > > +} > > > > > + [...] > > > > > +static const struct dev_pm_ops ufs_rockchip_pm_ops = { > > > > > + SET_SYSTEM_SLEEP_PM_OPS(ufs_rockchip_suspend, ufs_rockchip_resume) > > > > > + SET_RUNTIME_PM_OPS(ufs_rockchip_runtime_suspend, ufs_rockchip_runtime_resume, NULL) > > > > > > > > Why can't you use ufshcd PM ops as like other vendor drivers? > > > > > > It doesn't work from the test. We have many use case to power down the > > > controller and device, so there is no flow to recovery the link. Only > > > when the first accessing to UFS fails, the ufshcd error handle recovery the > > > link. This is not what we expect. > > > > > > > What tests? The existing UFS controller drivers are used in production devices > > and they never had a usecase to invent their own PM callbacks. So if your > > controller is special, then you need to justify it more elaborately. If > > something is missing in ufshcd callbacks, then we can add them. > > > > All the register got lost each time as we power down both controller & PHY > and devices in suspend. Which suspend? runtime or system suspend? I believe system suspend. > So we have to restore the necessary > registers and link. I didn't see where the code recovery the controller > settings in ufshcd_resume, except ufshcd_err_handler（）triggers that. > Am I missing any thing? Can you explain what is causing the powerdown of the controller and PHY? Because, ufshcd_suspend() just turns off the clocks and regulators (if UFSHCD_CAP_AGGR_POWER_COLLAPSE is set) and spm_lvl 3 set by this driver only puts the device in sleep mode and link in hibern8 state. - Mani > Below is the dump we get if using > SET_SYSTEM_SLEEP_PM_OPS(ufshcd_system_suspend, ufshcd_system_resume). > It can work as ufshcd_err_handler () will fix the link, but we have to > suffer from getting the error log each time. Moreover, we need to gate > 26MHz refclk for device when RPM is called. So our own rpm callback is > needed. > > [ 14.318444] <>[gt1x_wakeup_sleep:964] Wakeup by poweron > [ 14.439723] ufshcd-rockchip 2a2d0000.ufs: Controller not ready to accept > UIC commands > [ 14.439730] ufshcd-rockchip 2a2d0000.ufs: pwr ctrl cmd 0x18 with mode 0x0 > uic error -5 > [ 14.439736] ufshcd-rockchip 2a2d0000.ufs: UFS Host state=1 > [ 14.439740] ufshcd-rockchip 2a2d0000.ufs: outstanding reqs=0x0 tasks=0x0 > [ 14.439744] ufshcd-rockchip 2a2d0000.ufs: saved_err=0x0, > saved_uic_err=0x0 > [ 14.439748] ufshcd-rockchip 2a2d0000.ufs: Device power mode=2, UIC link > state=2 > [ 14.439753] ufshcd-rockchip 2a2d0000.ufs: PM in progress=1, sys. > suspended=1 > [ 14.439758] ufshcd-rockchip 2a2d0000.ufs: Auto BKOPS=0, Host self-block=0 > [ 14.439762] ufshcd-rockchip 2a2d0000.ufs: Clk gate=1 > [ 14.439766] ufshcd-rockchip 2a2d0000.ufs: last_hibern8_exit_tstamp at 0 > us, hibern8_exit_cnt=0 > [ 14.439770] ufshcd-rockchip 2a2d0000.ufs: last intr at 10807625 us, last > intr status=0x440 > [ 14.439775] ufshcd-rockchip 2a2d0000.ufs: error handling flags=0x0, req. > abort count=0 > [ 14.439779] ufshcd-rockchip 2a2d0000.ufs: hba->ufs_version=0x200, Host > capabilities=0x187011f, caps=0x48c > [ 14.439785] ufshcd-rockchip 2a2d0000.ufs: quirks=0x2100, dev. quirks=0xc4 > [ 14.439790] ufshcd-rockchip 2a2d0000.ufs: UFS dev info: SAMSUNG > KLUDG2R1DE-B0F1 rev 0100 > [ 14.439796] ufshcd-rockchip 2a2d0000.ufs: clk: core, rate: 50000000 > [ 14.439822] host_regs: 00000000: 0187011f 00000000 00000200 00000000 > [ 14.439827] host_regs: 00000010: 00000000 000005e6 00000000 00000000 > [ 14.439831] host_regs: 00000020: 00000000 00000000 00000000 00000000 > [ 14.439835] host_regs: 00000030: 00000000 00000000 00000000 00000000 > [ 14.439839] host_regs: 00000040: 00000000 00000000 00000000 00000000 > [ 14.439843] host_regs: 00000050: 00000000 00000000 00000000 00000000 > [ 14.439847] host_regs: 00000060: 00000000 00000000 00000000 00000000 > [ 14.439851] host_regs: 00000070: 00000000 00000000 00000000 00000000 > [ 14.439855] host_regs: 00000080: 00000000 00000000 00000000 00000000 > [ 14.439859] host_regs: 00000090: 00000000 00000000 00000000 00000000 > [ 14.439863] ufshcd-rockchip 2a2d0000.ufs: No record of pa_err > [ 14.439867] ufshcd-rockchip 2a2d0000.ufs: No record of dl_err > [ 14.439871] ufshcd-rockchip 2a2d0000.ufs: No record of nl_err > [ 14.439876] ufshcd-rockchip 2a2d0000.ufs: No record of tl_err > [ 14.439880] ufshcd-rockchip 2a2d0000.ufs: No record of dme_err > [ 14.439884] ufshcd-rockchip 2a2d0000.ufs: No record of auto_hibern8_err > [ 14.439888] ufshcd-rockchip 2a2d0000.ufs: No record of fatal_err > [ 14.439892] ufshcd-rockchip 2a2d0000.ufs: No record of link_startup_fail > [ 14.439896] ufshcd-rockchip 2a2d0000.ufs: No record of resume_fail > [ 14.439900] ufshcd-rockchip 2a2d0000.ufs: No record of suspend_fail > [ 14.439905] ufshcd-rockchip 2a2d0000.ufs: dev_reset[0] = 0x0 at 1418763 > us > [ 14.439910] ufshcd-rockchip 2a2d0000.ufs: dev_reset: total cnt=1 > [ 14.439914] ufshcd-rockchip 2a2d0000.ufs: No record of host_reset > [ 14.439918] ufshcd-rockchip 2a2d0000.ufs: No record of task_abort > [ 14.439930] ufshcd-rockchip 2a2d0000.ufs: ufshcd_uic_hibern8_exit: > hibern8 exit failed. ret = -5 > [ 14.439935] ufshcd-rockchip 2a2d0000.ufs: __ufshcd_wl_resume: hibern8 > exit failed -5 > [ 14.439944] ufs_device_wlun 0:0:0:49488: ufshcd_wl_resume failed: -5 > [ 14.439950] ufs_device_wlun 0:0:0:49488: PM: dpm_run_callback(): > scsi_bus_resume+0x0/0xa8 returns -5 > [ 14.440003] ufshcd-rockchip 2a2d0000.ufs: ufshcd_err_handler started; HBA > state eh_fatal; powered 1; shutting down 0; saved_err = 0; saved_uic_err = > 0; force_reset = 0; link is broken > [ 14.440017] ufs_device_wlun 0:0:0:49488: PM: failed to resume async: > error -5 > > > - Mani > > -- மணிவண்ணன் சதாசிவம்