From: Thomas Zimmermann <tzimmermann@suse.de>
To: alexander.deucher@amd.com, christian.koenig@amd.com,
Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
kherbst@redhat.com, lyude@redhat.com, dakr@redhat.com
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
nouveau@lists.freedesktop.org,
Thomas Zimmermann <tzimmermann@suse.de>,
Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: [PATCH v2 4/9] drm/nouveau: Do not set struct drm_mode_config_funcs.output_poll_changed
Date: Mon, 12 Aug 2024 10:28:25 +0200 [thread overview]
Message-ID: <20240812083000.337744-5-tzimmermann@suse.de> (raw)
In-Reply-To: <20240812083000.337744-1-tzimmermann@suse.de>
The output_poll_changed hook was only necessary before in-kernel
DRM clients existed, but is now obsolete. The client code handles
display hotplugging internally.
v2:
- fix commit description
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/gpu/drm/nouveau/dispnv50/disp.c | 1 -
drivers/gpu/drm/nouveau/nouveau_display.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c
index e4c8ce6dd40a..eed579a6c858 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/disp.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c
@@ -2648,7 +2648,6 @@ nv50_disp_atomic_state_alloc(struct drm_device *dev)
static const struct drm_mode_config_funcs
nv50_disp_func = {
.fb_create = nouveau_user_framebuffer_create,
- .output_poll_changed = drm_fb_helper_output_poll_changed,
.atomic_check = nv50_disp_atomic_check,
.atomic_commit = nv50_disp_atomic_commit,
.atomic_state_alloc = nv50_disp_atomic_state_alloc,
diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/nouveau/nouveau_display.c
index 8a87e9697a42..e2fd561cd23f 100644
--- a/drivers/gpu/drm/nouveau/nouveau_display.c
+++ b/drivers/gpu/drm/nouveau/nouveau_display.c
@@ -391,7 +391,6 @@ nouveau_user_framebuffer_create(struct drm_device *dev,
static const struct drm_mode_config_funcs nouveau_mode_config_funcs = {
.fb_create = nouveau_user_framebuffer_create,
- .output_poll_changed = drm_fb_helper_output_poll_changed,
};
--
2.46.0
next prev parent reply other threads:[~2024-08-12 8:30 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 8:28 [PATCH v2 0/9] drm/{amdgpu,nouveau}: Remove old fbdev hooks Thomas Zimmermann
2024-08-12 8:28 ` [PATCH v2 1/9] drm: Do delayed switcheroo in drm_lastclose() Thomas Zimmermann
2024-08-12 9:23 ` Daniel Vetter
2024-08-12 10:18 ` Daniel Vetter
2024-08-12 10:41 ` Thomas Zimmermann
2024-08-12 14:40 ` Daniel Vetter
2024-08-12 18:47 ` Alex Deucher
2024-08-12 19:05 ` Alex Deucher
2024-08-19 15:33 ` Getting off this list Blake McBride
2024-08-20 20:56 ` Lyude Paul
2024-08-12 8:28 ` [PATCH v2 2/9] drm/amdgpu: Do not set struct drm_driver.lastclose Thomas Zimmermann
2024-08-12 9:24 ` Daniel Vetter
2024-08-12 19:05 ` Alex Deucher
2024-08-12 19:07 ` Alex Deucher
2024-08-12 8:28 ` [PATCH v2 3/9] drm/nouveau: " Thomas Zimmermann
2024-08-12 9:24 ` Daniel Vetter
2024-08-12 12:02 ` Danilo Krummrich
2024-08-12 8:28 ` Thomas Zimmermann [this message]
2024-08-12 12:11 ` [PATCH v2 4/9] drm/nouveau: Do not set struct drm_mode_config_funcs.output_poll_changed Danilo Krummrich
2024-08-12 8:28 ` [PATCH v2 5/9] drm/nouveau: Implement switcheroo reprobe with drm_client_dev_hotplug() Thomas Zimmermann
2024-08-12 12:17 ` Danilo Krummrich
2024-08-12 12:34 ` Thomas Zimmermann
2024-08-12 18:55 ` Danilo Krummrich
2024-08-12 8:28 ` [PATCH v2 6/9] drm/fbdev-helper: Update documentation on obsolete callbacks Thomas Zimmermann
2024-08-12 9:25 ` Daniel Vetter
2024-08-12 8:28 ` [PATCH v2 7/9] drm/fbdev-helper: Remove drm_fb_helper_output_poll_changed() Thomas Zimmermann
2024-08-12 9:25 ` Daniel Vetter
2024-08-12 8:28 ` [PATCH v2 8/9] drm: Remove struct drm_driver.lastclose Thomas Zimmermann
2024-08-12 8:28 ` [PATCH v2 9/9] drm: Remove struct drm_mode_config_funcs.output_poll_changed Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240812083000.337744-5-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dakr@redhat.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kherbst@redhat.com \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.