From: Christian Marangi <ansuelsmth@gmail.com>
To: Tom Rini <trini@konsulko.com>,
Joe Hershberger <joe.hershberger@ni.com>,
Ramon Fried <rfried.dev@gmail.com>,
Dario Binacchi <dario.binacchi@amarulasolutions.com>,
Simon Glass <sjg@chromium.org>,
Christian Marangi <ansuelsmth@gmail.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Arseniy Krasnov <avkrasnov@salutedevices.com>,
Heiko Schocher <hs@denx.de>,
Michael Trimarchi <michael@amarulasolutions.com>,
Martin Kurbanov <mmkurbanov@salutedevices.com>,
Alexey Romanov <avromanov@salutedevices.com>,
Dmitry Dunaev <dunaev@tecon.ru>,
Marek Vasut <marek.vasut+renesas@mailbox.org>,
Sean Anderson <sean.anderson@seco.com>,
Artur Rojek <artur@conclusive.pl>,
Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
Leo Yu-Chi Liang <ycliang@andestech.com>,
Vasileios Amoiridis <vassilisamir@gmail.com>,
Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>,
Michael Polyntsov <michael.polyntsov@iopsys.eu>,
Doug Zobel <douglas.zobel@climate.com>,
u-boot@lists.denx.de
Subject: [PATCH v3 1/9] led: turn LED ON on initial SW blink
Date: Mon, 12 Aug 2024 12:32:43 +0200 [thread overview]
Message-ID: <20240812103254.26972-2-ansuelsmth@gmail.com> (raw)
In-Reply-To: <20240812103254.26972-1-ansuelsmth@gmail.com>
We currently init the LED OFF when SW blink is triggered when
on_state_change() is called. This can be problematic for very short
period as the ON/OFF blink might never trigger.
Turn LED ON on initial SW blink to handle this corner case and better
display a LED blink from the user.
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
drivers/led/led_sw_blink.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/led/led_sw_blink.c b/drivers/led/led_sw_blink.c
index 9e36edbee47..853278670b9 100644
--- a/drivers/led/led_sw_blink.c
+++ b/drivers/led/led_sw_blink.c
@@ -103,8 +103,11 @@ bool led_sw_on_state_change(struct udevice *dev, enum led_state_t state)
return false;
if (state == LEDST_BLINK) {
+ struct led_ops *ops = led_get_ops(dev);
+
+ ops->set_state(dev, LEDST_ON);
/* start blinking on next led_sw_blink() call */
- sw_blink->state = LED_SW_BLINK_ST_OFF;
+ sw_blink->state = LED_SW_BLINK_ST_ON;
return true;
}
--
2.45.2
next prev parent reply other threads:[~2024-08-12 10:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 10:32 [PATCH v3 0/9] led: introduce LED boot and activity function Christian Marangi
2024-08-12 10:32 ` Christian Marangi [this message]
2024-08-12 22:00 ` [PATCH v3 1/9] led: turn LED ON on initial SW blink Heinrich Schuchardt
2024-08-22 10:47 ` Christian Marangi
2024-09-19 17:20 ` Heinrich Schuchardt
2024-09-19 14:13 ` Simon Glass
2024-09-19 16:26 ` Christian Marangi
2024-08-12 10:32 ` [PATCH v3 2/9] led: implement led_set_state/period_by_label Christian Marangi
2024-09-19 14:14 ` Simon Glass
2024-08-12 10:32 ` [PATCH v3 3/9] led: implement LED boot API Christian Marangi
2024-09-19 14:14 ` Simon Glass
2024-08-12 10:32 ` [PATCH v3 4/9] common: board_r: rework BOOT LED handling Christian Marangi
2024-09-19 14:13 ` Simon Glass
2024-08-12 10:32 ` [PATCH v3 5/9] led: implement LED activity API Christian Marangi
2024-09-19 14:13 ` Simon Glass
2024-08-12 10:32 ` [PATCH v3 6/9] tftp: implement support for LED activity Christian Marangi
2024-09-19 14:13 ` Simon Glass
2024-08-12 10:32 ` [PATCH v3 7/9] mtd: " Christian Marangi
2024-08-12 10:32 ` [PATCH v3 8/9] ubi: " Christian Marangi
2024-08-14 4:33 ` Heiko Schocher
2024-08-14 8:17 ` Michael Nazzareno Trimarchi
2024-08-18 16:01 ` Christian Marangi
2024-08-18 19:32 ` Michael Nazzareno Trimarchi
2024-08-22 10:45 ` Christian Marangi
2024-08-18 15:58 ` Christian Marangi
2024-08-12 10:32 ` [PATCH v3 9/9] doc: introduce led.rst documentation Christian Marangi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240812103254.26972-2-ansuelsmth@gmail.com \
--to=ansuelsmth@gmail.com \
--cc=artur@conclusive.pl \
--cc=avkrasnov@salutedevices.com \
--cc=avromanov@salutedevices.com \
--cc=dario.binacchi@amarulasolutions.com \
--cc=douglas.zobel@climate.com \
--cc=dunaev@tecon.ru \
--cc=hs@denx.de \
--cc=joe.hershberger@ni.com \
--cc=marek.vasut+renesas@mailbox.org \
--cc=michael.polyntsov@iopsys.eu \
--cc=michael@amarulasolutions.com \
--cc=mikhail.kshevetskiy@iopsys.eu \
--cc=miquel.raynal@bootlin.com \
--cc=mmkurbanov@salutedevices.com \
--cc=rasmus.villemoes@prevas.dk \
--cc=rfried.dev@gmail.com \
--cc=sean.anderson@seco.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=vassilisamir@gmail.com \
--cc=xypron.glpk@gmx.de \
--cc=ycliang@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.