From: Simon Horman <horms@kernel.org>
To: Moon Yeounsu <yyyynoom@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: dlink: replace deprecated macro
Date: Mon, 12 Aug 2024 11:47:52 +0100 [thread overview]
Message-ID: <20240812104752.GC468359@kernel.org> (raw)
In-Reply-To: <20240810141502.175877-1-yyyynoom@gmail.com>
On Sat, Aug 10, 2024 at 11:15:02PM +0900, Moon Yeounsu wrote:
> Macro `SIMPLE_DEV_PM_OPS()` is deprecated.
> This patch replaces `SIMPLE_DEV_PM_OPS()` with
> `DEFINE_SIMPLE_DEV_PM_OPS()` currently used.
>
> Expanded results are the same since remaining
> member is initialized as zero (NULL):
>
> static SIMPLE_DEV_PM_OPS(rio_pm_ops, rio_suspend, rio_resume);
> Expanded to:
> static const struct dev_pm_ops __attribute__((__unused__)) rio_pm_ops = {
> .suspend = ((1) ? ((rio_suspend)) : ((void *)0)),
> .resume = ((1) ? ((rio_resume)) : ((void *)0)),
> .freeze = ((1) ? ((rio_suspend)) : ((void *)0)),
> .thaw = ((1) ? ((rio_resume)) : ((void *)0)),
> .poweroff = ((1) ? ((rio_suspend)) : ((void *)0)),
> .restore = ((1) ? ((rio_resume)) : ((void *)0)),
> };
>
> static DEFINE_SIMPLE_DEV_PM_OPS(rio_pm_ops, rio_suspend, rio_resume);
> Expanded to:
> static const struct dev_pm_ops rio_pm_ops = {
> .suspend = ((1) ? ((rio_suspend)) : ((void *)0)),
> .resume = ((1) ? ((rio_resume)) : ((void *)0)),
> .freeze = ((1) ? ((rio_suspend)) : ((void *)0)),
> .thaw = ((1) ? ((rio_resume)) : ((void *)0)),
> .poweroff = ((1) ? ((rio_suspend)) : ((void *)0)),
> .restore = ((1) ? ((rio_resume)) : ((void *)0)),
> .runtime_suspend = ((void *)0),
> .runtime_resume = ((void *)0),
> .runtime_idle = ((void *)0),
> };
>
> Signed-off-by: Moon Yeounsu <yyyynoom@gmail.com>
Hi,
I don't think that there is a need to repost because of this. But in
future, please consider explicitly targeting Networking patches at net-next
(or at net for bug fixes).
Subject: [net-next] ...
That notwithstanding, this looks good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-08-12 10:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-10 14:15 [PATCH] net: ethernet: dlink: replace deprecated macro Moon Yeounsu
2024-08-12 10:47 ` Simon Horman [this message]
2024-08-16 0:29 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240812104752.GC468359@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yyyynoom@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.