From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A9C6C3DA7F for ; Mon, 12 Aug 2024 07:10:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=W2OdJvNIPlPvX7UPWaGefyIUcnZkPscMpNvFjbHsJaA=; b=GCSyv6zu+VWsFHBhwcYRWO90xb NiWqNor4Bck6WmjtDuY7iJSIog6DPXB0yRTCg6blvkECKobwEhfFeC8bT/VzOijhwKQ9ttFcbcihf jwTD/sYlU9YF+3ltbm2ig/q0JN9nOYz4kizymqRJH4FBxyBbb+8HIOo/lrptR6QSqiGjNmcydoTos tlIA+oRxyX/cmJOVF5LGYW8VNXqbV/JwcqTW3eGvKKBX6g9p1gsFAQ+03844RJiKijx2axTyApvl2 T+2zOVk57nC6KglAZXjv+SAu+og6fRLJIZm0w4s8iDadtT+zGp9AptFby6z+2S5migAw9DGDepqD8 r9lFniPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdPCd-0000000H7Tb-2C7k; Mon, 12 Aug 2024 07:10:51 +0000 Received: from mgamail.intel.com ([192.198.163.9]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdPC0-0000000H7LX-3dQm; Mon, 12 Aug 2024 07:10:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1723446613; x=1754982613; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=fYltnFmEiOiKgfSB6EHkrcCpM17ixHxAaRtD3gsQQTM=; b=nHgqCWSOcju90lQl+A6qpbVpbEbbsh3IazIm0rrU8ECdAFmtQ/GQ/7gz 1xeK39oaHxjDLil/k4cgDY1pWzPSkgvAoHyTp1xdxvCZC3vQI1TA08m2R WMEE6z+H3qyMGGQ/Ovqc+OEJIsRfBYrKcfujXnWdnD5O3GcWtkMUoDjDo 8PTlduajsM/5vYHBJdNnWxBuET9ocNMLg65RKayb17knkE4YrnpAm4hxW qFIhyUVP/2rgaL0WnjtSUABLRFi5Me/yoBQMmCMzZrvUNzWpAYziyjEta 5yCLUj+iIn0IwVQYPjNzBmzcEPhdHD2+tY+eKwTOOWSW1r3ky4csTtFmA A==; X-CSE-ConnectionGUID: PCa4/PtGTTioEr/MpNVkZw== X-CSE-MsgGUID: ACy28PP2SYacUXl9M4NlyQ== X-IronPort-AV: E=McAfee;i="6700,10204,11161"; a="32215202" X-IronPort-AV: E=Sophos;i="6.09,282,1716274800"; d="scan'208";a="32215202" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Aug 2024 00:10:11 -0700 X-CSE-ConnectionGUID: NhLA91O6T8O6vY/mCcDL3w== X-CSE-MsgGUID: gcvM4RpCRna69SxJqqn3Sg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,282,1716274800"; d="scan'208";a="81406658" Received: from unknown (HELO b6bf6c95bbab) ([10.239.97.151]) by fmviesa002.fm.intel.com with ESMTP; 12 Aug 2024 00:10:07 -0700 Received: from kbuild by b6bf6c95bbab with local (Exim 4.96) (envelope-from ) id 1sdPBt-000BTf-1M; Mon, 12 Aug 2024 07:10:05 +0000 Date: Mon, 12 Aug 2024 15:09:44 +0800 From: kernel test robot To: Elad Yifee Cc: oe-kbuild-all@lists.linux.dev, eladwf@gmail.com, daniel@makrotopia.org, Felix Fietkau , Sean Wang , Mark Lee , Lorenzo Bianconi , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Chen Lin , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net] net: ethernet: mtk_eth_soc: fix memory leak in LRO rings release Message-ID: <202408121439.06IztS3Y-lkp@intel.com> References: <20240811184949.2799-1-eladwf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240811184949.2799-1-eladwf@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240812_001013_011143_7B6AD8CE X-CRM114-Status: GOOD ( 12.09 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Elad, kernel test robot noticed the following build errors: [auto build test ERROR on net/main] url: https://github.com/intel-lab-lkp/linux/commits/Elad-Yifee/net-ethernet-mtk_eth_soc-fix-memory-leak-in-LRO-rings-release/20240812-025108 base: net/main patch link: https://lore.kernel.org/r/20240811184949.2799-1-eladwf%40gmail.com patch subject: [PATCH net] net: ethernet: mtk_eth_soc: fix memory leak in LRO rings release config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20240812/202408121439.06IztS3Y-lkp@intel.com/config) compiler: s390-linux-gcc (GCC) 14.1.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240812/202408121439.06IztS3Y-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202408121439.06IztS3Y-lkp@intel.com/ All errors (new ones prefixed by >>): drivers/net/ethernet/mediatek/mtk_eth_soc.c: In function 'mtk_rx_put_buff': >> drivers/net/ethernet/mediatek/mtk_eth_soc.c:1768:28: error: passing argument 1 of 'free_pages' makes integer from pointer without a cast [-Wint-conversion] 1768 | free_pages(data, get_order(mtk_max_frag_size(ring->frag_size))); | ^~~~ | | | void * In file included from include/linux/xarray.h:16, from include/linux/radix-tree.h:21, from include/linux/idr.h:15, from include/linux/kernfs.h:12, from include/linux/sysfs.h:16, from include/linux/kobject.h:20, from include/linux/of.h:18, from drivers/net/ethernet/mediatek/mtk_eth_soc.c:9: include/linux/gfp.h:372:38: note: expected 'long unsigned int' but argument is of type 'void *' 372 | extern void free_pages(unsigned long addr, unsigned int order); | ~~~~~~~~~~~~~~^~~~ vim +/free_pages +1768 drivers/net/ethernet/mediatek/mtk_eth_soc.c 1759 1760 static void mtk_rx_put_buff(struct mtk_rx_ring *ring, void *data, bool napi) 1761 { 1762 if (ring->page_pool) 1763 page_pool_put_full_page(ring->page_pool, 1764 virt_to_head_page(data), napi); 1765 else if (ring->frag_size <= PAGE_SIZE) 1766 skb_free_frag(data); 1767 else > 1768 free_pages(data, get_order(mtk_max_frag_size(ring->frag_size))); 1769 } 1770 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki