All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>,
	Sunil V L <sunilvl@ventanamicro.com>
Subject: [PATCH v1 1/7] serial: 8250_platform: Remove duplicate mapping
Date: Mon, 12 Aug 2024 18:47:03 +0300	[thread overview]
Message-ID: <20240812154901.1068407-2-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20240812154901.1068407-1-andriy.shevchenko@linux.intel.com>

UPF_IOREMAP is for serial core to map the resource on behalf of the
driver. No need to perform this explicitly in the driver.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/tty/serial/8250/8250_platform.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/tty/serial/8250/8250_platform.c b/drivers/tty/serial/8250/8250_platform.c
index 73002faaae4b..a0e71b03015a 100644
--- a/drivers/tty/serial/8250/8250_platform.c
+++ b/drivers/tty/serial/8250/8250_platform.c
@@ -142,12 +142,6 @@ static int serial8250_platform_probe(struct platform_device *pdev)
 	if (ret)
 		return ret;
 
-	if (uart.port.mapbase) {
-		uart.port.membase = devm_ioremap(dev, uart.port.mapbase, uart.port.mapsize);
-		if (!uart.port.membase)
-			return -ENOMEM;
-	}
-
 	/*
 	 * The previous call may not set iotype correctly when reg-io-width
 	 * property is absent and it doesn't support IO port resource.
-- 
2.43.0.rc1.1336.g36b5255a03ac


  reply	other threads:[~2024-08-12 15:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-12 15:47 [PATCH v1 0/7] serial: 8250_platform: refactor and clean up a bit Andy Shevchenko
2024-08-12 15:47 ` Andy Shevchenko [this message]
2024-08-12 15:47 ` [PATCH v1 2/7] serial: 8250_platform: Don't shadow error from serial8250_register_8250_port() Andy Shevchenko
2024-08-12 15:47 ` [PATCH v1 3/7] serial: 8250_platform: Use same check for ACPI in the whole driver Andy Shevchenko
2024-08-12 15:47 ` [PATCH v1 4/7] serial: 8250_platform: Tidy up ACPI ID table Andy Shevchenko
2024-08-12 15:47 ` [PATCH v1 5/7] serial: 8250_platform: Switch to use platform_get_mem_or_io() Andy Shevchenko
2024-08-12 15:47 ` [PATCH v1 6/7] serial: 8250_platform: Refactor serial8250_probe() Andy Shevchenko
2024-08-12 15:47 ` [PATCH v1 7/7] serial: 8250_platform: Unify comment style Andy Shevchenko
2024-08-14  6:28 ` [PATCH v1 0/7] serial: 8250_platform: refactor and clean up a bit Sunil V L

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240812154901.1068407-2-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=sunilvl@ventanamicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.