From: Jakub Kicinski <kuba@kernel.org>
To: Kuniyuki Iwashima <kuniyu@amazon.com>
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Vineeth Karumanchi <vineeth.karumanchi@amd.com>,
Kuniyuki Iwashima <kuni1840@gmail.com>, <netdev@vger.kernel.org>
Subject: Re: [PATCH v1 net] net: macb: Use rcu_dereference() for idev->ifa_list in macb_suspend().
Date: Mon, 12 Aug 2024 18:40:21 -0700 [thread overview]
Message-ID: <20240812184021.4a7abc18@kernel.org> (raw)
In-Reply-To: <20240808040021.6971-1-kuniyu@amazon.com>
On Wed, 7 Aug 2024 21:00:21 -0700 Kuniyuki Iwashima wrote:
> In macb_suspend(), idev->ifa_list is fetched with rcu_access_pointer()
> and later the pointer is dereferenced as ifa->ifa_local.
>
> So, idev->ifa_list must be fetched with rcu_dereference().
I don't see where this driver takes rcu_read_lock, but
__in_dev_get_rcu() will already splat so we're not making
it any worse.
next prev parent reply other threads:[~2024-08-13 1:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 4:00 [PATCH v1 net] net: macb: Use rcu_dereference() for idev->ifa_list in macb_suspend() Kuniyuki Iwashima
2024-08-08 4:23 ` Vineeth Karumanchi
2024-08-08 4:45 ` Kuniyuki Iwashima
2024-08-12 9:11 ` Vineeth Karumanchi
2024-08-12 18:35 ` Kuniyuki Iwashima
2024-08-13 1:40 ` Jakub Kicinski [this message]
2024-08-13 1:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240812184021.4a7abc18@kernel.org \
--to=kuba@kernel.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuni1840@gmail.com \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
--cc=vineeth.karumanchi@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.