All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Abhinav Jain <jain.abhinav177@gmail.com>
Cc: leah.rumancik@gmail.com, djwong@kernel.org,
	linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org,
	syzbot+55fb1b7d909494fd520d@syzkaller.appspotmail.com
Subject: Re: [PATCH 6.1.y] xfs: remove WARN when dquot cache insertion fails
Date: Mon, 12 Aug 2024 16:40:13 +0200	[thread overview]
Message-ID: <2024081244-emit-starlit-dd23@gregkh> (raw)
In-Reply-To: <20240809015640.590433-1-jain.abhinav177@gmail.com>

On Fri, Aug 09, 2024 at 07:26:40AM +0530, Abhinav Jain wrote:
> commit 4b827b3f305d ("xfs: remove WARN when dquot cache insertion fails")
> 
> Disk quota cache insertion failure doesn't require this warning as
> the system can still manage and track disk quotas without caching the
> dquot object into memory. The failure doesn't imply any data loss or
> corruption.
> 
> Therefore, the WARN_ON in xfs_qm_dqget_cache_insert function is aggressive
> and causes bot noise. I have confirmed there are no conflicts and also
> tested the using the C repro from syzkaller:
> https://syzkaller.appspot.com/text?tag=ReproC&x=15406772280000
> 
> Please do let me know if I missed out on anything as it's my first
> backport patch.

You lost all of the ownership and original signed-off-by attributes for
the commit :(

Please work with the xfs developers if they wish to see this backported
or not, that's up to them.

thanks,

greg k-h

  reply	other threads:[~2024-08-12 14:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-09  1:56 [PATCH 6.1.y] xfs: remove WARN when dquot cache insertion fails Abhinav Jain
2024-08-12 14:40 ` Greg KH [this message]
2024-08-12 19:51   ` Abhinav Jain
2024-08-14 22:55     ` Leah Rumancik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024081244-emit-starlit-dd23@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=djwong@kernel.org \
    --cc=jain.abhinav177@gmail.com \
    --cc=leah.rumancik@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=syzbot+55fb1b7d909494fd520d@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.