From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5E79C52D7B for ; Tue, 13 Aug 2024 08:16:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3229510E00A; Tue, 13 Aug 2024 08:16:49 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.b="OxUsEIZg"; dkim-atps=neutral Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3708D10E00A for ; Tue, 13 Aug 2024 08:16:48 +0000 (UTC) Received: by mail.gandi.net (Postfix) with ESMTPSA id 228ABFF806; Tue, 13 Aug 2024 08:16:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1723537006; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WoFDc4QC+GO77T0FrZWIwuTaCRzddzoUcuaa2caP/EI=; b=OxUsEIZg03mC6cSxQjOuBuYpr5R7079AZFQECISMAxFCOb8RA3mh6Bo4CMxPnNVAtDkJaA jMesPvC5NnXoHE4SME0m3r31YdZf4g5vS1fcFpTNH7Gcp/AsktsSaRMB/Ub8EcvhCKnLWe JCVaB3Spvzu0VVVEb3ZPC6T8eEWDE0AjLNZ0UUt5ydTk69asKDbTBQIbZCmUhK/+UOddLx wUbD+lXYx7OWrkPbd0pAxb52Qj/4Eu6qAC0Hg7A68QKScNCDX5JLiXowI4m60rn2XG1sut clXsVZRwYuvs7SJvBMpsI908B0AFCl4NN9vHiw8PZ5cJ2b13oR0353GUgzQsXQ== Date: Tue, 13 Aug 2024 10:16:43 +0200 From: Luca Ceresoli To: Andi Shyti Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Thomas Petazzoni , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/bridge: ti-sn65dsi83: use dev_err_probe when failing to get panel bridge Message-ID: <20240813101643.5bf8d245@booty> In-Reply-To: References: <20240808-ti-sn65dsi83-dev_err_probe-v1-1-72417aa275ab@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-Sasl: luca.ceresoli@bootlin.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hello Andi, On Thu, 8 Aug 2024 11:35:23 +0100 Andi Shyti wrote: > Hi Luca, > > On Thu, Aug 08, 2024 at 12:26:14PM +0200, Luca Ceresoli wrote: > > When devm_drm_of_get_bridge() fails, the probe fails silently. Use > > dev_err_probe() instead to log an error or report the deferral reason, > > whichever is applicable. > > > > Signed-off-by: Luca Ceresoli > > --- > > drivers/gpu/drm/bridge/ti-sn65dsi83.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c > > index 57a7ed13f996..60b9f14d769a 100644 > > --- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c > > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c > > @@ -606,7 +606,7 @@ static int sn65dsi83_parse_dt(struct sn65dsi83 *ctx, enum sn65dsi83_model model) > > > > panel_bridge = devm_drm_of_get_bridge(dev, dev->of_node, 2, 0); > > if (IS_ERR(panel_bridge)) > > - return PTR_ERR(panel_bridge); > > + return dev_err_probe(dev, PTR_ERR(panel_bridge), "Failed to get panel bridge\n"); > > patch looks good, but the message is a bit misleading. You are > not failing to get the panel bridge, but you are failing to find > a panel bridge in a DT node. Right? As I can see from both the documentation and the code, devm_drm_of_get_bridge() is really returning a pointer to a panel bridge, potentially allocating and adding it in case it was not present before. Navigating the device tree is only a part of what it does. Do you think I am missing something? Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com