All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Zorro Lang <zlang@kernel.org>,
	fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 4/5] generic: don't use _min_dio_alignment without a device argument
Date: Tue, 13 Aug 2024 16:56:25 +0200	[thread overview]
Message-ID: <20240813145625.GC16082@lst.de> (raw)
In-Reply-To: <20240813144331.GF6047@frogsfrogsfrogs>

On Tue, Aug 13, 2024 at 07:43:31AM -0700, Darrick J. Wong wrote:
> > +min_dio_sz=$($here/src/feature -s)
> 
> Or maybe _get_page_size() ?

Sure.  Or maybe actually query the I/O size, but I need feedback
from the authors that they actually intended that..


  reply	other threads:[~2024-08-13 14:56 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-13  7:34 improve minalign handling Christoph Hellwig
2024-08-13  7:35 ` [PATCH 1/5] statx.h: update to latest kernel UAPI Christoph Hellwig
2024-08-13 14:37   ` Darrick J. Wong
2024-08-13 14:54     ` Christoph Hellwig
2024-08-13  7:35 ` [PATCH 2/5] add a new min_dio_alignment helper Christoph Hellwig
2024-08-13 14:40   ` Darrick J. Wong
2024-08-13 14:44     ` Darrick J. Wong
2024-08-13 14:55     ` Christoph Hellwig
2024-08-14  3:43     ` Christoph Hellwig
2024-08-13  7:35 ` [PATCH 3/5] xfs/424: don't use _min_dio_alignment Christoph Hellwig
2024-08-13 14:40   ` Darrick J. Wong
2024-08-13  7:35 ` [PATCH 4/5] generic: don't use _min_dio_alignment without a device argument Christoph Hellwig
2024-08-13 14:43   ` Darrick J. Wong
2024-08-13 14:56     ` Christoph Hellwig [this message]
2024-08-13  7:35 ` [PATCH 5/5] replace _min_dio_alignment with calls to src/min_dio_alignment Christoph Hellwig
2024-08-13 14:45   ` Darrick J. Wong
  -- strict thread matches above, loose matches on Subject: below --
2024-08-14  4:52 improve minalign handling v2 Christoph Hellwig
2024-08-14  4:52 ` [PATCH 4/5] generic: don't use _min_dio_alignment without a device argument Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240813145625.GC16082@lst.de \
    --to=hch@lst.de \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=zlang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.