From: Christoph Hellwig <hch@lst.de>
To: Dave Chinner <david@fromorbit.com>
Cc: Anders Blomdell <anders.blomdell@gmail.com>,
linux-xfs@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Chandan Babu R <chandan.babu@oracle.com>,
"Darrick J. Wong" <djwong@kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: XFS mount timeout in linux-6.9.11
Date: Tue, 13 Aug 2024 16:59:25 +0200 [thread overview]
Message-ID: <20240813145925.GD16082@lst.de> (raw)
In-Reply-To: <ZrslIPV6/qk6cLVy@dread.disaster.area>
On Tue, Aug 13, 2024 at 07:19:28PM +1000, Dave Chinner wrote:
> In hindsight, this was a wholly avoidable bug - a single patch made
> two different API modifications that only differed by a single
> letter, and one of the 23 conversions missed a single letter. If
> that was two patches - one for the finobt conversion, the second for
> the inobt conversion, the bug would have been plainly obvious during
> review....
Maybe we should avoid identifiers that close anyway :)
The change looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2024-08-13 14:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 17:08 XFS mount timeout in linux-6.9.11 Anders Blomdell
2024-08-09 22:55 ` Dave Chinner
2024-08-10 8:29 ` Anders Blomdell
2024-08-10 23:11 ` Dave Chinner
2024-08-11 8:17 ` Anders Blomdell
2024-08-12 0:04 ` Dave Chinner
[not found] ` <6a19bfdf-9503-4c3b-bc5b-192685ec1bdd@gmail.com>
2024-08-13 9:19 ` Dave Chinner
2024-08-13 12:01 ` Anders Blomdell
2024-08-13 14:59 ` Christoph Hellwig [this message]
2024-08-13 15:25 ` Darrick J. Wong
2024-08-22 10:25 ` Anders Blomdell
2024-08-22 15:46 ` Darrick J. Wong
2024-09-04 7:45 ` David Woodhouse
2024-09-08 14:18 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240813145925.GD16082@lst.de \
--to=hch@lst.de \
--cc=anders.blomdell@gmail.com \
--cc=chandan.babu@oracle.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.