All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Gerhard Engleder <gerhard@engleder-embedded.com>
Cc: linux-i2c@vger.kernel.org, andi.shyti@kernel.org, arnd@arndb.de,
	Gerhard Engleder <eg@keba.com>
Subject: Re: [PATCH v3 1/2] misc: keba: Add basic KEBA CP500 system FPGA support
Date: Tue, 13 Aug 2024 11:39:53 +0200	[thread overview]
Message-ID: <2024081316-deafness-flagstick-15e9@gregkh> (raw)
In-Reply-To: <20240710175702.22344-2-gerhard@engleder-embedded.com>

On Wed, Jul 10, 2024 at 07:57:01PM +0200, Gerhard Engleder wrote:
> +	ret = sysfs_create_group(&pci_dev->dev.kobj, &attrs_group);

You just raced with userspace and lost :(

Please use the default groups for your driver instead, that way the
driver core will handle all of the creation/cleanup properly for you
without having to worry you about it.

thanks,

greg k-h

  reply	other threads:[~2024-08-13  9:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-10 17:57 [PATCH v3 0/2] I2C controller support for KEBA PLCs Gerhard Engleder
2024-07-10 17:57 ` [PATCH v3 1/2] misc: keba: Add basic KEBA CP500 system FPGA support Gerhard Engleder
2024-08-13  9:39   ` Greg KH [this message]
2024-08-13 20:00     ` Gerhard Engleder
2024-07-10 17:57 ` [PATCH v3 2/2] i2c: keba: Add KEBA I2C controller support Gerhard Engleder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024081316-deafness-flagstick-15e9@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=andi.shyti@kernel.org \
    --cc=arnd@arndb.de \
    --cc=eg@keba.com \
    --cc=gerhard@engleder-embedded.com \
    --cc=linux-i2c@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.