From: Greg KH <gregkh@linuxfoundation.org>
To: Kevin Hilman <khilman@kernel.org>
Cc: Thomas Richard <thomas.richard@bootlin.com>,
jirislaby@kernel.org, tony@atomide.com,
linux-serial@vger.kernel.org, gregory.clement@bootlin.com,
u-kumar1@ti.com, d-gole@ti.com, thomas.petazzoni@bootlin.com
Subject: Re: [PATCH] serial: 8250_omap: Set the console genpd always on if no console suspend
Date: Tue, 13 Aug 2024 11:00:28 +0200 [thread overview]
Message-ID: <2024081318-litigator-slinky-8f0b@gregkh> (raw)
In-Reply-To: <7hzfplplfs.fsf@baylibre.com>
On Fri, Aug 09, 2024 at 12:04:23PM -0700, Kevin Hilman wrote:
> Thomas Richard <thomas.richard@bootlin.com> writes:
>
> > If the console suspend is disabled, the genpd of the console shall not
> > be powered-off during suspend.
> > Set the flag GENPD_FLAG_ALWAYS_ON to the corresponding genpd during
> > suspend, and restore the original value during the resume.
> >
> > Signed-off-by: Thomas Richard <thomas.richard@bootlin.com>
>
> Hmm, this patch got merged upstream (commit 68e6939ea9ec) even after
> disagreements about the approach.
>
> Even worse, it actually causes a crash during suspend on platforms that
> don't use PM domains (like AM335x Beaglebone Black.)
>
> Details on why this crashes below.
>
> Thomas, could you please submit a revert for this (with a Fixes: tag)
> and then follow up with the approach as discussed later in this thread?
Did this revert happen yet?
thanks,
greg k-h
next prev parent reply other threads:[~2024-08-13 9:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 13:05 [PATCH] serial: 8250_omap: Set the console genpd always on if no console suspend Thomas Richard
2023-10-23 7:44 ` Tony Lindgren
2023-10-24 14:53 ` Thomas Richard
2023-10-24 15:24 ` Greg KH
2023-10-23 21:31 ` Kevin Hilman
2023-10-24 4:51 ` Tony Lindgren
2023-10-24 18:36 ` Kevin Hilman
2023-10-25 6:41 ` Tony Lindgren
2023-10-31 10:15 ` Thomas Richard
2023-10-31 10:52 ` Tony Lindgren
2023-10-31 17:34 ` Kevin Hilman
2023-11-22 14:47 ` Théo Lebrun
2023-11-24 5:37 ` Tony Lindgren
2023-11-24 10:39 ` Théo Lebrun
2023-11-24 10:54 ` Tony Lindgren
2023-11-28 4:05 ` Kevin Hilman
2023-11-28 4:11 ` Tony Lindgren
2023-11-28 4:52 ` Kevin Hilman
2023-11-28 5:05 ` Tony Lindgren
2023-11-27 11:22 ` VAMSHI GAJJELA
2024-08-09 19:04 ` Kevin Hilman
2024-08-13 9:00 ` Greg KH [this message]
2024-08-13 17:18 ` Kevin Hilman
2024-08-20 9:15 ` Thomas Richard
2024-09-16 14:03 ` Thomas Richard
2024-10-04 19:23 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024081318-litigator-slinky-8f0b@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=d-gole@ti.com \
--cc=gregory.clement@bootlin.com \
--cc=jirislaby@kernel.org \
--cc=khilman@kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=thomas.richard@bootlin.com \
--cc=tony@atomide.com \
--cc=u-kumar1@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.