From: Al Viro <viro@zeniv.linux.org.uk>
To: Jeff Layton <jlayton@kernel.org>
Cc: Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Mateusz Guzik <mjguzik@gmail.com>,
Josef Bacik <josef@toxicpanda.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] fs: try an opportunistic lookup for O_CREAT opens too
Date: Wed, 14 Aug 2024 03:40:57 +0100 [thread overview]
Message-ID: <20240814024057.GP13701@ZenIV> (raw)
In-Reply-To: <20240814021817.GO13701@ZenIV>
On Wed, Aug 14, 2024 at 03:18:17AM +0100, Al Viro wrote:
> That's not the only problem; your "is it negative" test is inherently
> racy in RCU mode. IOW, what is positive at the time you get here can
> bloody well go negative immediately afterwards. Hit that with
> O_CREAT and you've got a bogus ENOENT...
Hmm... OTOH, in that case you end up in step_into(), which will do the
right thing...
How well does that series survive NFS client regression tests?
That's where I'd expect potentially subtle shite, what with short-circuited
->d_revalidate() on the final pathwalk step in open()...
next prev parent reply other threads:[~2024-08-14 2:40 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-06 14:32 [PATCH v2] fs: try an opportunistic lookup for O_CREAT opens too Jeff Layton
2024-08-06 15:25 ` Mateusz Guzik
2024-08-06 16:17 ` Jeff Layton
2024-08-06 16:42 ` Mateusz Guzik
2024-08-06 19:11 ` Andi Kleen
2024-08-06 19:22 ` Mateusz Guzik
2024-08-06 20:42 ` Jeff Layton
2024-08-06 19:26 ` Jeff Layton
2024-08-06 20:03 ` Mateusz Guzik
2024-08-06 20:47 ` Andi Kleen
2024-08-15 15:07 ` Mateusz Guzik
2024-08-06 19:51 ` Jeff Layton
2024-08-14 2:18 ` Al Viro
2024-08-14 2:40 ` Al Viro [this message]
2024-08-14 11:48 ` Jeff Layton
2024-08-14 12:40 ` Christian Brauner
2024-08-14 15:44 ` Al Viro
2024-08-16 8:34 ` Christian Brauner
2024-08-14 15:42 ` Al Viro
2024-08-14 16:46 ` Jeff Layton
2024-08-07 14:26 ` Christian Brauner
2024-08-07 14:36 ` Jeff Layton
2024-08-08 10:36 ` Christian Brauner
2024-08-08 10:54 ` Jeff Layton
2024-08-08 11:18 ` Christian Brauner
2024-08-08 17:11 ` Jan Kara
2024-08-08 21:12 ` Paul Moore
2024-08-08 23:43 ` Jeff Layton
2024-08-09 0:28 ` Paul Moore
2024-08-09 0:33 ` Jeff Layton
2024-08-09 1:22 ` Paul Moore
2024-08-09 14:21 ` Jeff Layton
2024-08-11 21:52 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240814024057.GP13701@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjguzik@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.