From: Jakub Kicinski <kuba@kernel.org>
To: Brett Creeley <brett.creeley@amd.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>,
<shannon.nelson@amd.com>
Subject: Re: [PATCH net 1/2] ionic: Fix napi case where budget == 0
Date: Wed, 14 Aug 2024 17:27:48 -0700 [thread overview]
Message-ID: <20240814172748.594a33c8@kernel.org> (raw)
In-Reply-To: <20240813234122.53083-2-brett.creeley@amd.com>
On Tue, 13 Aug 2024 16:41:21 -0700 Brett Creeley wrote:
> The change in the fixes allowed the ionic_tx_cq_service() function
> to be called when budget == 0, but no packet completions will
> actually be serviced since it returns immediately when budget is
> passed in as 0. Fix this by not checking budget before entering
> the completion servicing while loop. This will allow a single
> cq entry to be processed since ++work_done will always be greater
> than work_to_do.
>
> With this change a simple netconsole test as described in
> Documentation/networking/netconsole.txt works as expected.
I think I see a call to XDP cleanup as part of Tx processing.
XDP can't be handled with budget of 0 :(
--
pw-bot: cr
next prev parent reply other threads:[~2024-08-15 0:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-13 23:41 [PATCH net 0/2] ionic: Small fixes Brett Creeley
2024-08-13 23:41 ` [PATCH net 1/2] ionic: Fix napi case where budget == 0 Brett Creeley
2024-08-14 11:33 ` Joe Damato
2024-08-14 18:01 ` Brett Creeley
2024-08-15 0:27 ` Jakub Kicinski [this message]
2024-08-15 0:59 ` Brett Creeley
2024-08-13 23:41 ` [PATCH net 2/2] ionic: Prevent tx_timeout due to frequent doorbell ringing Brett Creeley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240814172748.594a33c8@kernel.org \
--to=kuba@kernel.org \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shannon.nelson@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.