From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
Kyoungrul Kim <k831.kim@samsung.com>
Subject: Re: [PATCH 1/3] ufs: core: Rename LSDB to SDBS to reflect the UFSHCI 4.0 spec
Date: Thu, 15 Aug 2024 09:06:27 +0530 [thread overview]
Message-ID: <20240815033627.GA2562@thinkpad> (raw)
In-Reply-To: <3e7cf9f9-abab-4249-9e7b-71f237850bdf@acm.org>
On Wed, Aug 14, 2024 at 10:27:48AM -0700, Bart Van Assche wrote:
> On 8/14/24 10:15 AM, Manivannan Sadhasivam via B4 Relay wrote:
> > UFSHCI 4.0 spec names the 'Legacy Queue & Single Doorbell Support' field in
> > Controller Capabilities register as 'SDBS'. So let's use the same
> > terminology in the driver to align with the spec.
>
> If a rename happens, we should use the name from the spec. I found the
> following in the UFSHCI 4.0 specification: "Legacy Single DoorBell Support
> (LSDBS)". So please either rename SDBS into LSDBS or drop this
> patch.
>
Hmm. I looked into the editorial version of the 4.0 spec that I got access to
and that used SDBS. Maybe that got changed in the final version. Will change it
to LSDBS.
- Mani
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2024-08-15 3:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 17:15 [PATCH 0/3] ufs: qcom: Fix probe failure on SM8550 SoC due to broken SDBS field Manivannan Sadhasivam
2024-08-14 17:15 ` Manivannan Sadhasivam via B4 Relay
2024-08-14 17:15 ` [PATCH 1/3] ufs: core: Rename LSDB to SDBS to reflect the UFSHCI 4.0 spec Manivannan Sadhasivam
2024-08-14 17:15 ` Manivannan Sadhasivam via B4 Relay
2024-08-14 17:27 ` Bart Van Assche
2024-08-15 3:36 ` Manivannan Sadhasivam [this message]
2024-08-14 17:15 ` [PATCH 2/3] ufs: core: Add a quirk for handling broken SDBS field in controller capabilities register Manivannan Sadhasivam
2024-08-14 17:15 ` Manivannan Sadhasivam via B4 Relay
2024-08-14 17:29 ` Bart Van Assche
2024-08-15 3:46 ` Manivannan Sadhasivam
2024-08-14 17:15 ` [PATCH 3/3] ufs: qcom: Add UFSHCD_QUIRK_BROKEN_SDBS_CAP for SM8550 SoC Manivannan Sadhasivam
2024-08-14 17:15 ` Manivannan Sadhasivam via B4 Relay
2024-08-14 17:22 ` [PATCH 0/3] ufs: qcom: Fix probe failure on SM8550 SoC due to broken SDBS field Amit Pundir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240815033627.GA2562@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=k831.kim@samsung.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.