From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F8E2C3DA7F for ; Thu, 15 Aug 2024 14:29:15 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sebTQ-00027h-Hq; Thu, 15 Aug 2024 10:29:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sebTO-00022K-Sr for qemu-riscv@nongnu.org; Thu, 15 Aug 2024 10:29:06 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sebTM-0005Pd-IL for qemu-riscv@nongnu.org; Thu, 15 Aug 2024 10:29:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723732143; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pLW8VxYvBfkl9d6XaUqzmKjRXnbivJG5S8ggECncIC4=; b=LzZOv0UvkabYpp/pVR1YMajM5YIXHAlyMlJ4DLmh1HIqOup2++8EZa6gUoU7eb7tOM1KPv 1fg07Ag8K5TKJLrSKiYHEInbA+/DzQHuaDwrgt99vIKCQJAsJtQruWBCKeo/cNPDFqQFmP vkdRuaFpcbcZs5gcB5SpCCvSqnMCvFs= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-2-DHEQjR_DPuuVAkBxVtFA_g-1; Thu, 15 Aug 2024 10:29:00 -0400 X-MC-Unique: DHEQjR_DPuuVAkBxVtFA_g-1 Received: by mail-ed1-f71.google.com with SMTP id 4fb4d7f45d1cf-5bec23ba156so310322a12.1 for ; Thu, 15 Aug 2024 07:29:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723732139; x=1724336939; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pLW8VxYvBfkl9d6XaUqzmKjRXnbivJG5S8ggECncIC4=; b=o92WJ1ZbNteFbfh4FBoq5vAUWIPVtPB85jU9Qtihsj3+tgv5Dfp4w/uVwSlHaMqifv qfdTYVg1eOqLLojgYH87ehMtb2nZfQNsCjxyYAxQjQq7CtzfljrnYxasNcKO8aZLb57x zrBG9q/0QgBiqy8mrlwTKmqsY76yTKXnu2IKP6N6uHwlgMtPMzQ5Ao1wL4CB5brX+wz6 ulZ0PSLyPH+CQLkZ9ky0QNYLbrQqwkeCnyr0vkPhTq8ib8VjYGXqKsgUO3npbT4Ctg8R N3R3PP+ZSLo9W7qW3o922r0dJbc3b5XFNZep8NyfqDLwpaqCWlxr9SYCFTLA+Xl1HHwq MR7A== X-Forwarded-Encrypted: i=1; AJvYcCUhN8GDqUM7A723du0RW41tXG7hi3n9m1SzJIxvxV/HAu6b1MKvWqag0rHIi1wa9Fc7vP18ofTmGIZsNQWW0ft6bphID5I= X-Gm-Message-State: AOJu0YwTMhIr9bhAMkcQL6lDiLwNcn3LNVFvKu5XHoC74Yh72nh4HR8D DIFTvZDWgXuGYVxQ1JV9nGVkY7hmBYN1IaEU25fCL71Jcd0Ihk+eGl8rGGBIg5RwBL0ZTVjjGvS G2wezLsGgZ58heFB/kJg/dhqiO80Xbwhqj62wMXlGJLURMFwEoPfM X-Received: by 2002:a05:6402:e83:b0:5be:b6ae:dc68 with SMTP id 4fb4d7f45d1cf-5beb6aee07amr1903220a12.10.1723732139469; Thu, 15 Aug 2024 07:28:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGxUvAIrtGJlhS2+cKFnc3kpN1cB4UpecvdGY8jlQAP3RH/LlQE/BcOYPhfJrk3tkUlBALFgg== X-Received: by 2002:a05:6402:e83:b0:5be:b6ae:dc68 with SMTP id 4fb4d7f45d1cf-5beb6aee07amr1903190a12.10.1723732138674; Thu, 15 Aug 2024 07:28:58 -0700 (PDT) Received: from redhat.com ([2a02:14f:178:8f0f:2cfe:cb96:98c4:3fd0]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5bebc081a24sm938598a12.95.2024.08.15.07.28.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Aug 2024 07:28:58 -0700 (PDT) Date: Thu, 15 Aug 2024 10:28:51 -0400 From: "Michael S. Tsirkin" To: Nicholas Piggin Cc: Alex =?iso-8859-1?Q?Benn=E9e?= , qemu-devel@nongnu.org, Alistair Francis , Michael Roth , Palmer Dabbelt , Mahmoud Mandour , Pavel Dovgalyuk , Yoshinori Sato , Weiwei Li , Eduardo Habkost , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Markus Armbruster , David Hildenbrand , Beraldo Leal , Liu Zhiwei , Eric Auger , Song Gao , qemu-arm@nongnu.org, Peter Xu , Jiri Pirko , Eric Blake , Fabiano Rosas , qemu-s390x@nongnu.org, Peter Maydell , Daniel Henrique Barboza , John Snow , Alexandre Iooss , Konstantin Kostiuk , Pierrick Bouvier , Cleber Rosa , Ilya Leoshkevich , qemu-riscv@nongnu.org, Thomas Huth , Paolo Bonzini , Richard Henderson , Jason Wang , Bin Meng , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Wainer dos Santos Moschetta , Pavel Dovgalyuk Subject: Re: [PATCH v2 16/21] virtio-net: Use replay_schedule_bh_event for bhs that affect machine state Message-ID: <20240815102754-mutt-send-email-mst@kernel.org> References: <20240813202329.1237572-1-alex.bennee@linaro.org> <20240813202329.1237572-17-alex.bennee@linaro.org> <20240813164631-mutt-send-email-mst@kernel.org> <20240814030308-mutt-send-email-mst@kernel.org> <87y14z81ak.fsf@draig.linaro.org> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.131, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org Sender: qemu-riscv-bounces+qemu-riscv=archiver.kernel.org@nongnu.org On Thu, Aug 15, 2024 at 05:12:32PM +1000, Nicholas Piggin wrote: > Could be a good idea. Although I'm not sure what to do with > all types, maybe we can restrict what is supported. > > > Is this wider re-factoring something that can wait for the next > > developer cycle? > > I would say so. It's not quite trivial to do nicely since > things are a bit tangled between util/async and replay. > > > >> I had started on a conversion once but not completed it. > > >> I could resurrect if there is agreement on the API? > > > > I would certainly welcome it being cleaned up. The supported replay > > devices are very piecemeal at the moment. > > I'll tidy up and post an RFC for how the new API might look. > > Thanks, > Nick Fundamentally it's virtio net, up to Jason. I don't like messy APIs and people tend to get distracted and not fix them up if one does not make this a blocker. -- MST