From: Simon Horman <horms@kernel.org>
To: Sean Anderson <sean.anderson@linux.dev>
Cc: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Lunn <andrew@lunn.ch>, Michal Simek <michal.simek@amd.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Paolo Abeni <pabeni@redhat.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
linux-arm-kernel@lists.infradead.org,
Jakub Kicinski <kuba@kernel.org>,
Ariane Keller <ariane.keller@tik.ee.ethz.ch>
Subject: Re: [PATCH net-next 4/4] net: xilinx: axienet: Support IFF_ALLMULTI
Date: Thu, 15 Aug 2024 16:02:18 +0100 [thread overview]
Message-ID: <20240815150218.GJ632411@kernel.org> (raw)
In-Reply-To: <20240812200437.3581990-5-sean.anderson@linux.dev>
On Mon, Aug 12, 2024 at 04:04:37PM -0400, Sean Anderson wrote:
> Add support for IFF_ALLMULTI by configuring a single filter to match the
> multicast address bit. This allows us to keep promiscuous mode disabled,
> even when we have more than four multicast addresses. An even better
> solution would be to "pack" addresses into the available CAM registers,
> but that can wait for a future series.
>
> Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
My comment on patch 1/4 notwithstanding, this looks good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
prev parent reply other threads:[~2024-08-15 15:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 20:04 [PATCH net-next 0/4] net: xilinx: axienet: Multicast fixes and improvements Sean Anderson
2024-08-12 20:04 ` [PATCH net-next 1/4] net: xilinx: axienet: Always disable promiscuous mode Sean Anderson
2024-08-15 14:58 ` Simon Horman
2024-08-15 15:14 ` Sean Anderson
2024-08-15 15:17 ` Simon Horman
2024-08-12 20:04 ` [PATCH net-next 2/4] net: xilinx: axienet: Fix dangling multicast addresses Sean Anderson
2024-08-15 15:01 ` Simon Horman
2024-08-12 20:04 ` [PATCH net-next 3/4] net: xilinx: axienet: Don't print if we go into promiscuous mode Sean Anderson
2024-08-15 14:59 ` Simon Horman
2024-08-15 15:15 ` Sean Anderson
2024-08-12 20:04 ` [PATCH net-next 4/4] net: xilinx: axienet: Support IFF_ALLMULTI Sean Anderson
2024-08-15 15:02 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240815150218.GJ632411@kernel.org \
--to=horms@kernel.org \
--cc=andrew@lunn.ch \
--cc=ariane.keller@tik.ee.ethz.ch \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=sean.anderson@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.