From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77C7FC3DA7F for ; Thu, 15 Aug 2024 15:15:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=V/CwSyWuh1puXG4ZAynbnEHlx184srPqORBjLYiYakU=; b=OS65emU3lBMmmNcgw4dBavwShs 0h4yrqGXOF5ky3O93rSj9OJmFVGgmqaYN+DHLl7AFYy7b7dViLJcVWDXMQytvXnf6pe+oupZNu137 pSCf11zn9GRGJEBgBz0FuNQ/1gEwVGyxgcRK+XogVY2kRz2vql048aEXE4fOrMGj4NeZDQyPH/QEX H1SZe2JHx2fQVgxDyGnQ46KKeri1FNt07o34RI9VlIc4e80taP8s3QRy4dU5jIpbc+nxTVbxMp/sW mgt/omNv5LeDsWPwqnYs49L/dRnkfo6vWuA3aoQma/XiYqceGrJzqIGdIA21xCSjDEPucGarOqoOC zstGC8Tw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1secBw-0000000ALX8-0BTM; Thu, 15 Aug 2024 15:15:08 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1secBC-0000000ALMC-1bsr for linux-arm-kernel@lists.infradead.org; Thu, 15 Aug 2024 15:14:27 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8446561D30; Thu, 15 Aug 2024 15:14:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9874C32786; Thu, 15 Aug 2024 15:14:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723734861; bh=FNgpL4QvKomdKoPpzz2z+UC5rh2pSU5iv9CfujetvtQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qRfbZjeVu1rkoB0XPW8l6ToTZ9pBYgdNx1MISgYY0q0+VtS10tO+OCzkGQN68LZOv z3DS4BvzBgzUmJQOgX7zEy+jh1qoLJFpTWwlFrKUtPg5HWks92B14qk5RkdvdrKDmj +i6y092oGQ9a/ow8j1J67EUBDrDqkyZU59zYy77J17lwT4MBhwVQJzaVDl1ntgA9yo RcJIEEhZrMkRQ00KTA9DJNI8D566HWSPvLxRjEnzoJ7/G1OtC/xZE3XNXWMSY/kiZ8 KWxiIqXIk9X0ugmi6NA0m8CRAGWP2KWoQUzB/35Ggect2I7jyDiWucsrNiznX1CHft KcNK0rRejC7fw== Date: Thu, 15 Aug 2024 16:14:15 +0100 From: Simon Horman To: MD Danish Anwar Cc: Dan Carpenter , Andrew Lunn , Jan Kiszka , Vignesh Raghavendra , Javier Carrasco , Jacob Keller , Diogo Ivo , Richard Cochran , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srk@ti.com, Roger Quadros Subject: Re: [PATCH net-next v2 4/7] net: ti: icssg-prueth: Add support for HSR frame forward offload Message-ID: <20240815151415.GK632411@kernel.org> References: <20240813074233.2473876-1-danishanwar@ti.com> <20240813074233.2473876-5-danishanwar@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240813074233.2473876-5-danishanwar@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240815_081422_492278_2FC98BB4 X-CRM114-Status: GOOD ( 13.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 13, 2024 at 01:12:30PM +0530, MD Danish Anwar wrote: ... > diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.h b/drivers/net/ethernet/ti/icssg/icssg_prueth.h > index f678d656a3ed..40bc3912b6ae 100644 > --- a/drivers/net/ethernet/ti/icssg/icssg_prueth.h > +++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.h > @@ -239,6 +239,7 @@ struct icssg_firmwares { > * @iep1: pointer to IEP1 device > * @vlan_tbl: VLAN-FID table pointer > * @hw_bridge_dev: pointer to HW bridge net device > + * @hsr_dev: pointer to the HSR net device > * @br_members: bitmask of bridge member ports > * @prueth_netdevice_nb: netdevice notifier block > * @prueth_switchdev_nb: switchdev notifier block I think you also need to add Kernel doc entries for @hsr_members and @is_hsr_offload_mode. Flagged by W=1 builds and ./scripts/kernel-doc -none > @@ -274,11 +275,14 @@ struct prueth { > struct prueth_vlan_tbl *vlan_tbl; > > struct net_device *hw_bridge_dev; > + struct net_device *hsr_dev; > u8 br_members; > + u8 hsr_members; > struct notifier_block prueth_netdevice_nb; > struct notifier_block prueth_switchdev_nb; > struct notifier_block prueth_switchdev_bl_nb; > bool is_switch_mode; > + bool is_hsr_offload_mode; > bool is_switchmode_supported; > unsigned char switch_id[MAX_PHYS_ITEM_ID_LEN]; > int default_vlan; > -- > 2.34.1 >