Re: [RFC dlm/next 08/12] kobject: add kset_type_create_and_add() helper

[kernel test robot <lkp@intel.com>]

Hi Alexander,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on teigland-dlm/next]
[also build test WARNING on driver-core/driver-core-testing driver-core/driver-core-next driver-core/driver-core-linus linus/master v6.11-rc3 next-20240815]
[cannot apply to gfs2/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Alexander-Aring/dlm-introduce-dlm_find_lockspace_name/20240814-233736
base:   https://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm.git next
patch link:    https://lore.kernel.org/r/20240814143414.1877505-9-aahringo%40redhat.com
patch subject: [RFC dlm/next 08/12] kobject: add kset_type_create_and_add() helper
config: openrisc-allnoconfig (https://download.01.org/0day-ci/archive/20240815/202408152013.QUsFNfUM-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240815/202408152013.QUsFNfUM-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408152013.QUsFNfUM-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> lib/kobject.c:962: warning: Function parameter or struct member 'ktype' not described in 'kset_create'


vim +962 lib/kobject.c

b727c702896f88 Greg Kroah-Hartman 2007-09-27  942  
b727c702896f88 Greg Kroah-Hartman 2007-09-27  943  /**
ed856349dc0886 Tobin C. Harding   2019-05-02  944   * kset_create() - Create a struct kset dynamically.
b727c702896f88 Greg Kroah-Hartman 2007-09-27  945   *
b727c702896f88 Greg Kroah-Hartman 2007-09-27  946   * @name: the name for the kset
b727c702896f88 Greg Kroah-Hartman 2007-09-27  947   * @uevent_ops: a struct kset_uevent_ops for the kset
b727c702896f88 Greg Kroah-Hartman 2007-09-27  948   * @parent_kobj: the parent kobject of this kset, if any.
b727c702896f88 Greg Kroah-Hartman 2007-09-27  949   *
b727c702896f88 Greg Kroah-Hartman 2007-09-27  950   * This function creates a kset structure dynamically.  This structure can
b727c702896f88 Greg Kroah-Hartman 2007-09-27  951   * then be registered with the system and show up in sysfs with a call to
b727c702896f88 Greg Kroah-Hartman 2007-09-27  952   * kset_register().  When you are finished with this structure, if
b727c702896f88 Greg Kroah-Hartman 2007-09-27  953   * kset_register() has been called, call kset_unregister() and the
b727c702896f88 Greg Kroah-Hartman 2007-09-27  954   * structure will be dynamically freed when it is no longer being used.
b727c702896f88 Greg Kroah-Hartman 2007-09-27  955   *
b727c702896f88 Greg Kroah-Hartman 2007-09-27  956   * If the kset was not able to be created, NULL will be returned.
b727c702896f88 Greg Kroah-Hartman 2007-09-27  957   */
b727c702896f88 Greg Kroah-Hartman 2007-09-27  958  static struct kset *kset_create(const char *name,
9cd43611ccfb46 Emese Revfy        2009-12-31  959  				const struct kset_uevent_ops *uevent_ops,
9b20142ac9c1ca Alexander Aring    2024-08-14  960  				struct kobject *parent_kobj,
9b20142ac9c1ca Alexander Aring    2024-08-14  961  				const struct kobj_type *ktype)
b727c702896f88 Greg Kroah-Hartman 2007-09-27 @962  {
b727c702896f88 Greg Kroah-Hartman 2007-09-27  963  	struct kset *kset;
d9cd8f37855b01 Dave Young         2009-05-11  964  	int retval;
b727c702896f88 Greg Kroah-Hartman 2007-09-27  965  
b727c702896f88 Greg Kroah-Hartman 2007-09-27  966  	kset = kzalloc(sizeof(*kset), GFP_KERNEL);
b727c702896f88 Greg Kroah-Hartman 2007-09-27  967  	if (!kset)
b727c702896f88 Greg Kroah-Hartman 2007-09-27  968  		return NULL;
b7165ebbf0898b Kees Cook          2013-06-06  969  	retval = kobject_set_name(&kset->kobj, "%s", name);
d9cd8f37855b01 Dave Young         2009-05-11  970  	if (retval) {
d9cd8f37855b01 Dave Young         2009-05-11  971  		kfree(kset);
d9cd8f37855b01 Dave Young         2009-05-11  972  		return NULL;
d9cd8f37855b01 Dave Young         2009-05-11  973  	}
b727c702896f88 Greg Kroah-Hartman 2007-09-27  974  	kset->uevent_ops = uevent_ops;
b727c702896f88 Greg Kroah-Hartman 2007-09-27  975  	kset->kobj.parent = parent_kobj;
b727c702896f88 Greg Kroah-Hartman 2007-09-27  976  
9b20142ac9c1ca Alexander Aring    2024-08-14  977  	kset->kobj.ktype = ktype;
b727c702896f88 Greg Kroah-Hartman 2007-09-27  978  	kset->kobj.kset = NULL;
b727c702896f88 Greg Kroah-Hartman 2007-09-27  979  
b727c702896f88 Greg Kroah-Hartman 2007-09-27  980  	return kset;
b727c702896f88 Greg Kroah-Hartman 2007-09-27  981  }
b727c702896f88 Greg Kroah-Hartman 2007-09-27  982  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki