From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BE2C153BED for ; Thu, 15 Aug 2024 21:59:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723759193; cv=none; b=ScaqbWHAVTq56dJ5l+29gI8SaEjKY7t2vYfA8zxIv2xYseIWTD7VUrfQwFl7oRLHlpEnKhxNMDFkAOeDJvaIe333ftbtgx9D7/nYPrGCyRyQuai/hu2W70ir/Z+6cAgMHUwDCJIL2DIZjxYOr7ccsP/9g71zRIslp4SA5IgdkP0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723759193; c=relaxed/simple; bh=p1ulB57bH0r/zqoz+bx6/PWen9lEfhkW2yd6LA+SQHw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=tmAuaO8RSVFt1DkNqcWSH+RQ0VQaCcJmy01mHBWe8Mz3VoPyrTVkbqi8z3PdcCdA7gOIedBYGFXzFaBsWWX0DlfUnq2up53kd0kAyLcZMUpKtV4G8yLWqcaJSR0sRRCcq0kfK7KxWAwP7rk76xEyj2DyZ7DIV+ZNBaCOY+gmPQI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=bF7mtZHG; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bF7mtZHG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723759190; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kUdof9eHCqOd0n2V6yYBqUcIX0HjK+ScGX0aMXA6SsI=; b=bF7mtZHGJ2fZGC5qloLykrj/3lUvGuuBsQfgGqkf2khvvFwRPFZdxrQd7wSDMgeFkdH4hD 72TbTL83VcEjrDSoIcAc4nRA/VW0W8bRgAWmUJo2MMlwHsn19mFuoSDKzypWMEXyTePhkn /qFGrC/ykwlcDEaJ7QLo0xeTHdKgiuk= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-231-WjmNCNFkMBumZ0O84PXY6w-1; Thu, 15 Aug 2024 17:59:46 -0400 X-MC-Unique: WjmNCNFkMBumZ0O84PXY6w-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6302719560B4; Thu, 15 Aug 2024 21:59:43 +0000 (UTC) Received: from aion.redhat.com (unknown [10.22.64.17]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3053919560AA; Thu, 15 Aug 2024 21:59:42 +0000 (UTC) Received: from aion.redhat.com (localhost [IPv6:::1]) by aion.redhat.com (Postfix) with ESMTP id 688221D8785; Thu, 15 Aug 2024 17:59:41 -0400 (EDT) From: Scott Mayhew To: kdevops@lists.linux.dev Cc: chuck.lever@oracle.com Subject: [PATCH] gitr: Make gitr work on RHEL/CentOS Date: Thu, 15 Aug 2024 17:59:41 -0400 Message-ID: <20240815215941.602080-1-smayhew@redhat.com> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true RHEL and CentOS do not ship cvsps or perl-TAP-Harness-Archive. For the former, we'll have to build it from git. For the latter, we can install it from CPAN, but we'll also have to install the perl-App-cpanminus package to do so. Also add two other dependencies. First is 'make', which is currently only installed if you have KDEVOPS_TRY_INSTALL_KDEV_TOOLS enabled in your config. Second is 'tar' which is not installed in the RHEL virt-builder images by default ('tar' isn't part of the @core dnf package group). Signed-off-by: Scott Mayhew --- playbooks/roles/gitr/defaults/main.yml | 3 ++ playbooks/roles/gitr/tasks/main.yml | 67 ++++++++++++++++++++++++++ playbooks/roles/gitr/vars/RedHat.yml | 7 ++- 3 files changed, 75 insertions(+), 2 deletions(-) diff --git a/playbooks/roles/gitr/defaults/main.yml b/playbooks/roles/gitr/defaults/main.yml index bcfbaef..ff737ca 100644 --- a/playbooks/roles/gitr/defaults/main.yml +++ b/playbooks/roles/gitr/defaults/main.yml @@ -18,3 +18,6 @@ gitr_thread_single: false gitr_thread_fast: false gitr_thread_stress: false gitr_thread_custom: false + +cvsps_git: https://github.com/andreyvit/cvsps.git +cvsps_data: "{{ data_path }}/cvsps" diff --git a/playbooks/roles/gitr/tasks/main.yml b/playbooks/roles/gitr/tasks/main.yml index 330350c..001257a 100644 --- a/playbooks/roles/gitr/tasks/main.yml +++ b/playbooks/roles/gitr/tasks/main.yml @@ -11,6 +11,11 @@ failed_when: false tags: vars +- name: Set up the /data mount point + tags: ['data_partition'] + ansible.builtin.include_role: + name: create_data_partition + - name: Set the name of the test group tags: vars ansible.builtin.set_fact: @@ -42,6 +47,21 @@ paths: - 'vars' +- name: Update gitr depencies for RHEL/Centos + tags: gitr + ansible.builtin.set_fact: + gitr_packages: "{{ gitr_packages + ['perl-App-cpanminus'] }}" + when: + - ansible_distribution == "RedHat" or + ansible_distribution == "CentOS" + +- name: Update gitr dependencies for Fedora + tags: gitr + ansible.builtin.set_fact: + gitr_packages: "{{ gitr_packages + ['cvsps', 'perl-TAP-Harness-Archive'] }}" + when: + - ansible_distribution == "Fedora" + - name: Install dependencies for gitr tags: gitr become: true @@ -51,6 +71,53 @@ name: "{{ gitr_packages }}" state: present +- name: Install CPAN modules for gitr + tags: gitr + become: true + become_flags: 'su - -c' + become_method: ansible.builtin.sudo + community.general.cpanm: + name: "{{ item }}" + with_items: "{{ gitr_cpan_modules }}" + when: + - ansible_distribution == "RedHat" or + ansible_distribution == "CentOS" + +- name: git clone cvsps + tags: gitr + ansible.builtin.git: + repo: "{{ cvsps_git }}" + dest: "{{ cvsps_data }}" + update: true + retries: 3 + delay: 5 + register: result + until: not result.failed + when: + - ansible_distribution == "RedHat" or + ansible_distribution == "CentOS" + +- name: Build cvsps + tags: gitr + community.general.make: + chdir: "{{ cvsps_data }}" + jobs: "{{ ansible_processor_nproc }}" + when: + - ansible_distribution == "RedHat" or + ansible_distribution == "CentOS" + +- name: Install cvsps + tags: gitr + become: true + become_flags: 'su - -c' + become_method: ansible.builtin.sudo + community.general.make: + target: install + chdir: "{{ cvsps_data }}" + when: + - ansible_distribution == "RedHat" or + ansible_distribution == "CentOS" + - name: Set up an iSCSI initiator on the target node ansible.builtin.include_role: name: iscsi diff --git a/playbooks/roles/gitr/vars/RedHat.yml b/playbooks/roles/gitr/vars/RedHat.yml index 57f2f35..caf9840 100644 --- a/playbooks/roles/gitr/vars/RedHat.yml +++ b/playbooks/roles/gitr/vars/RedHat.yml @@ -1,7 +1,6 @@ --- gitr_packages: - cvs - - cvsps - expat-devel - gcc - gettext @@ -9,11 +8,15 @@ gitr_packages: - git-email - glibc-utils - libcurl-devel + - make - openssl-devel - perl-Memoize - - perl-TAP-Harness-Archive - perl-Test-Harness - perl-Test-Simple - subversion - subversion-perl + - tar - zlib-devel + +gitr_cpan_modules: + - TAP::Harness::Archive -- 2.44.0