From: "Michael S. Tsirkin" <mst@redhat.com>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: qemu-devel@nongnu.org,
"Pavel Dovgalyuk" <Pavel.Dovgalyuk@ispras.ru>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"John Snow" <jsnow@redhat.com>, "Cleber Rosa" <crosa@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Beraldo Leal" <bleal@redhat.com>,
"Michael Tokarev" <mjt@tls.msk.ru>
Subject: Re: [RFC PATCH 0/2] async: rework async event API for replay
Date: Fri, 16 Aug 2024 03:34:55 -0400 [thread overview]
Message-ID: <20240816033046-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <D3GZ90ORAGBC.EPV2C5TYYGKG@gmail.com>
On Fri, Aug 16, 2024 at 12:23:50PM +1000, Nicholas Piggin wrote:
> On Fri Aug 16, 2024 at 1:30 AM AEST, Michael S. Tsirkin wrote:
> > On Thu, Aug 15, 2024 at 11:28:35PM +1000, Nicholas Piggin wrote:
> > > Continuing the conversation from the thread about record/replay
> > > virtio fix. Here is a sketch of how we could improve the naming
> > > convention so users of bh don't have to know about record/replay.
> > >
> > > Thanks,
> > > Nick
> >
> > The API looks ok to me.
>
> Thanks for taking a look. In that case let's go with the fixes for
> now so we have rr regression tests in a bit better state, and I will
> resend for 9.2.
>
> Thanks,
> Nick
No, this is big because you are structuring this wrong.
Work, then rework ... I do not really like this kind of thing.
Add sane APIs and use them keeping old ones around, reworking old code
can wait for 9.2.
--
MST
prev parent reply other threads:[~2024-08-16 7:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-15 13:28 [RFC PATCH 0/2] async: rework async event API for replay Nicholas Piggin
2024-08-15 13:28 ` [RFC PATCH 1/2] " Nicholas Piggin
2024-08-15 13:28 ` [RFC PATCH 2/2] async: add debugging assertions for record/replay in bh APIs Nicholas Piggin
2024-08-15 15:30 ` [RFC PATCH 0/2] async: rework async event API for replay Michael S. Tsirkin
2024-08-16 2:23 ` Nicholas Piggin
2024-08-16 7:34 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240816033046-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=Pavel.Dovgalyuk@ispras.ru \
--cc=alex.bennee@linaro.org \
--cc=bleal@redhat.com \
--cc=crosa@redhat.com \
--cc=jsnow@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=npiggin@gmail.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.