From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
Kyoungrul Kim <k831.kim@samsung.com>,
Amit Pundir <amit.pundir@linaro.org>
Subject: Re: [PATCH v2 2/3] ufs: core: Add a quirk for handling broken LSDBS field in controller capabilities register
Date: Fri, 16 Aug 2024 11:05:28 +0530 [thread overview]
Message-ID: <20240816053528.GE2331@thinkpad> (raw)
In-Reply-To: <869108d2-638a-473f-81bd-21304d473fab@acm.org>
On Thu, Aug 15, 2024 at 11:12:57AM -0700, Bart Van Assche wrote:
> On 8/14/24 10:16 PM, Manivannan Sadhasivam via B4 Relay wrote:
> > + /*
> > + * This quirk needs to be enabled if the host controller has the broken
> > + * Legacy Queue & Single Doorbell Support (LSDBS) field in Controller
> > + * Capabilities register.
> > + */
> > + UFSHCD_QUIRK_BROKEN_LSDBS_CAP = 1 << 25,
>
> The above comment is misleading because it suggests that the definition
> of this bit in the UFSHCI specification is broken, which is not the
> case.
Really? I don't see where the comment implies that the bit in the specification
is broken. It clearly says that the 'host controller has the broken bit'.
>How about this comment?
>
> /*
> * This quirk indicates that the controller reports the value 1
> * (not supported) in the Legacy Single DoorBell Support (LSDBS)
> * bit although it supports the legacy single doorbell mode.
But this comment is more elaborative. So I'll use it, thanks!
- Mani
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2024-08-16 5:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-15 5:16 [PATCH v2 0/3] ufs: qcom: Fix probe failure on SM8550 SoC due to broken LSDBS field Manivannan Sadhasivam
2024-08-15 5:16 ` Manivannan Sadhasivam via B4 Relay
2024-08-15 5:16 ` [PATCH v2 1/3] ufs: core: Rename LSDB to LSDBS to reflect the UFSHCI 4.0 spec Manivannan Sadhasivam
2024-08-15 5:16 ` Manivannan Sadhasivam via B4 Relay
2024-08-15 18:09 ` Bart Van Assche
2024-08-16 5:03 ` Manivannan Sadhasivam
2024-08-15 5:16 ` [PATCH v2 2/3] ufs: core: Add a quirk for handling broken LSDBS field in controller capabilities register Manivannan Sadhasivam
2024-08-15 5:16 ` Manivannan Sadhasivam via B4 Relay
2024-08-15 18:12 ` Bart Van Assche
2024-08-16 5:35 ` Manivannan Sadhasivam [this message]
2024-08-15 18:25 ` Bart Van Assche
2024-08-16 5:24 ` Manivannan Sadhasivam
2024-08-15 5:16 ` [PATCH v2 3/3] ufs: qcom: Add UFSHCD_QUIRK_BROKEN_LSDBS_CAP for SM8550 SoC Manivannan Sadhasivam
2024-08-15 5:16 ` Manivannan Sadhasivam via B4 Relay
2024-08-15 18:01 ` Bart Van Assche
2024-08-16 5:28 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240816053528.GE2331@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=amit.pundir@linaro.org \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=k831.kim@samsung.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.