From: Jakub Kicinski <kuba@kernel.org>
To: Joe Damato <jdamato@fastly.com>
Cc: Edward Cree <ecree.xilinx@gmail.com>,
Network Development <netdev@vger.kernel.org>
Subject: Re: Per-queue stats question
Date: Fri, 16 Aug 2024 08:44:52 -0700 [thread overview]
Message-ID: <20240816084452.0af5ba00@kernel.org> (raw)
In-Reply-To: <Zr8ZtKXUgUo5OgSK@LQ3V64L9R2.home>
On Fri, 16 Aug 2024 10:19:48 +0100 Joe Damato wrote:
> On Thu, Aug 15, 2024 at 12:42:47PM -0700, Jakub Kicinski wrote:
> > > On a related note, I notice that the stat_cmp() function within that
> > > selftest returns the first nonzero delta it finds in the stats, so
> > > that if (say) tx-packets goes forwards but rx-packets goes backwards,
> > > it will return >0 causing the rx-packets delta to be ignored. Is
> > > this intended behaviour, or should I submit a patch?
> >
> > Looks like a bug.
>
> FWIW, while debugging the stats stuff on mlx5, I tweaked the
> stat_cmp function to output a lot more information about each of the
> values to help me debug.
>
> It seemed too verbose for an upstream patch at the time, but since
> you are going through the same process a patch might make a lot of
> sense.
We are in a desperate need of a better debugging flow :(
I hope Mohsin's patch to add verbose printing is ready soon,
it should be _a_ start.
prev parent reply other threads:[~2024-08-16 15:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-15 17:11 Per-queue stats question Edward Cree
2024-08-15 18:01 ` Simon Horman
2024-08-15 19:42 ` Jakub Kicinski
2024-08-16 9:19 ` Joe Damato
2024-08-16 15:44 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240816084452.0af5ba00@kernel.org \
--to=kuba@kernel.org \
--cc=ecree.xilinx@gmail.com \
--cc=jdamato@fastly.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.