From: Jakub Kicinski <kuba@kernel.org>
To: Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<horms@kernel.org>, <saeedm@nvidia.com>,
<anthony.l.nguyen@intel.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <andrew@lunn.ch>,
<corbet@lwn.net>, <linux-doc@vger.kernel.org>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<conor+dt@kernel.org>, <devicetree@vger.kernel.org>,
<horatiu.vultur@microchip.com>, <ruanjinjie@huawei.com>,
<steen.hegelund@microchip.com>, <vladimir.oltean@nxp.com>,
<masahiroy@kernel.org>, <alexanderduyck@fb.com>,
<krzk+dt@kernel.org>, <robh@kernel.org>, <rdunlap@infradead.org>,
<hkallweit1@gmail.com>, <linux@armlinux.org.uk>,
<UNGLinuxDriver@microchip.com>,
<Thorsten.Kummermehr@microchip.com>, <Pier.Beruto@onsemi.com>,
<Selvamani.Rajagopal@onsemi.com>, <Nicolas.Ferre@microchip.com>,
<benjamin.bigler@bernformulastudent.ch>, <linux@bigler.io>,
<markku.vorne@kempower.com>
Subject: Re: [PATCH net-next v6 10/14] net: ethernet: oa_tc6: implement receive path to receive rx ethernet frames
Date: Fri, 16 Aug 2024 10:01:47 -0700 [thread overview]
Message-ID: <20240816100147.0ed4acb6@kernel.org> (raw)
In-Reply-To: <20240812102611.489550-11-Parthiban.Veerasooran@microchip.com>
On Mon, 12 Aug 2024 15:56:07 +0530 Parthiban Veerasooran wrote:
> + if (netif_rx(tc6->rx_skb) == NET_RX_DROP)
> + tc6->netdev->stats.rx_dropped++;
This is a bit unusual. If the core decides to drop the packet it will
count the drop towards the appropriate statistic. The drivers generally
only count their own drops, and call netif_rx() without checking the
return value.
next prev parent reply other threads:[~2024-08-16 17:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 10:25 [PATCH net-next v6 00/14] Add support for OPEN Alliance 10BASE-T1x MACPHY Serial Interface Parthiban Veerasooran
2024-08-12 10:25 ` [PATCH net-next v6 01/14] Documentation: networking: add OPEN Alliance 10BASE-T1x MAC-PHY serial interface Parthiban Veerasooran
2024-08-12 10:25 ` [PATCH net-next v6 02/14] net: ethernet: oa_tc6: implement register write operation Parthiban Veerasooran
2024-08-12 10:26 ` [PATCH net-next v6 03/14] net: ethernet: oa_tc6: implement register read operation Parthiban Veerasooran
2024-08-12 10:26 ` [PATCH net-next v6 04/14] net: ethernet: oa_tc6: implement software reset Parthiban Veerasooran
2024-08-12 10:26 ` [PATCH net-next v6 05/14] net: ethernet: oa_tc6: implement error interrupts unmasking Parthiban Veerasooran
2024-08-12 10:26 ` [PATCH net-next v6 06/14] net: ethernet: oa_tc6: implement internal PHY initialization Parthiban Veerasooran
2024-08-12 10:26 ` [PATCH net-next v6 07/14] net: phy: microchip_t1s: add c45 direct access in LAN865x internal PHY Parthiban Veerasooran
2024-08-12 10:26 ` [PATCH net-next v6 08/14] net: ethernet: oa_tc6: enable open alliance tc6 data communication Parthiban Veerasooran
2024-08-12 10:26 ` [PATCH net-next v6 09/14] net: ethernet: oa_tc6: implement transmit path to transfer tx ethernet frames Parthiban Veerasooran
2024-08-16 16:55 ` Jakub Kicinski
2024-08-19 10:11 ` Parthiban.Veerasooran
2024-08-12 10:26 ` [PATCH net-next v6 10/14] net: ethernet: oa_tc6: implement receive path to receive rx " Parthiban Veerasooran
2024-08-16 17:01 ` Jakub Kicinski [this message]
2024-08-19 6:53 ` Parthiban.Veerasooran
2024-08-19 22:48 ` Jakub Kicinski
2024-08-20 5:10 ` Parthiban.Veerasooran
2024-08-12 10:26 ` [PATCH net-next v6 11/14] net: ethernet: oa_tc6: implement mac-phy interrupt Parthiban Veerasooran
2024-08-12 10:26 ` [PATCH net-next v6 12/14] net: ethernet: oa_tc6: add helper function to enable zero align rx frame Parthiban Veerasooran
2024-08-12 10:26 ` [PATCH net-next v6 13/14] microchip: lan865x: add driver support for Microchip's LAN865X MAC-PHY Parthiban Veerasooran
2024-08-16 17:05 ` Jakub Kicinski
2024-08-19 7:12 ` Parthiban.Veerasooran
2024-08-12 10:26 ` [PATCH net-next v6 14/14] dt-bindings: net: add Microchip's LAN865X 10BASE-T1S MACPHY Parthiban Veerasooran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240816100147.0ed4acb6@kernel.org \
--to=kuba@kernel.org \
--cc=Nicolas.Ferre@microchip.com \
--cc=Parthiban.Veerasooran@microchip.com \
--cc=Pier.Beruto@onsemi.com \
--cc=Selvamani.Rajagopal@onsemi.com \
--cc=Thorsten.Kummermehr@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexanderduyck@fb.com \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=benjamin.bigler@bernformulastudent.ch \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=horms@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@bigler.io \
--cc=markku.vorne@kempower.com \
--cc=masahiroy@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=ruanjinjie@huawei.com \
--cc=saeedm@nvidia.com \
--cc=steen.hegelund@microchip.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.