Re: linux-next: build failure after merge of the mm tree

[Stephen Rothwell <sfr@canb.auug.org.au>]

[-- Attachment #1: Type: text/plain, Size: 912 bytes --]

Hi Uros,

On Thu, 15 Aug 2024 09:42:51 +0200 Uros Bizjak <ubizjak@gmail.com> wrote:
>
> > Caused by commit
> >
> >   8e53757638ec ("err.h: add ERR_PTR_PCPU(), PTR_ERR_PCPU() and IS_ERR_PCPU() functions")
> >
> > Does include/linux/err.h really need to include asm/percpu.h?  __percpu is
> > defined in compiler_types.h which is included in every c code compile.  
> 
> Currently it is not needed, but with the proposed patch [1]
> 
> [1] https://lore.kernel.org/lkml/20240812115945.484051-4-ubizjak@gmail.com/
> 
> that repurposes __percpu to also include percpu named address
> qualifier, it will be needed, because per_cpu_qual will be defined in
> include/asm-generic/percpu.h.

How about putting these new functions in a new header file
(err_percpu.h?) and including that where needed?  Are there going to be
many places that need these new functions?

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]