All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Jones <ajones@ventanamicro.com>
To: qemu-devel@nongnu.org, qemu-riscv@nongnu.org
Cc: palmer@dabbelt.com, alistair.francis@wdc.com, bmeng.cn@gmail.com,
	dbarboza@ventanamicro.com, Anup Patel <apatel@ventanamicro.com>
Subject: [PATCH 0/2] hw/riscv/virt: Fix PCI devices with AIA
Date: Fri, 16 Aug 2024 18:07:44 +0200	[thread overview]
Message-ID: <20240816160743.220374-4-ajones@ventanamicro.com> (raw)

Linux does not properly handle '#msi-cells=<0>' when searching for
MSI controllers for PCI devices which results in the devices being
unable to use MSIs. A patch for Linux has been sent[1] but until it,
or something like it, is merged and in distro kernels we should stop
adding the property. It's harmless to stop adding it since the
absence of the property and a value of zero for the property mean
the same thing according to the DT binding definition.

The first patch stops adding the property by simply reverting the
patch that started adding it and should be applied for 9.1 since
it's a fix. The second patch allows users to bring it back by enabling
a new machine property 'strict-dt' which is meant to be used for cases
like these going forward. There's no rush for the second patch.

[1] https://lore.kernel.org/all/20240816124957.130017-2-ajones@ventanamicro.com/

Thanks,
drew

Andrew Jones (2):
  Revert "hw/riscv/virt.c: imsics DT: add '#msi-cells'"
  hw/riscv/virt: Introduce strict-dt

 docs/system/riscv/virt.rst | 11 ++++++++++
 hw/riscv/virt.c            | 44 +++++++++++++++++++++++++++++---------
 include/hw/riscv/virt.h    |  1 +
 3 files changed, 46 insertions(+), 10 deletions(-)

-- 
2.45.2



             reply	other threads:[~2024-08-16 16:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-16 16:07 Andrew Jones [this message]
2024-08-16 16:07 ` [PATCH for-9.1 1/2] Revert "hw/riscv/virt.c: imsics DT: add '#msi-cells'" Andrew Jones
2024-08-16 16:27   ` Philippe Mathieu-Daudé
2024-08-16 16:45     ` Philippe Mathieu-Daudé
2024-08-16 16:55   ` Daniel Henrique Barboza
2024-08-19  1:19   ` Alistair Francis
2024-08-16 16:07 ` [PATCH 2/2] hw/riscv/virt: Introduce strict-dt Andrew Jones
2024-08-19  1:19   ` Alistair Francis
2024-08-19  7:50     ` Andrew Jones
2024-08-19  8:42       ` Richard Henderson
2024-09-09  2:41       ` Alistair Francis
2024-09-09  8:44         ` Andrew Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240816160743.220374-4-ajones@ventanamicro.com \
    --to=ajones@ventanamicro.com \
    --cc=alistair.francis@wdc.com \
    --cc=apatel@ventanamicro.com \
    --cc=bmeng.cn@gmail.com \
    --cc=dbarboza@ventanamicro.com \
    --cc=palmer@dabbelt.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.