From: Simon Horman <horms@kernel.org>
To: Jeremy Kerr <jk@codeconstruct.com.au>
Cc: Matt Johnston <matt@codeconstruct.com.au>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: mctp: test: Use correct skb for route input check
Date: Fri, 16 Aug 2024 18:18:16 +0100 [thread overview]
Message-ID: <20240816171816.GE632411@kernel.org> (raw)
In-Reply-To: <20240816-mctp-kunit-skb-fix-v1-1-3c367ac89c27@codeconstruct.com.au>
On Fri, Aug 16, 2024 at 06:29:17PM +0800, Jeremy Kerr wrote:
> In the MCTP route input test, we're routing one skb, then (when delivery
> is expected) checking the resulting routed skb.
>
> However, we're currently checking the original skb length, rather than
> the routed skb. Check the routed skb instead; the original will have
> been freed at this point.
>
> Fixes: 8892c0490779 ("mctp: Add route input to socket tests")
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/kernel-janitors/4ad204f0-94cf-46c5-bdab-49592addf315@kili.mountain/
> Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-08-16 17:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-16 10:29 [PATCH net-next] net: mctp: test: Use correct skb for route input check Jeremy Kerr
2024-08-16 17:18 ` Simon Horman [this message]
2024-08-20 1:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240816171816.GE632411@kernel.org \
--to=horms@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jk@codeconstruct.com.au \
--cc=kuba@kernel.org \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.