From: Jakub Kicinski <kuba@kernel.org>
To: Menglong Dong <menglong8.dong@gmail.com>
Cc: pshelar@ovn.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, amorenoz@redhat.com, netdev@vger.kernel.org,
dev@openvswitch.org, linux-kernel@vger.kernel.org,
Menglong Dong <dongml2@chinatelecom.cn>
Subject: Re: [PATCH net-next] net: ovs: fix ovs_drop_reasons error
Date: Fri, 16 Aug 2024 18:01:04 -0700 [thread overview]
Message-ID: <20240816180104.3b843e93@kernel.org> (raw)
In-Reply-To: <20240815122245.975440-1-dongml2@chinatelecom.cn>
On Thu, 15 Aug 2024 20:22:45 +0800 Menglong Dong wrote:
> I'm sure if I understand it correctly, but it seems that there is
> something wrong with ovs_drop_reasons.
>
> ovs_drop_reasons[0] is "OVS_DROP_LAST_ACTION", but
> OVS_DROP_LAST_ACTION == __OVS_DROP_REASON + 1, which means that
> ovs_drop_reasons[1] should be "OVS_DROP_LAST_ACTION".
>
> Fix this by initializing ovs_drop_reasons with index.
>
> Fixes: 9d802da40b7c ("net: openvswitch: add last-action drop reason")
> Signed-off-by: Menglong Dong <dongml2@chinatelecom.cn>
Could you include output? Presumably from drop monitor?
I think it should go to net rather than net-next.
--
pw-bot: cr
next prev parent reply other threads:[~2024-08-17 1:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-15 12:22 [PATCH net-next] net: ovs: fix ovs_drop_reasons error Menglong Dong
2024-08-17 1:01 ` Jakub Kicinski [this message]
2024-08-17 11:36 ` Menglong Dong
2024-08-18 3:35 ` Menglong Dong
2024-08-19 22:56 ` Jakub Kicinski
2024-08-20 14:23 ` Adrián Moreno
2024-08-21 11:59 ` Menglong Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240816180104.3b843e93@kernel.org \
--to=kuba@kernel.org \
--cc=amorenoz@redhat.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=dongml2@chinatelecom.cn \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=menglong8.dong@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.