From: Al Viro <viro@zeniv.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-fsdevel@vger.kernel.org, Christian Brauner <brauner@kernel.org>
Subject: Re: [RFC] more close_range() fun
Date: Fri, 16 Aug 2024 19:15:45 +0100 [thread overview]
Message-ID: <20240816181545.GD504335@ZenIV> (raw)
In-Reply-To: <CAHk-=wh7NJnJeKroRhZsSRxWGM4uYTgONWX7Ad8V9suO=t777w@mail.gmail.com>
On Fri, Aug 16, 2024 at 10:55:30AM -0700, Linus Torvalds wrote:
> On Fri, 16 Aug 2024 at 10:19, Al Viro <viro@zeniv.linux.org.uk> wrote:
> >
> > All it takes, and IMO it's simpler that way.
>
> Hey, if it' simpler and gives more natural semantics, I obviously
> won't argue against it.
>
> That said, I do hate your "punch_hole" argument. At least make it a
> 'struct' with start/end, not a random int pointer, ok?
>
> Oh, and can we please make 'dup_fd()' return an error pointer instead
> of having that other int pointer argument for the error code?
As in https://lore.kernel.org/all/20240812064427.240190-11-viro@zeniv.linux.org.uk/?
Sure, I can separate it from dependency on alloc_fd() calling conventions
(previous patch in that series) and fold it into this one...
next prev parent reply other threads:[~2024-08-16 18:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-16 3:03 [RFC] more close_range() fun Al Viro
2024-08-16 3:07 ` Al Viro
2024-08-16 8:25 ` Christian Brauner
2024-08-16 11:15 ` Al Viro
2024-08-16 11:49 ` Al Viro
2024-08-16 16:26 ` Linus Torvalds
2024-08-16 17:19 ` Al Viro
2024-08-16 17:22 ` Al Viro
2024-08-16 17:55 ` Linus Torvalds
2024-08-16 17:58 ` Linus Torvalds
2024-08-16 18:15 ` Al Viro [this message]
2024-08-16 18:26 ` Linus Torvalds
2024-08-16 20:26 ` Al Viro
2024-08-16 23:35 ` Al Viro
2024-08-22 0:00 ` Al Viro
2024-10-04 4:52 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240816181545.GD504335@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.