From: Jakub Kicinski <kuba@kernel.org>
To: "Arinzon, David" <darinzon@amazon.com>
Cc: Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
"Woodhouse, David" <dwmw@amazon.co.uk>,
"Machulsky, Zorik" <zorik@amazon.com>,
"Matushevsky, Alexander" <matua@amazon.com>,
"Bshara, Saeed" <saeedb@amazon.com>,
"Wilson, Matt" <msw@amazon.com>,
"Liguori, Anthony" <aliguori@amazon.com>,
"Bshara, Nafea" <nafea@amazon.com>,
"Belgazal, Netanel" <netanel@amazon.com>,
"Saidi, Ali" <alisaidi@amazon.com>,
"Herrenschmidt, Benjamin" <benh@amazon.com>,
"Kiyanovski, Arthur" <akiyano@amazon.com>,
"Dagan, Noam" <ndagan@amazon.com>,
"Agroskin, Shay" <shayagr@amazon.com>,
"Itzko, Shahar" <itzko@amazon.com>,
"Abboud, Osama" <osamaabb@amazon.com>,
"Ostrovsky, Evgeny" <evostrov@amazon.com>,
"Tabachnik, Ofir" <ofirt@amazon.com>,
"Beider, Ron" <rbeider@amazon.com>,
"Chauskin, Igor" <igorch@amazon.com>,
"Bernstein, Amit" <amitbern@amazon.com>,
"Parav Pandit" <parav@nvidia.com>,
Cornelia Huck <cohuck@redhat.com>
Subject: Re: [PATCH v1 net-next 2/2] net: ena: Extend customer metrics reporting support
Date: Fri, 16 Aug 2024 19:01:48 -0700 [thread overview]
Message-ID: <20240816190148.7e915604@kernel.org> (raw)
In-Reply-To: <6236150118de4e499304ba9d0a426663@amazon.com>
On Fri, 16 Aug 2024 17:32:56 +0000 Arinzon, David wrote:
> > Xuan, Michael, the virtio spec calls out drops due to b/w limit being
> > exceeded, but AWS people say their NICs also count packets buffered but
> > not dropped towards a similar metric.
> >
> > I presume the virtio spec is supposed to cover the same use cases.
> > Have the stats been approved? Is it reasonable to extend the definition of
> > the "exceeded" stats in the virtio spec to cover what AWS specifies?
> > Looks like PR is still open:
> > https://github.com/oasis-tcs/virtio-spec/issues/180
>
> How do we move forward with this patchset?
> Regarding the counter itself, even though we don't support this at
> the moment, I would recommend to keep the queued and dropped as split
> (for example, add tx/rx-hw-queued-ratelimits, or something similar,
> if that makes sense).
Could you share some background for your recommendation?
As you say, the advice contradicts your own code :S
Let's iron this out for virtio's benefit.
You can resend the first patch separately in the meantime.
next prev parent reply other threads:[~2024-08-17 2:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-11 10:07 [PATCH v1 net-next 0/2] ENA driver metrics changes David Arinzon
2024-08-11 10:07 ` [PATCH v1 net-next 1/2] net: ena: Add ENA Express metrics support David Arinzon
2024-08-13 1:54 ` Jakub Kicinski
2024-08-13 11:21 ` Arinzon, David
2024-08-11 10:07 ` [PATCH v1 net-next 2/2] net: ena: Extend customer metrics reporting support David Arinzon
2024-08-13 1:58 ` Jakub Kicinski
2024-08-13 11:29 ` Arinzon, David
2024-08-13 15:10 ` Jakub Kicinski
2024-08-14 15:31 ` Arinzon, David
2024-08-14 19:11 ` Jakub Kicinski
2024-08-16 17:32 ` Arinzon, David
2024-08-17 2:01 ` Jakub Kicinski [this message]
2024-08-17 4:42 ` Arinzon, David
2024-08-21 18:03 ` Arinzon, David
2024-08-21 22:18 ` Jakub Kicinski
2024-08-27 16:41 ` Gal Pressman
2024-08-27 18:04 ` Jakub Kicinski
2024-08-27 18:33 ` Gal Pressman
2024-08-27 18:39 ` Jakub Kicinski
2024-08-28 3:59 ` Parav Pandit
2024-09-03 4:29 ` Arinzon, David
2024-09-04 8:05 ` Xuan Zhuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240816190148.7e915604@kernel.org \
--to=kuba@kernel.org \
--cc=akiyano@amazon.com \
--cc=aliguori@amazon.com \
--cc=alisaidi@amazon.com \
--cc=amitbern@amazon.com \
--cc=benh@amazon.com \
--cc=cohuck@redhat.com \
--cc=darinzon@amazon.com \
--cc=davem@davemloft.net \
--cc=dwmw@amazon.co.uk \
--cc=edumazet@google.com \
--cc=evostrov@amazon.com \
--cc=igorch@amazon.com \
--cc=itzko@amazon.com \
--cc=matua@amazon.com \
--cc=mst@redhat.com \
--cc=msw@amazon.com \
--cc=nafea@amazon.com \
--cc=ndagan@amazon.com \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=ofirt@amazon.com \
--cc=osamaabb@amazon.com \
--cc=pabeni@redhat.com \
--cc=parav@nvidia.com \
--cc=rbeider@amazon.com \
--cc=saeedb@amazon.com \
--cc=shayagr@amazon.com \
--cc=xuanzhuo@linux.alibaba.com \
--cc=zorik@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.