All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Subject: [PATCH 04/15] refs: mark unused parameters in do_for_each_reflog_helper()
Date: Sat, 17 Aug 2024 04:22:22 -0400	[thread overview]
Message-ID: <20240817082222.GD10287@coredump.intra.peff.net> (raw)
In-Reply-To: <20240817082101.GA6761@coredump.intra.peff.net>

This is an each_ref_fn callback, so it has to match that interface. We
marked most of these in 63e14ee2d6 (refs: mark unused each_ref_fn
parameters, 2022-08-19), but in this case:

  - this function was created in 31f898397b (refs: drop unused params
    from the reflog iterator callback, 2024-02-21), and most of the
    arguments were correctly mark as UNUSED, but "flags" was missed.

  - commit e8207717f1 (refs: add referent to each_ref_fn, 2024-08-09)
    added a new argument to the each_ref_fn callback. In most callbacks
    it added an UNUSED annotation, but it missed one case.

Signed-off-by: Jeff King <peff@peff.net>
---
 refs.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/refs.c b/refs.c
index 74de3d3009..584674520e 100644
--- a/refs.c
+++ b/refs.c
@@ -2390,9 +2390,10 @@ struct do_for_each_reflog_help {
 	void *cb_data;
 };
 
-static int do_for_each_reflog_helper(const char *refname, const char *referent,
+static int do_for_each_reflog_helper(const char *refname,
+				     const char *referent UNUSED,
 				     const struct object_id *oid UNUSED,
-				     int flags,
+				     int flags UNUSED,
 				     void *cb_data)
 {
 	struct do_for_each_reflog_help *hp = cb_data;
-- 
2.46.0.585.gd6679c16d8


  parent reply	other threads:[~2024-08-17  8:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-17  8:21 [PATCH 0/15] marking some more unused parameters Jeff King
2024-08-17  8:21 ` [PATCH 01/15] imap-send: mark unused parameter in ssl_socket_connect() fallback Jeff King
2024-08-17  8:21 ` [PATCH 02/15] update-ref: mark more unused parameters in parser callbacks Jeff King
2024-08-17  8:22 ` [PATCH 03/15] refs: mark unused parameters in ref_store fsck callbacks Jeff King
2024-08-17  8:22 ` Jeff King [this message]
2024-08-17  8:22 ` [PATCH 05/15] oss-fuzz: mark unused argv/argc argument Jeff King
2024-08-17  8:22 ` [PATCH 06/15] t/helper: mark more unused argv/argc arguments Jeff King
2024-08-17  8:23 ` [PATCH 07/15] unit-tests: ignore unused argc/argv Jeff King
2024-08-17  8:23 ` [PATCH 08/15] reftable: ignore unused argc/argv in test functions Jeff King
2024-08-17  8:24 ` [PATCH 09/15] reftable: drop obsolete test function declarations Jeff King
2024-08-17  8:24 ` [PATCH 10/15] reftable: mark unused parameters in virtual functions Jeff King
2024-08-17  8:24 ` [PATCH 11/15] t-hashmap: mark unused parameters in callback function Jeff King
2024-08-17 14:32   ` Ghanshyam Thakkar
2024-08-17 17:18     ` Jeff King
2024-08-17  8:25 ` [PATCH 12/15] test-mergesort: mark unused parameters in trivial callback Jeff King
2024-08-17  8:25 ` [PATCH 13/15] setup: mark unused parameter in config callback Jeff King
2024-08-17  8:25 ` [PATCH 14/15] daemon: mark unused parameters in non-posix fallbacks Jeff King
2024-08-17  8:25 ` [PATCH 15/15] scalar: mark unused parameters in dummy function Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240817082222.GD10287@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.