From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: linux1394-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org, Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [PATCH] firewire: ohci: fix error path to detect initiated reset in TI TSB41BA3D phy
Date: Sun, 18 Aug 2024 10:48:37 +0900 [thread overview]
Message-ID: <20240818014837.GA188655@workstation.local> (raw)
In-Reply-To: <20240817091128.180303-1-o-takashi@sakamocchi.jp>
On Sat, Aug 17, 2024 at 06:11:28PM +0900, Takashi Sakamoto wrote:
> A commit 404957c1e207 ("firewire: ohci: use guard macro to serialize
> accesses to phy registers") refactored initiated_reset() helper function,
> while the error path was changed wrongly.
>
> This commit fixes the bug.
>
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Fixes: 404957c1e207 ("firewire: ohci: use guard macro to serialize accesses to phy registers")
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> ---
> drivers/firewire/ohci.c | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
Applied to for-next branch.
Regards
Takashi Sakamoto
prev parent reply other threads:[~2024-08-18 1:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-17 9:11 [PATCH] firewire: ohci: fix error path to detect initiated reset in TI TSB41BA3D phy Takashi Sakamoto
2024-08-18 1:48 ` Takashi Sakamoto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240818014837.GA188655@workstation.local \
--to=o-takashi@sakamocchi.jp \
--cc=dan.carpenter@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.