From: Friedrich Vock <friedrich.vock@gmx.de>
To: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: "Christian König" <christian.koenig@amd.com>,
"Bas Nieuwenhuizen" <bas@basnieuwenhuizen.nl>,
"Tatsuyuki Ishi" <ishitatsuyuki@gmail.com>
Subject: [PATCH v3 1/3] drm/amdgpu: Don't implicit sync PRT maps.
Date: Mon, 19 Aug 2024 09:21:08 +0200 [thread overview]
Message-ID: <20240819072110.108715-2-friedrich.vock@gmx.de> (raw)
In-Reply-To: <20240819072110.108715-1-friedrich.vock@gmx.de>
From: Tatsuyuki Ishi <ishitatsuyuki@gmail.com>
These are considered map operations rather than unmap, and there is no
point of doing implicit synchronization here.
Signed-off-by: Tatsuyuki Ishi <ishitatsuyuki@gmail.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index bcb729094521..a4fc24dff04d 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
@@ -994,7 +994,7 @@ int amdgpu_vm_update_range(struct amdgpu_device *adev, struct amdgpu_vm *vm,
/* Implicitly sync to command submissions in the same VM before
* unmapping. Sync to moving fences before mapping.
*/
- if (!(flags & AMDGPU_PTE_VALID))
+ if (!(flags & (AMDGPU_PTE_VALID | AMDGPU_PTE_PRT)))
sync_mode = AMDGPU_SYNC_EQ_OWNER;
else
sync_mode = AMDGPU_SYNC_EXPLICIT;
--
2.46.0
next prev parent reply other threads:[~2024-08-19 7:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 7:21 [PATCH v3 0/3] drm/amdgpu: Explicit sync for GEM VA operations Friedrich Vock
2024-08-19 7:21 ` Friedrich Vock [this message]
2024-08-19 7:21 ` [PATCH v3 2/3] drm/amdgpu: Add optional explicit sync fences for GEM operations Friedrich Vock
2024-08-19 7:21 ` [PATCH v3 3/3] drm/amdgpu: Bump amdgpu driver version Friedrich Vock
2024-08-19 11:21 ` [PATCH v3 0/3] drm/amdgpu: Explicit sync for GEM VA operations Christian König
2024-08-20 13:36 ` Sharma, Shashank
2025-02-04 12:32 ` Friedrich Vock
2025-02-04 13:36 ` Christian König
2025-02-04 13:58 ` Alex Deucher
2025-02-06 17:33 ` Friedrich Vock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240819072110.108715-2-friedrich.vock@gmx.de \
--to=friedrich.vock@gmx.de \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bas@basnieuwenhuizen.nl \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ishitatsuyuki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.