All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/flashrom: fix cli with BR2_SHARED_LIBS
Date: Mon, 19 Aug 2024 10:39:54 +0200	[thread overview]
Message-ID: <20240819103954.5810fdd8@windsurf> (raw)
In-Reply-To: <CADvTj4pX3pQQavPnVyzR+R92DsjjJ0+SBoD8wXuhBk4drJmFrA@mail.gmail.com>

Hello James,

On Mon, 19 Aug 2024 02:31:02 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> > Is this fixing a build issue? If so, which one, which defconfig? Or
> > perhaps an autobuilder failure reference?
> 
> It fixes an issue where the flashlib cli was not being built at all,
> only the library was for BR2_SHARED_LIBS systems.

So there is no build issue, but parts that are expect to be built are
not built?

> > When was this problem introduced?
> 
> When bumping flashrom to version 1.4.0-rc2:
> https://github.com/buildroot/buildroot/commit/8637884057ddc3c1aeb9f0dd285fc6fcf378c26b

Thanks. Could you clarify both aspects in the commit log?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-08-19  8:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-19  4:02 [Buildroot] [PATCH 1/1] package/flashrom: fix cli with BR2_SHARED_LIBS James Hilliard
2024-08-19  8:27 ` Thomas Petazzoni via buildroot
2024-08-19  8:31   ` James Hilliard
2024-08-19  8:39     ` Thomas Petazzoni via buildroot [this message]
2024-08-19  8:46       ` James Hilliard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240819103954.5810fdd8@windsurf \
    --to=buildroot@buildroot.org \
    --cc=james.hilliard1@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.