From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EBBABC52D7C for ; Mon, 19 Aug 2024 08:43:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id B8B30605AA; Mon, 19 Aug 2024 08:43:27 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 3_zqXyBzaJaj; Mon, 19 Aug 2024 08:43:27 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=buildroot-bounces@buildroot.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org CDC2B607DE Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id CDC2B607DE; Mon, 19 Aug 2024 08:43:26 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 0C6401BF3EF for ; Mon, 19 Aug 2024 08:43:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id EFD43607DF for ; Mon, 19 Aug 2024 08:43:24 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id QiKfG3mcZTrA for ; Mon, 19 Aug 2024 08:43:24 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=217.70.183.194; helo=relay2-d.mail.gandi.net; envelope-from=thomas.petazzoni@bootlin.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org BAC85605AA DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org BAC85605AA Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by smtp3.osuosl.org (Postfix) with ESMTPS id BAC85605AA for ; Mon, 19 Aug 2024 08:43:23 +0000 (UTC) Received: by mail.gandi.net (Postfix) with ESMTPSA id C616C4000D; Mon, 19 Aug 2024 08:43:21 +0000 (UTC) Date: Mon, 19 Aug 2024 10:43:20 +0200 To: Luca Ceresoli Message-ID: <20240819104320.18538f1d@windsurf> In-Reply-To: <20240819103226.4895c5e3@booty> References: <20240815-boot-uboot-clean-for-pmufw-v1-0-3f0d9909c0b4@collins.com> <20240815-boot-uboot-clean-for-pmufw-v1-1-3f0d9909c0b4@collins.com> <20240819103226.4895c5e3@booty> Organization: Bootlin X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: thomas.petazzoni@bootlin.com X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1724057002; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VeNgtxQuau/3AvVKnqhe4NS7sZ0++FJXcWgADL0BSwQ=; b=XpfD2jbN36Hym5JmpuP9EWoUmjkqU21oLd8EH2gcAhvN1Iz9qqzE5XujulDxe5W8kqkoaF rcXsHurzMjkFY2IlX2luVeoRoVBrDFHGZ23XF5pKtYgHLYY5/zLiC9E77U5oK3//hcT+K8 wdEEK7i5NshWq0FUdgBA+pRknJCqI4OPZIRj2Ccgf9NMpiSUJOTCg62vuENl2+Pu8dxOB6 ZfHNJzOe+9/WVqP3FDhKVbBJmrcIosjmrh83sQN1vBXTAiVgXntklTZzNMMg2FXftYdYil apf48hA4RDwAwWp/zystjK1gW3PRRBlQjUewr3BNhPA+bkzus1EdKcKTfeapbQ== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=XpfD2jbN Subject: Re: [Buildroot] [PATCH 1/2] boot/uboot: avoid setting PMUFW_INIT_FILE when not used X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Thomas Petazzoni via buildroot Reply-To: Thomas Petazzoni Cc: Neal Frager , Brandon Maier , buildroot@buildroot.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" Hello, On Mon, 19 Aug 2024 10:32:26 +0200 Luca Ceresoli wrote: > I think there are two potential reasons for applying this patch: > > 1. setting an empty string lets the build finish apparently > successfully, but the output binaries are not working > > 2. allowing users to set CONFIG_PMUFW_INIT_FILE in their U-Boot config > and have Buildroot let it pass through > > For point 1, as I wrote earlier today I think this won't happen, based > on the U-Boot code. > > For point 2, which is the motivation you present in this patch, I don't > see a valid use case. Without a use case, I'd rather not add code to > uboot.mk, no matter if it is only a few lines. With a use case, I'd be > totally OK. My initial point was that I found it odd that: $(call KCONFIG_SET_OPT,CONFIG_PMUFW_INIT_FILE,"$(UBOOT_ZYNQMP_PMUFW_PATH_FINAL)") was done unconditionally. But in fact, it's done under the condition: ifeq ($(BR2_TARGET_UBOOT_ZYNQMP),y) so I think the code is indeed fine as it is. Thomas -- Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot