All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Oltean <olteanv@gmail.com>
To: Pieter <vtpieter@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Woojung Huh <woojung.huh@microchip.com>,
	UNGLinuxDriver@microchip.com,
	Florian Fainelli <f.fainelli@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Russell King <linux@armlinux.org.uk>,
	Pieter Van Trappen <pieter.van.trappen@cern.ch>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] net: dsa: microchip: add KSZ8 change_tag_protocol support
Date: Mon, 19 Aug 2024 17:44:22 +0300	[thread overview]
Message-ID: <20240819144422.fxop5fkg4ruoqh43@skbuf> (raw)
In-Reply-To: <CAHvy4ArnEy+28xO3_m6EPFQxOKR1cJNkWLEVbx6JFBzLj6VMUg@mail.gmail.com>

On Mon, Aug 19, 2024 at 04:41:29PM +0200, Pieter wrote:
> Hi Andrew, Vladimir,
> thanks for your explanation and patience!
> 
> It works as you said, I will have to do some changes to userspace to
> ensure the DHCP client uses br0 instead of eth0 but that's it.
> I just tried and br0 obtains the IP address and all is good, with
> DSA tagging enabled.
> 
> This patch can be dropped, sorry for the hassle.

I'm pretty baffled. Was this unclear from the user documentation at:
https://www.kernel.org/doc/html/next/networking/dsa/configuration.html
? Maybe we should change something to make it more clear that this is
what is expected.

  reply	other threads:[~2024-08-19 14:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-19 10:12 [PATCH net-next 1/2] dt-bindings: net: dsa: add none to dsa-tag-protocol enum vtpieter
2024-08-19 10:12 ` [PATCH net-next 2/2] net: dsa: microchip: add KSZ8 change_tag_protocol support vtpieter
2024-08-19 10:41   ` Vladimir Oltean
2024-08-19 12:05     ` Pieter
2024-08-19 13:05       ` Andrew Lunn
2024-08-19 13:21         ` Pieter
2024-08-19 13:27           ` Andrew Lunn
2024-08-19 13:43             ` Pieter
2024-08-19 14:05               ` Vladimir Oltean
2024-08-19 14:16                 ` Florian Fainelli
2024-08-19 14:20                 ` Pieter
2024-08-19 14:28                   ` Andrew Lunn
2024-08-19 14:41                     ` Pieter
2024-08-19 14:44                       ` Vladimir Oltean [this message]
2024-08-19 14:59                         ` Pieter
2024-08-19 14:35                   ` Vladimir Oltean
2024-08-19 14:13               ` Andrew Lunn
2024-08-19 10:58 ` [PATCH net-next 1/2] dt-bindings: net: dsa: add none to dsa-tag-protocol enum Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240819144422.fxop5fkg4ruoqh43@skbuf \
    --to=olteanv@gmail.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pieter.van.trappen@cern.ch \
    --cc=vtpieter@gmail.com \
    --cc=woojung.huh@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.