From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33DAFA93D; Tue, 20 Aug 2024 01:05:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724115950; cv=none; b=G0L/2c9+nIOVYJVH3BsztiW3Idq1MSjjCtdtwDvF3+90T85LrDsyLQbL+WanIbwCuTLd5TpxpT7dJh5jLMaE8PMlIYvVnRksiOc7lMe6EQ8+/VJIYp+trXfcXcm9BId+qQgeLomeOkesWD+0U75orLbkYa4M/zbN070trmdFVyE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724115950; c=relaxed/simple; bh=0U7jOid/uP8Y+iIqM7ITqWrx8b2Snwx2qFv6PcPMlns=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=kPFSQ1orFLn2kYINcP7nlhTF1smNqgHo6DdnhEEbEASPeGTe5e3PVeZoeBczZnGjCErGWTluULKa2FQyuT4BKBiHfDoHYDA5cP4PB7IFSuPQAzxI+nULXs2rEVdeMn6EIOMKviXxaheZU+M1emYJsu3M15mwbZBglje3IU3+N+w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=Ohr8uPnM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="Ohr8uPnM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA95FC32782; Tue, 20 Aug 2024 01:05:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1724115949; bh=0U7jOid/uP8Y+iIqM7ITqWrx8b2Snwx2qFv6PcPMlns=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Ohr8uPnMeT9PqbC27FNE2NUgwBSpD2Am8ljUhb2MkNtpvuqCxRgINXdfU+7Z5Ok4Q oLhpzo7qQb2Jy/L9reXhcowB+4RKVOZlFzvsJaEDLoJ4G/pXRebjYmXlqoj8xddMJJ umSfjfzu/bhamoXfiWzuJ1aWiSlwUJ4EuI/WZtuw= Date: Mon, 19 Aug 2024 18:05:48 -0700 From: Andrew Morton To: Linus Torvalds Cc: Nathan Chancellor , Guo Ren , Brian Cain , Dinh Nguyen , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Richard Weinberger , Anton Ivanov , Johannes Berg , Michael Ellerman , linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, christophe.leroy@csgroup.eu, jeffxu@google.com, Liam.Howlett@oracle.com, linux-kernel@vger.kernel.org, npiggin@gmail.com, oliver.sang@intel.com, pedro.falcato@gmail.com, linux-um@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon , Linux-sh list Subject: Re: [PATCH v2 1/4] mm: Add optional close() to struct vm_special_mapping Message-Id: <20240819180548.9f5dac3ac0bd09a26c0d0948@linux-foundation.org> In-Reply-To: References: <20240812082605.743814-1-mpe@ellerman.id.au> <20240819185253.GA2333884@thelio-3990X> <20240819195120.GA1113263@thelio-3990X> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-csky@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 19 Aug 2024 13:16:32 -0700 Linus Torvalds wrote: > On Mon, 19 Aug 2024 at 13:15, Linus Torvalds > wrote: > > > > Ok, I did a quick hack-job to remove that disgusting > > install_special_mapping() legacy case. > > > > With this [..] > > I forgot to actually attach that "this". Here it is. For real, this time. Thanks. Do you think your one-liner remains desirable with this fix in place?